fix(security): inline redact into appendSessionTranscriptMessage#79645
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. by source inspection: current main redacts the persisted JSONL entry but inline session, gateway, and Telegram transcript update paths still emit the original payload. I did not execute a live repro in this read-only review. Real behavior proof Next step before merge Security Review detailsBest possible solution: Land this PR or an equivalent maintainer-approved central append-layer redaction fix after resolving mergeability and accepting the additive SDK contract change, while preserving the source contributor credit from #73563. Do we have a high-confidence way to reproduce the issue? Yes, by source inspection: current main redacts the persisted JSONL entry but inline session, gateway, and Telegram transcript update paths still emit the original payload. I did not execute a live repro in this read-only review. Is this the best way to solve the issue? Yes, with maintainer acceptance: centralizing redaction at the append sink and returning the appended redacted message is the narrow maintainable fix. The remaining judgment is the public SDK return/config type change and branch mergeability, not a clear code defect in the latest head. Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against aa9799320d65. |
|
ClawSweeper 🐠 automerge status ClawSweeper finished this automerge repair pass without changing the branch. Executor outcome: source PR #79645 is paused by clawsweeper:human-review; refusing to mutate the PR branch. Worker actions:
No push, rebase, replacement PR, merge, or ClawSweeper re-review happened on this pass. fish notes: model gpt-5.5, reasoning high. Automerge progress:
|
c9600f1 to
804f6c8
Compare
5124701 to
08c0944
Compare
Co-authored-by: ziyitan <49604965+Ziy1-Tan@users.noreply.github.com>
…3 (validation-1) Co-authored-by: ziyitan <49604965+Ziy1-Tan@users.noreply.github.com>
Co-authored-by: ziyitan <49604965+Ziy1-Tan@users.noreply.github.com>
…3 (1) Co-authored-by: ziyitan <49604965+Ziy1-Tan@users.noreply.github.com>
…3 (1) Co-authored-by: ziyitan <49604965+Ziy1-Tan@users.noreply.github.com>
…3 (2) Co-authored-by: ziyitan <49604965+Ziy1-Tan@users.noreply.github.com>
Co-authored-by: ziyitan <49604965+Ziy1-Tan@users.noreply.github.com>
…3 (1) Co-authored-by: ziyitan <49604965+Ziy1-Tan@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Merged via squash.
|
Summary:
Verification:
Credit:
ClawSweeper 🐠 replacement reef notes:
fish notes: model gpt-5.5, reasoning high; reviewed against c9600f1.