fix(agents): fail fast on session lock fallback#78633
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. A high-confidence source-level path exists: configure a primary plus fallback and have the first candidate throw Real behavior proof Next step before merge Security Review detailsBest possible solution: Merge the narrow fallback-loop fail-fast guard after maintainer review and green required checks; handle any broader queue, retry, or backoff policy separately. Do we have a high-confidence way to reproduce the issue? Yes. A high-confidence source-level path exists: configure a primary plus fallback and have the first candidate throw Is this the best way to solve the issue? Yes for this PR's scope. The explicit session-lock escape at the fallback-loop boundary is the narrowest maintainable fix for stopping model substitution while preserving generic unknown-error fallback behavior. Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 372e270871a2. |
75d26c2 to
2d18c0b
Compare
Signed-off-by: sallyom <somalley@redhat.com>
Signed-off-by: sallyom <somalley@redhat.com>
Signed-off-by: sallyom <somalley@redhat.com>
Signed-off-by: sallyom <somalley@redhat.com>
Signed-off-by: sallyom <somalley@redhat.com>
Signed-off-by: sallyom <somalley@redhat.com>
Signed-off-by: sallyom <somalley@redhat.com>
Summary
Fixes #66646
Verification
pnpm test src/agents/model-fallback.test.ts src/agents/failover-error.test.ts