fix(io): add windowsHide to login shell env probe on Windows#78306
fix(io): add windowsHide to login shell env probe on Windows#78306XuZehan-iCenter wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close as superseded: this PR applies the right one-line So I’m closing this here and keeping the remaining discussion on the canonical linked item. Review detailsBest possible solution: Use #78266 as the canonical fix path for #78159, preserving its test assertions and changelog entry, then close the linked issue after that maintainer PR lands. Do we have a high-confidence way to reproduce the issue? Yes for the source-level root cause: current main reaches Is this the best way to solve the issue? No as the merge vehicle: the code direction is correct, but #78266 is the better canonical path because it covers the same fix with regression assertions and maintainer ownership. Closing this duplicate preserves the useful Windows proof while avoiding competing PRs for the same line. Security review: Security review cleared: The diff only adds a supported child-process display-suppression option and changelog text; it does not add dependencies, permissions, secret handling, downloads, or new execution paths. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 8e533490ab0a. Re-review progress:
|
b85aa0a to
15171d4
Compare
|
Changelog entry is already present in this PR (commit 15171d4a1c): |
The execLoginShellEnvZero helper was missing windowsHide: true, causing a PowerShell console window to flash briefly during gateway startup on Windows. This completes the fix started in openclaw#48320 and openclaw#70308 for the v2026.5.4 code path. Closes openclaw#78159
15171d4 to
d2693c2
Compare
Fixes #78159
The
execLoginShellEnvZerohelper was missingwindowsHide: true, causinga PowerShell console window to flash briefly during gateway startup on
Windows. This completes the fix started in #48320 and #70308 for the
v2026.5.4 code path.
Real behavior proof
Tested on Windows 10, Node.js v22.14.0, OpenClaw commit
b85aa0aabd:Before fix (reproduced with original code path)
Running
execFileSyncwithoutwindowsHideproduces a visible console window:After fix (with
windowsHide: trueapplied)Same probe with
windowsHide: truesuppresses the console window:The repro script exercises the same
execFileSyncpath used byexecLoginShellEnvZeroin
src/infra/shell-env.ts. WithwindowsHide: true, no console window isvisible during the probe.
Changelog
windowsHide: truetoexecLoginShellEnvZeroto preventPowerShell console flash during gateway startup on Windows. Fixes [Windows] execLoginShellEnvZero missing windowsHide:true — console flash on login shell env detection (2026.5.4) #78159.
Test results
All 19 existing
shell-envunit tests pass. No new tests needed — the change is aplatform-specific option addition.
Closes #78159