Skip to content

Commit 5527f4d

Browse files
committed
Shell env: hide Windows login probe
1 parent 41736de commit 5527f4d

3 files changed

Lines changed: 12 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Docs: https://docs.openclaw.ai
66

77
### Changes
88

9+
- Shell env/Windows: hide the login-shell environment probe child window so gateway startup and shell-env refreshes do not flash a console on Windows. Fixes #78159.
910
- MS Teams: surface blocked Bot Framework egress by logging JWKS fetch network failures and adding a Bot Connector send hint for transport-level reply failures. Fixes #77674. (#78081) Thanks @Beandon13.
1011
- PR triage: mark external pull requests with `proof: supplied` when Barnacle finds structured real behavior proof, keep stale negative proof labels in sync across CRLF-edited PR bodies, and let ClawSweeper own the stronger `proof: sufficient` judgement.
1112
- Sessions CLI: show the selected agent runtime in the `openclaw sessions` table so terminal output matches the runtime visibility already present in JSON/status surfaces. Thanks @vincentkoc.

src/infra/shell-env.test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,11 @@ describe("shell env fallback", () => {
112112

113113
function expectBinShFallbackExec(exec: ReturnType<typeof vi.fn>) {
114114
expect(exec).toHaveBeenCalledTimes(1);
115-
expect(exec).toHaveBeenCalledWith("/bin/sh", ["-l", "-c", "env -0"], expect.any(Object));
115+
expect(exec).toHaveBeenCalledWith(
116+
"/bin/sh",
117+
["-l", "-c", "env -0"],
118+
expect.objectContaining({ windowsHide: true }),
119+
);
116120
}
117121

118122
it("is disabled by default", () => {
@@ -423,7 +427,11 @@ describe("shell env fallback", () => {
423427

424428
expect(res.ok).toBe(true);
425429
expect(exec).toHaveBeenCalledTimes(1);
426-
expect(exec).toHaveBeenCalledWith(trustedShell, ["-l", "-c", "env -0"], expect.any(Object));
430+
expect(exec).toHaveBeenCalledWith(
431+
trustedShell,
432+
["-l", "-c", "env -0"],
433+
expect.objectContaining({ windowsHide: true }),
434+
);
427435
});
428436
});
429437

src/infra/shell-env.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ function execLoginShellEnvZero(params: {
9292
timeout: params.timeoutMs,
9393
maxBuffer: DEFAULT_MAX_BUFFER_BYTES,
9494
env: params.env,
95+
windowsHide: true,
9596
stdio: ["ignore", "pipe", "pipe"],
9697
});
9798
}

0 commit comments

Comments
 (0)