Ignore unsupported proxy schemes for env dispatcher#78040
Ignore unsupported proxy schemes for env dispatcher#78040bryce-d-greybeard wants to merge 1 commit into
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. for the PR-introduced regression: source inspection shows ALL_PROXY=socks5://... changes from configured EnvHttpProxyAgent options on current main to undefined in the PR. The exact external Weixin failure is not yet live-reproduced because the reporter's gateway proxy environment is missing. Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Rework the fix to preserve Undici-supported SOCKS env proxy routing, then reproduce #78007 with the gateway proxy environment and fix only malformed or genuinely unsupported proxy handling with diagnostics and regression coverage. Do we have a high-confidence way to reproduce the issue? Yes for the PR-introduced regression: source inspection shows ALL_PROXY=socks5://... changes from configured EnvHttpProxyAgent options on current main to undefined in the PR. The exact external Weixin failure is not yet live-reproduced because the reporter's gateway proxy environment is missing. Is this the best way to solve the issue? No. Filtering to HTTP(S) is not the narrowest maintainable fix because the pinned Undici path supports SOCKS proxy URLs; the safer path is to preserve supported proxies and diagnose the specific invalid or unreachable proxy case from #78007. Full review comments:
Overall correctness: patch is incorrect Security concerns:
Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against e28ad6a8697b. |
|
Thanks for taking a look at this. I reproduced #78007 against OpenClaw 2026.5.4 with
Standalone A trace of the failing OpenClaw path shows the underlying Undici cause is:
The repro environment had no Closing this PR as not the right fix for #78007. The issue should stay open for a fix in the OpenClaw runtime/Undici fetch path around plugin requests with |
Fixes #78007.
Summary
socks5:for the gateway/global Undici HTTP proxy dispatcherALL_PROXYfallback behaviorVerification
PATH="/tmp/openclaw-pnpm-shim:$PATH" node scripts/test-projects.mjs src/infra/net/proxy-env.test.ts src/infra/net/undici-global-dispatcher.test.ts --maxWorkers=1git diff --checkPATH="/tmp/openclaw-pnpm-shim:$PATH" node scripts/check-changed.mjs