Conversation
|
Codex review: needs changes before merge. Summary Reproducibility: yes. Source inspection gives a high-confidence path: current main preserves agent thread metadata outside the message tool, but Slack auto-threading only sees Next step before merge Security Review findings
Review detailsBest possible solution: Land the existing narrow routing and silent-completion filtering after adding a single-line changelog entry and completing maintainer review. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection gives a high-confidence path: current main preserves agent thread metadata outside the message tool, but Slack auto-threading only sees Is this the best way to solve the issue? Mostly yes. Forwarding the existing thread context through the message-tool seam and preserving explicit reply-mode opt-outs is the narrow maintainable fix; the missing changelog entry is the merge-readiness gap. Full review comments:
Overall correctness: patch is correct Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 978bc53e80cc. |
b21537e to
9d5991f
Compare
9d5991f to
f23486b
Compare
carry agent thread context into the message tool so resumed Slack parent sends inherit the ambient thread when no explicit threadId is provided
Summary
Root cause
Subagent completion resume paths preserved Slack thread metadata on the session, but the message tool was not receiving agentThreadId as a fallback current thread. Even when a thread id was present, missing replyToMode meant Slack auto-threading could stay inert. Separately, aggregated child completion findings converted successful ANNOUNCE_SKIP descendants into visible no-output completion content.
Behavior
This does not globally auto-thread all Slack sends. It restores ambient same-conversation thread context for message-tool sends when the agent session already has a thread context, matching the context sessions_spawn and resumed parent runs already carry. Explicit threadId and explicit reply-mode opt-outs still win.
Validation
AI-assisted: yes