fix(discord): avoid blocking startup on probe#77129
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. Source inspection on current main shows Discord startup awaits the 2.5s Next step before merge Security Review detailsBest possible solution: Land the asynchronous Discord startup probe and SDK-alias loader preservation after the remaining exact-head check completes and maintainer review is satisfied. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection on current main shows Discord startup awaits the 2.5s Is this the best way to solve the issue? Yes, with validation still pending. Moving only the enrichment probe off the startup path is the narrow maintainable fix for the reported startup blocking, and the latest loader alias change appears targeted at preserving existing plugin load contracts. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 86fc9e3279d1. Re-review progress:
|
791ac6b to
5b90807
Compare
1436088 to
0f62e75
Compare
* fix(discord): avoid blocking startup on probe * fix(discord): clear degraded probe status * test(plugin-sdk): isolate jiti loader override * test(plugin-sdk): fix circular facade fixture path * fix(plugins): preserve sdk aliases for native loads * fix(plugins): route sdk alias loads through transform
* fix(discord): avoid blocking startup on probe * fix(discord): clear degraded probe status * test(plugin-sdk): isolate jiti loader override * test(plugin-sdk): fix circular facade fixture path * fix(plugins): preserve sdk aliases for native loads * fix(plugins): route sdk alias loads through transform
* fix(discord): avoid blocking startup on probe * fix(discord): clear degraded probe status * test(plugin-sdk): isolate jiti loader override * test(plugin-sdk): fix circular facade fixture path * fix(plugins): preserve sdk aliases for native loads * fix(plugins): route sdk alias loads through transform
Summary
/users/@metimeouts do not block monitor startup.Fixes #77103.
Verification
pnpm exec oxfmt --check --threads=1 extensions/discord/src/channel.ts extensions/discord/src/channel.test.tspnpm test extensions/discord/src/channel.test.tspnpm check:changelog-attributionsgit diff --check origin/main...HEAD