fix: restore verbose tool progress in chats#76716
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. source-reproducible: current docs require in-flight Next step before merge Security Review detailsBest possible solution: Land this PR after maintainer review and exact-head gates so chat delivery stays aligned with the documented live Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible: current docs require in-flight Is this the best way to solve the issue? Yes: the PR is a narrow maintainable fix that refreshes session verbose state only at the affected delivery points, preserves one-shot run verbose when the session is older, and adds regression tests for both gateway and channel reply paths. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 39c5bbf08e12. |
24c0928 to
dc788ca
Compare
* fix: restore verbose tool progress in chats * test: fix gateway verbose mock types
* fix: restore verbose tool progress in chats * test: fix gateway verbose mock types
* fix: restore verbose tool progress in chats * test: fix gateway verbose mock types
* fix: restore verbose tool progress in chats * test: fix gateway verbose mock types
* fix: restore verbose tool progress in chats * test: fix gateway verbose mock types
What
Restore
/verbose on|full|offbehavior for tool-use chat bubbles in gateway and channel reply delivery paths.Why
Recent draft preview tool-progress changes could suppress default tool-use messages even after
/verbose on, and gateway tool events could keep using the run-start verbose snapshot instead of newer session state.Changes
Testing
pnpm test src/gateway/server-chat.agent-events.test.ts -- --reporter=verbosepnpm test src/auto-reply/reply/dispatch-from-config.test.ts -- --reporter=verbosepnpm exec oxfmt --check --threads=1 src/auto-reply/reply/dispatch-from-config.ts src/auto-reply/reply/dispatch-from-config.test.ts src/gateway/server-chat.ts src/gateway/server-chat.agent-events.test.tsgit diff --check