Skip to content

fix: restore verbose tool progress in chats#76716

Merged
jalehman merged 2 commits into
mainfrom
josh/fix-verbose-toggle-tool-events
May 3, 2026
Merged

fix: restore verbose tool progress in chats#76716
jalehman merged 2 commits into
mainfrom
josh/fix-verbose-toggle-tool-events

Conversation

@jalehman

@jalehman jalehman commented May 3, 2026

Copy link
Copy Markdown
Contributor

What

Restore /verbose on|full|off behavior for tool-use chat bubbles in gateway and channel reply delivery paths.

Why

Recent draft preview tool-progress changes could suppress default tool-use messages even after /verbose on, and gateway tool events could keep using the run-start verbose snapshot instead of newer session state.

Changes

  • Refresh gateway verbose state
  • Let verbose override preview suppression
  • Preserve one-shot verbose directives
  • Add regression coverage
  • Add changelog entry

Testing

  • pnpm test src/gateway/server-chat.agent-events.test.ts -- --reporter=verbose
  • pnpm test src/auto-reply/reply/dispatch-from-config.test.ts -- --reporter=verbose
  • pnpm exec oxfmt --check --threads=1 src/auto-reply/reply/dispatch-from-config.ts src/auto-reply/reply/dispatch-from-config.test.ts src/gateway/server-chat.ts src/gateway/server-chat.agent-events.test.ts
  • git diff --check

@openclaw-barnacle openclaw-barnacle Bot added gateway Gateway runtime size: S maintainer Maintainer-authored PR labels May 3, 2026
@clawsweeper

clawsweeper Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

Summary
The PR updates gateway and auto-reply chat delivery to re-read verbose state, let verbose override preview suppression, adds regression tests, and records the fix in the changelog.

Reproducibility: yes. source-reproducible: current docs require in-flight /verbose changes to affect later tool bubbles, while current main snapshots gateway run verbose and hard-suppresses preview progress in the shared delivery path. I did not run local tests because this review had to keep the checkout read-only, but the PR adds focused regression coverage.

Next step before merge
No ClawSweeper repair job is needed because the latest head addresses the previous mock-type blocker and no discrete remaining defect was found.

Security
Cleared: The diff is limited to chat delivery logic, regression tests, and changelog text; it adds no dependency, workflow, secret, permission, package-resolution, or code-execution surface.

Review details

Best possible solution:

Land this PR after maintainer review and exact-head gates so chat delivery stays aligned with the documented live /verbose contract.

Do we have a high-confidence way to reproduce the issue?

Yes, source-reproducible: current docs require in-flight /verbose changes to affect later tool bubbles, while current main snapshots gateway run verbose and hard-suppresses preview progress in the shared delivery path. I did not run local tests because this review had to keep the checkout read-only, but the PR adds focused regression coverage.

Is this the best way to solve the issue?

Yes: the PR is a narrow maintainable fix that refreshes session verbose state only at the affected delivery points, preserves one-shot run verbose when the session is older, and adds regression tests for both gateway and channel reply paths.

What I checked:

Likely related people:

  • steipete: Recent merged work repeatedly touched the auto-reply delivery path and its regression tests, including lazy loader refactors, diagnostic progress tracking, and visible reply delivery fixes. (role: recent maintainer; confidence: high; commits: 59fb9e5ca7fe, 2d8d50d418a2, 1c300cec5d80; files: src/auto-reply/reply/dispatch-from-config.ts, src/auto-reply/reply/dispatch-from-config.test.ts)
  • Takhoffman: Recent gateway work preserved and hydrated session/tool-event metadata on the same server-chat tool-event delivery surface touched by this PR. (role: adjacent owner; confidence: medium; commits: 9a57bdfdf14b, e890cde041f6, 8aace2b44828; files: src/gateway/server-chat.ts, src/gateway/server-chat.agent-events.test.ts)
  • frankbuild: Prior merged work fixed verbose tool summary delivery in channel replies, which overlaps the auto-reply verbose-progress behavior addressed here. (role: adjacent contributor; confidence: medium; commits: 74ed75f2e74d; files: src/auto-reply/reply/dispatch-from-config.ts, src/auto-reply/reply/dispatch-from-config.test.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 39c5bbf08e12.

@jalehman jalehman force-pushed the josh/fix-verbose-toggle-tool-events branch from 24c0928 to dc788ca Compare May 3, 2026 14:02
@jalehman jalehman self-assigned this May 3, 2026
@jalehman jalehman merged commit 30018bd into main May 3, 2026
112 checks passed
@jalehman jalehman deleted the josh/fix-verbose-toggle-tool-events branch May 3, 2026 14:14
lxe pushed a commit to lxe/openclaw that referenced this pull request May 6, 2026
* fix: restore verbose tool progress in chats

* test: fix gateway verbose mock types
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
* fix: restore verbose tool progress in chats

* test: fix gateway verbose mock types
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
* fix: restore verbose tool progress in chats

* test: fix gateway verbose mock types
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
* fix: restore verbose tool progress in chats

* test: fix gateway verbose mock types
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
* fix: restore verbose tool progress in chats

* test: fix gateway verbose mock types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gateway Gateway runtime maintainer Maintainer-authored PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant