fix(cli): reject unowned command roots before plugin load#76379
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. at source level. The linked issue has concrete Next step before merge Security Review detailsBest possible solution: Land this PR or an equivalent narrow fix after exact-head validation confirms Do we have a high-confidence way to reproduce the issue? Yes, at source level. The linked issue has concrete Is this the best way to solve the issue? Yes. The latest diff is the narrow maintainable direction: validate builtin or plugin CLI root ownership through manifest and CLI metadata before managed proxy startup, then avoid full runtime plugin loading for truly unowned roots. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 4795f3474ad5. |
e3f920b to
9cab572
Compare
9cab572 to
2bb8905
Compare
2bb8905 to
5c16a5c
Compare
Co-authored-by: Neil <neil@neilofneils.com>
5c16a5c to
a12a9ff
Compare
|
Landed via squash merge after rewriting the fix onto current main.
Thanks @neilofneils404! |
Co-authored-by: Neil <neil@neilofneils.com>
Co-authored-by: Neil <neil@neilofneils.com>
Summary
openclaw fooFixes #75287.
Tests
node scripts/run-node.mjs fooexits 1 with the unknown-command error and no surviving child processes