fix(discord): surface stalled transport health#76327
Conversation
26d58e3 to
5fd0a22
Compare
|
Codex review: needs changes before merge. Summary Reproducibility: yes. Source inspection of current main shows the status payload lacks event-loop health propagation, and the PR's remaining blocker is reproduced by exact-head CI plus generated Swift models that still omit eventLoop. Next step before merge Security Review findings
Review detailsBest possible solution: Ship the additive diagnostics with the protocol schema and generated client artifacts aligned, then let exact-head checks gate automerge. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection of current main shows the status payload lacks event-loop health propagation, and the PR's remaining blocker is reproduced by exact-head CI plus generated Swift models that still omit eventLoop. Is this the best way to solve the issue? No, not yet. The implementation direction is maintainable, but the protocol schema change must be paired with regenerated protocol artifacts before merge. Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 31ed93ff58db. |
5ec6e29 to
587fb0d
Compare
|
@clawsweeper automerge |
|
ClawSweeper 🐠 automerge status ClawSweeper took another look; no safe branch change was available on this pass. Executor outcome: source PR branch changed while the repair worker was preparing its push; requeue against the latest head. Worker actions:
No branch push, rebase, replacement PR, merge, or ClawSweeper re-review was started on this pass. fish notes: model gpt-5.5, reasoning high. Automerge progress:
|
587fb0d to
265ac3e
Compare
265ac3e to
ff35223
Compare
|
@clawsweeper automerge |
ff35223 to
5b2e8ac
Compare
* fix(discord): surface stalled transport health * fix(discord): surface stalled transport health * fix(discord): surface stalled transport health --------- Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
* fix(discord): surface stalled transport health * fix(discord): surface stalled transport health * fix(discord): surface stalled transport health --------- Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
* fix(discord): surface stalled transport health * fix(discord): surface stalled transport health * fix(discord): surface stalled transport health --------- Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Summary
runningwhile the transport is degraded or the Gateway event loop is starved, which makes intermittent socket resets look like healthy channel state.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause (if applicable)
channels.statusandstatus --deepreported process/account running state without carrying the existing Gateway event-loop health or per-account channel health classification through the RPC and CLI surfaces.Regression Test Plan (if applicable)
src/gateway/server-methods/channels.status.test.ts,src/commands/channels.surfaces-signal-runtime-errors-channels-status-output.test.ts,src/commands/status.command-sections.test.ts,extensions/discord/src/status-issues.test.ts,src/utils/fetch-timeout.test.ts.User-visible / Behavior Changes
openclaw channels status,openclaw status --deep, Discord status issue output, and fetch-timeout logs now include degraded transport/event-loop starvation hints when the Gateway has the data.Diagram (if applicable)
Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation: N/ARepro + Verification
Environment
openclaw-75346-hardened-statusfor patched live validation; current branch rebased on latestorigin/main.Steps
Expected
Actual
eventLoop.degraded: true, and the CLI/status issue paths expose the degraded health signals.Evidence
Validation run after rebase:
git diff --checkpnpm exec oxfmt --check --threads=1 CHANGELOG.mdpnpm check:changelog-attributionspnpm test src/gateway/server-methods/channels.status.test.ts extensions/discord/src/status-issues.test.ts src/commands/channels.surfaces-signal-runtime-errors-channels-status-output.test.ts src/commands/status.command-sections.test.ts src/utils/fetch-timeout.test.tsOPENCLAW_TESTBOX=1 pnpm check:changedontbx_01kqnjpj34468hzpshgp60hz8pHuman Verification (required)
Review Conversations
Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoRisks and Mitigations