fix(cron): route CLI-runtime cron models through compatible backend by clawsweeper[bot] · Pull Request #76319 · openclaw/openclaw

clawsweeper · 2026-05-03T00:00:28Z

Repair plan for #75840:

Keep the useful contributor fix on the existing branch.
In src/cron/isolated-agent/model-selection.ts, after normal model precedence resolves provider/model, derive a CLI execution provider with resolveCliRuntimeExecutionProvider using the resolved provider and cfgWithAgentDefaults. Replace the returned provider only when that helper returns a compatible CLI runtime such as claude-cli for anthropic models.
Add regression coverage in src/cron/isolated-agent.model-formatting.test.ts for the positive claude-cli plus anthropic case and the negative mismatched claude-cli plus openai override case from the ClawSweeper review.
Add a single-line CHANGELOG.md fix entry under Unreleased/Fixes crediting @vishutdhar.
Run pnpm test src/cron/isolated-agent.model-formatting.test.ts and pnpm check:changed, then rerun ClawSweeper /review on the exact repaired head before any merge-capable router proceeds.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-75840
Source PRs: fix(cron): honor agentRuntime.id when stamping cron session modelProvider #75840
Credit: Repair the existing contributor PR branch for fix(cron): honor agentRuntime.id when stamping cron session modelProvider #75840; preserve @vishutdhar as the source author.; If a changelog entry is added, include allowed attribution: Thanks @vishutdhar.; Do not add forbidden changelog attribution for @codex, @openclaw, @clawsweeper, or @steipete.
Validation: pnpm test src/cron/isolated-agent.model-formatting.test.ts; pnpm check:changed
Repair fallback: To https://github.com/vishutdhar/openclaw.git
! [remote rejected] HEAD -> fix/cron-session-cli-provider (refusing to allow a GitHub App to create or update workflow .github/workflows/ci.yml without workflows permission)
error: failed to push some refs to 'https://github.com/vishutdhar/openclaw.git'

fish notes: model gpt-5.5, reasoning high; reviewed against 02b6b6c.

chatgpt-codex-connector · 2026-05-03T00:00:40Z

To use Codex here, create a Codex account and connect to github.

clawsweeper · 2026-05-03T00:01:59Z

Codex review: passed.

Summary
The PR routes isolated cron executions through compatible configured CLI runtimes, threads agent identity into cron model selection, adds cron regression coverage, and records a changelog fix.

Reproducibility: yes. The source PR describes cron jobs for agents with agentRuntime.id="claude-cli" selecting Anthropic models, and the repaired PR adds focused unit coverage showing those canonical Anthropic attempts execute through claude-cli while OpenAI overrides stay on OpenAI.

Next step before merge
No repair lane is needed because the repaired exact head has no actionable review findings; automerge can rely on the normal exact-head check gate.

Security
Cleared: The diff only changes cron runtime-routing logic, tests, and changelog text; it does not add dependencies, workflow execution, secret handling, or broader permissions.

Review details

Best possible solution:

Land this narrow runtime-routing fix after the remaining exact-head checks finish green, preserving canonical model selection while using compatible CLI backends for execution.

Do we have a high-confidence way to reproduce the issue?

Yes. The source PR describes cron jobs for agents with agentRuntime.id="claude-cli" selecting Anthropic models, and the repaired PR adds focused unit coverage showing those canonical Anthropic attempts execute through claude-cli while OpenAI overrides stay on OpenAI.

Is this the best way to solve the issue?

Yes. Resolving the CLI backend inside the cron executor after canonical fallback selection mirrors the interactive path and avoids rewriting provider/model state for incompatible overrides.

What I checked:

Execution routing uses the shared compatibility helper: The PR resolves an executionProvider from the canonical provider, cfgWithAgentDefaults, and agentId, then uses that provider for CLI session lookup and runCliAgent. (src/cron/isolated-agent/run-executor.ts:139, ba2781de8fce)
Cron now passes the effective agent id: prepareCronRunContext passes agentId into resolveCronModelSelection, matching the previous review request for per-agent runtime visibility. (src/cron/isolated-agent/run.ts:557, ba2781de8fce)
Fallback execution regression covers CLI runtime routing: The new payload-fallbacks test keeps fallback planning on anthropic while asserting both primary and fallback attempts execute through claude-cli. (src/cron/isolated-agent/run.payload-fallbacks.test.ts:61, ba2781de8fce)
Model-selection regressions preserve provider compatibility: The new model-formatting tests cover per-agent and default Claude CLI runtime configs while keeping Anthropic selections canonical and OpenAI overrides on OpenAI. (src/cron/isolated-agent.model-formatting.test.ts:406, ba2781de8fce)
Shared helper contract is compatible-only: Current main's resolveCliRuntimeExecutionProvider only returns a CLI runtime for a configured runtime/provider pair, and checks agents.list when agentId is supplied before falling back to defaults. (src/agents/model-runtime-aliases.ts:108, 06cdb17ad281)
Interactive path uses the same pattern: The direct agent execution path already resolves cliExecutionProvider from the canonical provider, cfg, sessionAgentId, and runtimeOverride before deciding whether to run the CLI backend. (src/agents/command/attempt-execution.ts:398, 06cdb17ad281)

Likely related people:

steipete: Recent mainline history touches the cron executor, model-selection hardening, and runtime alias helper paths central to this PR. (role: recent maintainer; confidence: high; commits: 59fb9e5ca7fe, 732aa11f2bec, 343f2d724593; files: src/cron/isolated-agent/run-executor.ts, src/cron/isolated-agent/model-selection.ts, src/agents/model-runtime-aliases.ts)
vincentkoc: Introduced/maintained the provider runtime normalization and cron runtime seam work that this PR reuses. (role: adjacent owner; confidence: medium; commits: aa27e27f3606, 35176f3cb730; files: src/agents/model-runtime-aliases.ts, src/cron/isolated-agent/model-selection.ts)
jalehman: Recent cron isolated-run maintenance appears in the same executor area, including self-removal and context-engine/session-key fixes. (role: adjacent cron maintainer; confidence: medium; commits: 12c52963ea80, a3c51f91c58a, 8ba82534e6c9; files: src/cron/isolated-agent/run-executor.ts, src/cron/isolated-agent/run.ts)

Remaining risk / open question:

One exact-head check-run, check-additional-boundaries, was still in progress during this read-only review; required checks should gate merge.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 06cdb17ad281.

clawsweeper · 2026-05-03T00:05:34Z

🦞🦞
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=ba2781de8fceefabe18216bd97648920288dbe41)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-03T00:31:32Z
Merge commit: 004e8716569c

What merged:

The PR routes isolated cron executions through compatible configured CLI runtimes, threads agent identity into cron model selection, adds cron regression coverage, and records a changelog fix.
Reproducibility: yes. The source PR describes cron jobs for agents with agentRuntime.id="claude-cli" selecti ... howing those canonical Anthropic attempts execute through claude-cli while OpenAI overrides stay on OpenAI.

Fixups included:

Included follow-up commit: fix(cron): route CLI-runtime cron models through compatible backend
Included follow-up commit: fix(clawsweeper): address review for automerge-openclaw-openclaw-7584…
Ran the ClawSweeper repair loop before final review.

The automerge loop is complete.

Automerge progress:

2026-05-03 00:05:16 UTC review requested repair [`02b6b6c04410`](https://github.com/openclaw/openclaw/commit/02b6b6c0441095bf2d44745ffd8033466611f203) (structured ClawSweeper marker: fix-required (finding=review-feedback sha=02b6b6...)
2026-05-03 00:05:33 UTC repair queued [`02b6b6c04410`](https://github.com/openclaw/openclaw/commit/02b6b6c0441095bf2d44745ffd8033466611f203) (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/25265232234
2026-05-03 00:26:50 UTC repair completed [`ba2781de8fce`](https://github.com/openclaw/openclaw/commit/ba2781de8fceefabe18216bd97648920288dbe41) (branch updated) in 18m 37s Run: https://github.com/openclaw/clawsweeper/actions/runs/25265232234 initial automerge rebase is delegated to Codex repair
2026-05-03 00:26:50 UTC review queued [`ba2781de8fce`](https://github.com/openclaw/openclaw/commit/ba2781de8fceefabe18216bd97648920288dbe41) (after repair)
2026-05-03 00:31:23 UTC review passed [`ba2781de8fce`](https://github.com/openclaw/openclaw/commit/ba2781de8fceefabe18216bd97648920288dbe41) (structured ClawSweeper verdict: pass (sha=ba2781de8fceefabe18216bd97648920288db...)
2026-05-03 00:31:35 UTC merged [`ba2781de8fce`](https://github.com/openclaw/openclaw/commit/ba2781de8fceefabe18216bd97648920288dbe41) (merged by ClawSweeper automerge)

Co-authored-by: vishutdhar <68405187+vishutdhar@users.noreply.github.com>

…0 (1)

…penclaw#76319) Summary: - The PR routes isolated cron executions through compatible configured CLI runtimes, threads agent identity into cron model selection, adds cron regression coverage, and records a changelog fix. - Reproducibility: yes. The source PR describes cron jobs for agents with agentRuntime.id="claude-cli" selecti ... howing those canonical Anthropic attempts execute through claude-cli while OpenAI overrides stay on OpenAI. ClawSweeper fixups: - Included follow-up commit: fix(cron): route CLI-runtime cron models through compatible backend - Included follow-up commit: fix(clawsweeper): address review for automerge-openclaw-openclaw-7584… - Ran the ClawSweeper repair loop before final review. Validation: - ClawSweeper review passed for head ba2781d. - Required merge gates passed before the squash merge. Prepared head SHA: ba2781d Review: openclaw#76319 (comment) Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: vishutdhar <68405187+vishutdhar@users.noreply.github.com>

clawsweeper Bot added size: S clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge clawsweeper Tracked by ClawSweeper automation labels May 3, 2026

clawsweeper Bot mentioned this pull request May 3, 2026

fix(cron): honor agentRuntime.id when stamping cron session modelProvider #75840

Closed

openclaw-barnacle Bot added size: XS and removed size: S labels May 3, 2026

clawsweeper Bot and others added 3 commits May 3, 2026 00:24

fix(cron): route CLI-runtime cron models through compatible backend

5ee1f48

Co-authored-by: vishutdhar <68405187+vishutdhar@users.noreply.github.com>

fix(cron): route CLI-runtime cron models through compatible backend

b58e84f

fix(clawsweeper): address review for automerge-openclaw-openclaw-7584…

ba2781d

…0 (1)

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-75840 branch from 02b6b6c to ba2781d Compare May 3, 2026 00:26

openclaw-barnacle Bot added size: S and removed size: XS labels May 3, 2026

clawsweeper Bot merged commit 004e871 into main May 3, 2026
89 of 90 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-75840 branch May 3, 2026 00:31

github-actions Bot mentioned this pull request May 3, 2026

📡 Upstream Digest — 2026-05-03 02:05 UTC curtismercier/openclaw-mods#751

Open

This was referenced May 3, 2026

fix: route remaining cli-backed helper runs through CLI paths #72499

Open

[cron] Model override rejected despite being in agents.defaults.models allowlist (provider prefix normalization mismatch) #77234

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cron): route CLI-runtime cron models through compatible backend#76319

fix(cron): route CLI-runtime cron models through compatible backend#76319
clawsweeper[bot] merged 3 commits intomainfrom
clawsweeper/automerge-openclaw-openclaw-75840

clawsweeper Bot commented May 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 3, 2026

Uh oh!

clawsweeper Bot commented May 3, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Uh oh!

Conversation

clawsweeper Bot commented May 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 3, 2026

Uh oh!

clawsweeper Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

clawsweeper Bot commented May 3, 2026 •

edited

Loading

clawsweeper Bot commented May 3, 2026 •

edited

Loading