Skip to content

Rename Codex runtime prompt snapshot directory#76274

Merged
pashpashpash merged 3 commits intomainfrom
codex/rename-codex-runtime-happy-path
May 2, 2026
Merged

Rename Codex runtime prompt snapshot directory#76274
pashpashpash merged 3 commits intomainfrom
codex/rename-codex-runtime-happy-path

Conversation

@pashpashpash
Copy link
Copy Markdown
Contributor

@pashpashpash pashpashpash commented May 2, 2026

The prompt snapshot fixtures started out under a generic happy-path directory. After adding the reconstructed Codex runtime prompt layers, that name became too broad: the snapshots are specifically for the Codex runtime happy path, not every OpenClaw happy path.

This renames the fixture directory to codex-runtime-happy-path and updates the generator, tests, and docs to use the more precise path. The snapshot contents stay the same aside from generated path metadata.

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation scripts Repository scripts size: S maintainer Maintainer-authored PR labels May 2, 2026
@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 2, 2026 •
edited
Loading

Codex review: needs maintainer review before merge.

Summary
Renames the Codex prompt snapshot fixture directory to codex-runtime-happy-path and updates the generator, drift tests, committed fixtures, and prompt/CI docs to use that path.

Reproducibility: yes. for the prior review finding: pnpm prompt:snapshots:check and test/scripts/prompt-snapshots.test.ts compare generated snapshot output with committed fixtures. I did not run them locally because this was a read-only review, but the latest PR head now formats Markdown snapshots in the generator to match the committed fixture formatting.

Next step before merge
No repair lane is needed: the earlier automated finding appears fixed by the latest commit, and the remaining work is normal maintainer review plus exact-head CI completion.

Security
Cleared: The diff only touches docs, tests, generated fixtures, and an internal snapshot generator path, with no new dependency, workflow permission, secret handling, lockfile, or package-publishing change.

Review details

Best possible solution:

Merge the rename after maintainer review and exact-head CI confirm the generator, fixtures, tests, and docs stay in sync.

Do we have a high-confidence way to reproduce the issue?

Yes for the prior review finding: pnpm prompt:snapshots:check and test/scripts/prompt-snapshots.test.ts compare generated snapshot output with committed fixtures. I did not run them locally because this was a read-only review, but the latest PR head now formats Markdown snapshots in the generator to match the committed fixture formatting.

Is this the best way to solve the issue?

Yes. Updating the shared fixture-directory constant, generator stale-file logic, drift tests, fixtures, and docs is the narrow maintainable path; the latest generator change also makes the Markdown formatting intentional rather than ad hoc.

What I checked:

  • Protected label: The pull request API response shows labels docs, scripts, maintainer, and size: S; maintainer is protected for cleanup-close decisions. (13a1c192cb6d)
  • Current main surface: Current main still defines prompt snapshots under test/fixtures/agents/prompt-snapshots/happy-path, so the PR is changing an active generator/test surface. (test/helpers/agents/happy-path-prompt-snapshots.ts:26, ae82a39150f9)
  • Latest PR head fixes previous drift class: The latest PR head formats both .md and .json generated snapshot files, making the one-line Markdown JSON arrays canonical generator output instead of hand-edited drift. (scripts/generate-prompt-snapshots.ts:43, 13a1c192cb6d)
  • Renamed directory wired into generator/tests: The PR head exports CODEX_RUNTIME_HAPPY_PATH_PROMPT_SNAPSHOT_DIR and the drift test reads committed artifacts from that renamed directory. (test/scripts/prompt-snapshots.test.ts:17, 13a1c192cb6d)
  • Docs updated with new path: The system-prompt docs now describe the committed prompt snapshots as Codex runtime happy-path snapshots under the renamed fixture directory. Public docs: docs/concepts/system-prompt.md. (docs/concepts/system-prompt.md:114, 13a1c192cb6d)
  • Exact-head CI status sampled: At review time, check, build-smoke, and checks-fast-contracts-channels were successful on the latest head, while check-additional-boundaries, checks-node-core-fast-support, and checks-node-core-runtime-infra were still in progress. (13a1c192cb6d)

Likely related people:

  • pashpashpash: Merged commit 9e57b98bb944807b10eaf7e11208c07a20743dc7 added the Codex happy-path prompt snapshot generator, drift test, and docs in the same paths this PR updates. (role: introduced behavior and recent maintainer; confidence: high; commits: 9e57b98bb944; files: scripts/generate-prompt-snapshots.ts, test/helpers/agents/happy-path-prompt-snapshots.ts, test/scripts/prompt-snapshots.test.ts)
  • Peter Steinberger: Recent current-main work touched the Codex/system-prompt docs adjacent to this snapshot documentation surface. (role: recent adjacent maintainer; confidence: medium; commits: 9fdc0e703077; files: docs/concepts/system-prompt.md)

Remaining risk / open question:

  • Exact-head CI had three in-progress lanes during review, including check-additional-boundaries, which is the CI area that contains pnpm prompt:snapshots:check. The merge gate should wait for those to finish.

Codex review notes: model gpt-5.5, reasoning high; reviewed against ae82a39150f9.

@pashpashpash pashpashpash force-pushed the codex/rename-codex-runtime-happy-path branch from 55057bd to 13a1c19 Compare May 2, 2026 22:22
@pashpashpash pashpashpash merged commit bcb2476 into main May 2, 2026
80 checks passed
@pashpashpash pashpashpash deleted the codex/rename-codex-runtime-happy-path branch May 2, 2026 22:35
vincentkoc added a commit that referenced this pull request May 2, 2026
@vincentkoc
Merge branch 'main' of https://github.com/openclaw/openclaw
595bb6f 
* 'main' of https://github.com/openclaw/openclaw:
  Rename Codex runtime prompt snapshot directory (#76274)
  fix(plugins): canonicalize install provenance paths
@clawsweeper clawsweeper Bot mentioned this pull request May 2, 2026
Merged
lxe pushed a commit to lxe/openclaw that referenced this pull request May 6, 2026
@pashpashpash @lxe
Rename Codex runtime prompt snapshot directory (openclaw#76274)
edfb89d 
* test: rename Codex runtime prompt snapshots

* test: refresh prompt snapshots with node24

* test: format prompt snapshot markdown in generator
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
@pashpashpash
Rename Codex runtime prompt snapshot directory (openclaw#76274)
216a5ec 
* test: rename Codex runtime prompt snapshots

* test: refresh prompt snapshots with node24

* test: format prompt snapshot markdown in generator
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
@vincentkoc
Merge branch 'main' of https://github.com/openclaw/openclaw
34c6640 
* 'main' of https://github.com/openclaw/openclaw:
  Rename Codex runtime prompt snapshot directory (openclaw#76274)
  fix(plugins): canonicalize install provenance paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Improvements or additions to documentation maintainer Maintainer-authored PR scripts Repository scripts size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pashpashpash