fix: repair configured plugin installs#76129
Conversation
|
@clawsweeper automerge |
|
Codex review: passed. Summary Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction path: current main lacks the release-stamped configured-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. Next step before merge Security Review detailsBest possible solution: Land the scoped release repair after exact-head automerge gates pass, keeping package installation limited to explicit doctor repair/update paths and preserving the upgrade-survivor coverage. Do we have a high-confidence way to reproduce the issue? Yes. Static inspection of current main and the PR head gives a high-confidence reproduction path: current main lacks the release-stamped configured-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. Is this the best way to solve the issue? Yes. The latest head uses existing doctor repair, ClawHub/npm installer, installed-index, and upgrade-survivor seams instead of adding startup/load-time migrations, which is the narrow maintainable direction for this release repair. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 4532e5d85803. |
|
🦞🦞 Source: What merged:
Fixups included:
The automerge loop is complete. Automerge progress:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 487565be6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local requests_file="$ARTIFACT_ROOT/clawhub-not-found-requests.jsonl" | ||
| if ! grep -q '/api/v1/packages/%40openclaw%2Fmatrix' "$requests_file" 2>/dev/null; then |
There was a problem hiding this comment.
Skip fixture log assertion when ClawHub URL is overridden
This assertion always reads clawhub-not-found-requests.jsonl, but start_configured_plugin_installs_clawhub_fixture intentionally returns early when OPENCLAW_CLAWHUB_URL/CLAWHUB_URL is pre-set, so that file is never created in override environments. The configured-plugin-installs scenario will then fail even if doctor correctly attempted ClawHub against the external URL. Guard this check behind the same fixture condition (or assert via another signal) to avoid false failures.
Useful? React with 👍 / 👎.
|
@clawsweeper automerge |
4f765e0 to
d781161
Compare
|
@clawsweeper automerge |
d781161 to
d3519ce
Compare
|
@clawsweeper automerge |
Summary: - The PR adds a 2026.5.2 doctor repair pass for actively used configured downloadable plugins, prefers ClawHub ... pm fallback, records installed plugin state, extends upgrade-survivor coverage, and updates docs/changelog. - Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction ... d-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. ClawSweeper fixups: - Included follow-up commit: test: cover configured plugin install update path - Included follow-up commit: test: isolate channel option metadata cache - Included follow-up commit: fix: keep configured plugin repair scoped Validation: - ClawSweeper review passed for head d3519ce. - Required merge gates passed before the squash merge. Prepared head SHA: d3519ce Review: openclaw#76129 (comment) Co-authored-by: Peter Steinberger <steipete@gmail.com>
Summary: - The PR adds a 2026.5.2 doctor repair pass for actively used configured downloadable plugins, prefers ClawHub ... pm fallback, records installed plugin state, extends upgrade-survivor coverage, and updates docs/changelog. - Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction ... d-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. ClawSweeper fixups: - Included follow-up commit: test: cover configured plugin install update path - Included follow-up commit: test: isolate channel option metadata cache - Included follow-up commit: fix: keep configured plugin repair scoped Validation: - ClawSweeper review passed for head d3519ce. - Required merge gates passed before the squash merge. Prepared head SHA: d3519ce Review: openclaw#76129 (comment) Co-authored-by: Peter Steinberger <steipete@gmail.com>
Summary: - The PR adds a 2026.5.2 doctor repair pass for actively used configured downloadable plugins, prefers ClawHub ... pm fallback, records installed plugin state, extends upgrade-survivor coverage, and updates docs/changelog. - Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction ... d-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. ClawSweeper fixups: - Included follow-up commit: test: cover configured plugin install update path - Included follow-up commit: test: isolate channel option metadata cache - Included follow-up commit: fix: keep configured plugin repair scoped Validation: - ClawSweeper review passed for head d3519ce42ce196d37d971de9b2c5e7cb4a3629c0. - Required merge gates passed before the squash merge. Prepared head SHA: d3519ce42ce196d37d971de9b2c5e7cb4a3629c0 Review: openclaw/openclaw#76129 (comment) Co-authored-by: Peter Steinberger <steipete@gmail.com>
Summary: - The PR adds a 2026.5.2 doctor repair pass for actively used configured downloadable plugins, prefers ClawHub ... pm fallback, records installed plugin state, extends upgrade-survivor coverage, and updates docs/changelog. - Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction ... d-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. ClawSweeper fixups: - Included follow-up commit: test: cover configured plugin install update path - Included follow-up commit: test: isolate channel option metadata cache - Included follow-up commit: fix: keep configured plugin repair scoped Validation: - ClawSweeper review passed for head d3519ce42ce196d37d971de9b2c5e7cb4a3629c0. - Required merge gates passed before the squash merge. Prepared head SHA: d3519ce42ce196d37d971de9b2c5e7cb4a3629c0 Review: openclaw/openclaw#76129 (comment) Co-authored-by: Peter Steinberger <steipete@gmail.com>
Summary: - The PR adds a 2026.5.2 doctor repair pass for actively used configured downloadable plugins, prefers ClawHub ... pm fallback, records installed plugin state, extends upgrade-survivor coverage, and updates docs/changelog. - Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction ... d-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. ClawSweeper fixups: - Included follow-up commit: test: cover configured plugin install update path - Included follow-up commit: test: isolate channel option metadata cache - Included follow-up commit: fix: keep configured plugin repair scoped Validation: - ClawSweeper review passed for head d3519ce42ce196d37d971de9b2c5e7cb4a3629c0. - Required merge gates passed before the squash merge. Prepared head SHA: d3519ce42ce196d37d971de9b2c5e7cb4a3629c0 Review: openclaw/openclaw#76129 (comment) Co-authored-by: Peter Steinberger <steipete@gmail.com>
Summary: - The PR adds a 2026.5.2 doctor repair pass for actively used configured downloadable plugins, prefers ClawHub ... pm fallback, records installed plugin state, extends upgrade-survivor coverage, and updates docs/changelog. - Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction ... d-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. ClawSweeper fixups: - Included follow-up commit: test: cover configured plugin install update path - Included follow-up commit: test: isolate channel option metadata cache - Included follow-up commit: fix: keep configured plugin repair scoped Validation: - ClawSweeper review passed for head d3519ce. - Required merge gates passed before the squash merge. Prepared head SHA: d3519ce Review: openclaw#76129 (comment) Co-authored-by: Peter Steinberger <steipete@gmail.com>
Summary: - The PR adds a 2026.5.2 doctor repair pass for actively used configured downloadable plugins, prefers ClawHub ... pm fallback, records installed plugin state, extends upgrade-survivor coverage, and updates docs/changelog. - Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction ... d-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. ClawSweeper fixups: - Included follow-up commit: test: cover configured plugin install update path - Included follow-up commit: test: isolate channel option metadata cache - Included follow-up commit: fix: keep configured plugin repair scoped Validation: - ClawSweeper review passed for head d3519ce. - Required merge gates passed before the squash merge. Prepared head SHA: d3519ce Review: openclaw#76129 (comment) Co-authored-by: Peter Steinberger <steipete@gmail.com>
Summary: - The PR adds a 2026.5.2 doctor repair pass for actively used configured downloadable plugins, prefers ClawHub ... pm fallback, records installed plugin state, extends upgrade-survivor coverage, and updates docs/changelog. - Reproducibility: yes. Static inspection of current main and the PR head gives a high-confidence reproduction ... d-plugin install pass, while the PR tests the new repair-only path, success stamping, and warning behavior. ClawSweeper fixups: - Included follow-up commit: test: cover configured plugin install update path - Included follow-up commit: test: isolate channel option metadata cache - Included follow-up commit: fix: keep configured plugin repair scoped Validation: - ClawSweeper review passed for head d3519ce. - Required merge gates passed before the squash merge. Prepared head SHA: d3519ce Review: openclaw#76129 (comment) Co-authored-by: Peter Steinberger <steipete@gmail.com>
No description provided.