Guard current browser tab exports#75731
Conversation
|
Codex review: needs changes before merge. Summary Reproducibility: yes. Source inspection shows the latest PR head still routes Next step before merge Security Review findings
Review detailsBest possible solution: Keep the shared opt-in guard, apply it to Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows the latest PR head still routes Is this the best way to solve the issue? No, not yet. The shared helper is the right maintainable direction, but the PR should use it for snapshot before any collection path instead of relying on backend-specific checks and a changelog claim. Full review comments:
Overall correctness: patch is incorrect Security concerns:
Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against edddb07f2055. Re-review progress:
|
|
@clawsweeper review |
|
🦞🦞 I asked ClawSweeper to review this item again. |
|
Standards check for the latest branch update:
Validation on
CI is queued for the pushed SHA. |
* fix(browser): guard current tab exports * fix(browser): expand tab guard coverage * fix(browser): guard tab reads * fix(browser): guard screenshot route * changelog: PR openclaw#75731 --------- Co-authored-by: Devin Robison <drobison@nvidia.com>
* fix(browser): guard current tab exports * fix(browser): expand tab guard coverage * fix(browser): guard tab reads * fix(browser): guard screenshot route * changelog: PR openclaw#75731 --------- Co-authored-by: Devin Robison <drobison@nvidia.com>
* fix(browser): guard current tab exports * fix(browser): expand tab guard coverage * fix(browser): guard tab reads * fix(browser): guard screenshot route * changelog: PR openclaw#75731 --------- Co-authored-by: Devin Robison <drobison@nvidia.com>
* fix(browser): guard current tab exports * fix(browser): expand tab guard coverage * fix(browser): guard tab reads * fix(browser): guard screenshot route * changelog: PR openclaw#75731 --------- Co-authored-by: Devin Robison <drobison@nvidia.com>
* fix(browser): guard current tab exports * fix(browser): expand tab guard coverage * fix(browser): guard tab reads * fix(browser): guard screenshot route * changelog: PR openclaw#75731 --------- Co-authored-by: Devin Robison <drobison@nvidia.com>
Summary
Changes
enforceCurrentUrlAllowedtowithRouteTabContextandwithPlaywrightRouteContext, using the existing browser navigation result policy and proxy-mode handling.Validation
corepack pnpm test -- extensions/browser/src/browser/routes/agent.shared.test.ts extensions/browser/src/browser/server.agent-contract-form-layout-act-commands.test.tscorepack pnpm checkcorepack pnpm exec oxfmt --check extensions/browser/src/browser/routes/agent.shared.ts extensions/browser/src/browser/routes/agent.debug.ts extensions/browser/src/browser/routes/agent.act.ts extensions/browser/src/browser/routes/agent.shared.test.ts extensions/browser/src/browser/server.agent-contract-form-layout-act-commands.test.ts extensions/browser/src/browser/server.control-server.test-harness.tsNotes
corepack pnpm format:checkcurrently reports unrelated formatting drift outside this change.