fix(heartbeat): make phase scheduling active-hours-aware (#75487)#75597
Merged
clawsweeper[bot] merged 8 commits intomainfrom May 2, 2026
Merged
fix(heartbeat): make phase scheduling active-hours-aware (#75487)#75597clawsweeper[bot] merged 8 commits intomainfrom
clawsweeper[bot] merged 8 commits intomainfrom
Conversation
Contributor
|
Codex review: passed. Summary Reproducibility: yes. Current main can be reproduced with a Next step before merge Security Review detailsBest possible solution: Land this PR through the existing automerge path, keeping the runtime active-hours guard as the final backstop. Do we have a high-confidence way to reproduce the issue? Yes. Current main can be reproduced with a Is this the best way to solve the issue? Yes. The PR is the narrow scheduler-layer fix: it seeks through phase-aligned slots with the existing active-hours predicate, handles config/timezone changes, and leaves the runtime guard intact. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 0fad53a19281. |
Member
Author
|
/clawsweeper automerge |
Contributor
|
🦞🦞 Source: What merged:
Fixups included:
The automerge loop is complete. Automerge progress:
|
cb4e2ae to
ce0e563
Compare
ce0e563 to
02a1283
Compare
vincentkoc
added a commit
that referenced
this pull request
May 2, 2026
* 'main' of https://github.com/openclaw/openclaw: Wizard: bound hatch TUI timeout (#76241) fix(cli): reject codex simple-completion probes fix: memoize plugin descriptor config keys (#76240) fix(heartbeat): make phase scheduling active-hours-aware (#75487) (#75597)
lxe
pushed a commit
to lxe/openclaw
that referenced
this pull request
May 6, 2026
) (openclaw#75597) Summary: - The PR adds active-hours-aware heartbeat phase seeking, wires runner scheduling and config reloads through it, adds scheduler/e2e coverage, and records the user-facing fix in the changelog. - Reproducibility: yes. Current main can be reproduced with a `4h` heartbeat and an `Asia/Shanghai` active-hours window during a quiet-hours restart: main arms raw UTC-phase slots and only skips when the timer fires. ClawSweeper fixups: - Included follow-up commit: fix(heartbeat): recompute schedule when activeHours config changes vi… - Included follow-up commit: fix(heartbeat): add iteration cap to active-hours seek + edge-case tests - Included follow-up commit: chore: clean up redundant code comments - Included follow-up commit: fix(heartbeat): make phase scheduling active-hours-aware (openclaw#75487) - Included follow-up commit: fix(clawsweeper): address review for automerge-openclaw-openclaw-7559… Validation: - ClawSweeper review passed for head 02a1283. - Required merge gates passed before the squash merge. Prepared head SHA: 02a1283 Review: openclaw#75597 (comment) Co-authored-by: Alex Knight <aknight@atlassian.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
) (openclaw#75597) Summary: - The PR adds active-hours-aware heartbeat phase seeking, wires runner scheduling and config reloads through it, adds scheduler/e2e coverage, and records the user-facing fix in the changelog. - Reproducibility: yes. Current main can be reproduced with a `4h` heartbeat and an `Asia/Shanghai` active-hours window during a quiet-hours restart: main arms raw UTC-phase slots and only skips when the timer fires. ClawSweeper fixups: - Included follow-up commit: fix(heartbeat): recompute schedule when activeHours config changes vi… - Included follow-up commit: fix(heartbeat): add iteration cap to active-hours seek + edge-case tests - Included follow-up commit: chore: clean up redundant code comments - Included follow-up commit: fix(heartbeat): make phase scheduling active-hours-aware (openclaw#75487) - Included follow-up commit: fix(clawsweeper): address review for automerge-openclaw-openclaw-7559… Validation: - ClawSweeper review passed for head 02a1283. - Required merge gates passed before the squash merge. Prepared head SHA: 02a1283 Review: openclaw#75597 (comment) Co-authored-by: Alex Knight <aknight@atlassian.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
* 'main' of https://github.com/openclaw/openclaw: Wizard: bound hatch TUI timeout (openclaw#76241) fix(cli): reject codex simple-completion probes fix: memoize plugin descriptor config keys (openclaw#76240) fix(heartbeat): make phase scheduling active-hours-aware (openclaw#75487) (openclaw#75597)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #75487.
computeNextHeartbeatPhaseDueMscomputes next-fire times using pure UTC-epoch modular arithmetic.activeHourswas only checked as a runtime execution guard inrunHeartbeatOnce— when a quiet-hours slot was skipped,advanceAgentSchedulecomputed the next slot (also in UTC) which could also be in quiet hours.This caused:
Asia/Shanghai, multiple consecutive phase slots falling outside the active window before the next in-window slotChanges
src/infra/heartbeat-schedule.tsseekNextActivePhaseDueMs()— takes a starting slot and anisActivepredicate, iterates forward through phase-aligned slots (up to a 7-day horizon), and returns the first in-window slot. Falls back to the raw slot if no active slot is found within the horizon (so the runtime guard can still gate execution).src/infra/heartbeat-runner.tsadvanceAgentSchedulenow wraps the computed next-due time withseekNextActivePhaseDueMs, usingisWithinActiveHoursas the predicate.updateConfiginitial scheduling also seeks forward to the first in-window slot on startup/config reload.