fix(cron): prefer finalAssistantVisibleText over raw error text in task summary#74840
fix(cron): prefer finalAssistantVisibleText over raw error text in task summary#74840andyliu wants to merge 1 commit into
Conversation
…sk summary When a cron agentTurn run had no non-error payloads (e.g. a tool call failed and the agent self-corrected via LLM output rather than an explicit messaging tool call), fallbackSummary fell through to pickSummaryFromOutput(firstText) where firstText was the tool error payload. Introduce finalAssistantVisibleText as an intermediate fallback in both fallbackSummary and fallbackOutputText so that the agent's self-corrected reply is surfaced instead of the raw error text. Closes openclaw#74807
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. by source inspection. Calling Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Repair Do we have a high-confidence way to reproduce the issue? Yes, by source inspection. Calling Is this the best way to solve the issue? No. The PR adds final assistant text only after payload fallbacks have already selected error text and before an unchanged fatal delivery override replaces the result with the error again. Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against a6aa48350b7e. |
Summary
Targeted single-fix PR.
Closes #74807
🤖 Generated with Claude Code