fix(cron): prefer finalAssistantVisibleText over raw error text in task summary

andyliu · andyliu · commit ae085b9e6bcd · 2026-04-30T12:21:35.000+08:00
When a cron agentTurn run had no non-error payloads (e.g. a tool call failed and the agent self-corrected via LLM output rather than an explicit messaging tool call), fallbackSummary fell through to pickSummaryFromOutput(firstText) where firstText was the tool error payload. Introduce finalAssistantVisibleText as an intermediate fallback in both fallbackSummary and fallbackOutputText so that the agent's self-corrected reply is surfaced instead of the raw error text. Closes #74807
diff --git a/src/cron/isolated-agent/helpers.ts b/src/cron/isolated-agent/helpers.ts
@@ -258,9 +258,17 @@ export function resolveCronPayloadOutcome(params: {
   preferFinalAssistantVisibleText?: boolean;
 }): CronPayloadOutcome {
   const firstText = params.payloads[0]?.text ?? "";
+  const normalizedFinalAssistantVisibleTextEarly = normalizeOptionalString(
+    params.finalAssistantVisibleText,
+  );
   const fallbackSummary =
-    pickSummaryFromPayloads(params.payloads) ?? pickSummaryFromOutput(firstText);
-  const fallbackOutputText = pickLastNonEmptyTextFromPayloads(params.payloads);
+    pickSummaryFromPayloads(params.payloads) ??
+    (normalizedFinalAssistantVisibleTextEarly
+      ? pickSummaryFromOutput(normalizedFinalAssistantVisibleTextEarly)
+      : undefined) ??
+    pickSummaryFromOutput(firstText);
+  const fallbackOutputText =
+    pickLastNonEmptyTextFromPayloads(params.payloads) ?? normalizedFinalAssistantVisibleTextEarly;
   const deliveryPayload = pickLastDeliverablePayload(params.payloads);
   const selectedDeliveryPayloads = pickDeliverablePayloads(params.payloads);
   const deliveryPayloadHasStructuredContent = payloadHasStructuredDeliveryContent(deliveryPayload);
