fix(feishu): reply inside P2P direct-message threads#73972
fix(feishu): reply inside P2P direct-message threads#73972openclaw-clownfish[bot] wants to merge 1 commit intomainfrom
Conversation
|
Closing this PR because the author has more than 10 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
Greptile SummaryThis PR fixes Feishu P2P direct-message thread replies by detecting Confidence Score: 5/5This PR is safe to merge — the change is narrowly scoped to P2P thread detection and leaves group and non-thread DM paths unchanged. The directThreadReply flag is derived from a reliable combination of chatType === 'p2p' and a non-null thread_id, skipReplyToInMessages and replyInThread are updated consistently across both the broadcast and non-broadcast dispatcher call sites, the ACP error path is also updated, and both happy-path test cases match the assertions. No logic gaps found. No files require special attention. Reviews (2): Last reviewed commit: "fix(feishu): reply inside P2P direct-mes..." | Re-trigger Greptile |
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. A source-level reproduction is a Feishu event with Next step before merge Security Review detailsBest possible solution: Refresh this patch onto current main or open an equivalent mergeable replacement, keep the Feishu regression coverage and changelog entry, run Do we have a high-confidence way to reproduce the issue? Yes. A source-level reproduction is a Feishu event with Is this the best way to solve the issue? Yes, after branch refresh. The PR’s approach is the narrow maintainable fix because it uses P2P What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against bd6035d97707. |
|
/clownfish automerge |
c99fce0 to
2f9535c
Compare
Repair #38808 against main 79159f1. Preserve the contributor branch and credit @LiaoyuanNing. Keep the fix scoped to Feishu P2P direct-message thread routing: detect direct messages with thread_id, reply to the thread root with replyInThread/threadReply enabled, preserve the non-thread path for root_id-only P2P quote replies, and leave group behavior unchanged. Keep or add focused regression coverage for P2P thread replies and P2P plain quote replies. Run pnpm check:changed and a clean Codex /review before merge. After the PR lands, close #38806 as implemented. #66631 is intentionally out of scope because it concerns Feishu topic-group thread_id-only root resolution.
ProjectClownfish replacement details:
! [remote rejected] HEAD -> fix/feishu-p2p-thread-reply (refusing to allow a GitHub App to create or update workflow
.github/workflows/ci.ymlwithoutworkflowspermission)error: failed to push some refs to 'https://github.com/LiaoyuanNing/openclaw.git'