Greptile Summary

This PR fixes a regression (#33789) where Feishu bot replies to messages inside P2P (direct message) threads were sent as standalone messages instead of staying inside the thread. It also includes a fix (#38757) that prevents resolved plaintext API key secrets from being persisted to models.json.

Feishu P2P thread fix (extensions/feishu/src/bot.ts)

• Introduces isDmThread = isDirect && Boolean(ctx.threadId) to detect when a DM message is inside a thread (using the thread_id field per Feishu API docs)
• Threads this flag through all four reply-control variables: replyInThread, replyTargetMessageId (ctx.rootId ?? ctx.messageId), threadReply, and skipReplyToInMessages (isDirect && !isDmThread)
• Regular DMs and group thread behaviour are unchanged

API key plaintext prevention (src/agents/models-config.providers.ts)

• Adds ENV_VAR_NAME_RE and a reverse-lookup block in normalizeProviders that detects when apiKey holds a resolved secret value and replaces it with the canonical env-var name before writing to models.json
• New tests cover both the unit-level normalizeProviders behaviour and the end-to-end ensureOpenClawModelsJson path

No automated tests were added for the P2P thread fix in bot.ts; coverage relies on the manual test plan in the PR description.

Confidence Score: 5/5

• This PR is safe to merge; the logic changes are narrow, well-scoped, and consistent across all affected call sites.
• The Feishu change threads a single boolean (isDmThread) through four variables in a consistent, symmetric way. All group and regular-DM paths remain unchanged. The models-config reverse-lookup is guarded by ENV_VAR_NAME_RE to avoid double-processing and only activates when the env-var value matches the stored key. Both new code paths are covered by tests.
• No files require special attention.

_{Last reviewed commit: 39b4532}

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

Closing this as duplicate or superseded after Codex automated review.

Close #38996 as duplicate/superseded. Current main still lacks the Feishu P2P thread reply fix, but open PR #38808 tracks the same #38806 regression and contains the same direct-thread routing change plus targeted P2P regression tests. PR #38814 was already closed in favor of #38808, making #38808 the established canonical item for this fix family.

Best possible solution:

Close #38996 as superseded by open PR #38808. Continue review or landing work on #38808, preserving its P2P thread and P2P plain-reply regression tests, and keep #38806 open until the fix reaches main.

What I checked:

• Current main still disables DM thread replies: On current main, handleFeishuMessage sets replyInThread to false for every non-group Feishu message, so a P2P event carrying thread_id still cannot enter thread reply mode. (extensions/feishu/src/bot.ts:609, 46b9044c3f9d)
• Current main still strips DM reply targets: Both active dispatcher call sites pass skipReplyToInMessages: !isGroup; createFeishuReplyDispatcher then clears replyToMessageId when that flag is true, so direct messages do not reach the reply API path with the target preserved. (extensions/feishu/src/bot.ts:1273, 46b9044c3f9d)
• Current tests only cover group thread_id behavior: The visible regression test named forces thread replies when inbound message contains thread_id uses chat_type: "group"; targeted search found no P2P thread routing test or isDirect && Boolean(ctx.threadId) implementation on main. (extensions/feishu/src/bot.test.ts:2535, 46b9044c3f9d)
• Open PR fix(feishu): reply inside thread for P2P direct messages #38808 is the canonical same fix: GitHub API metadata shows fix(feishu): reply inside thread for P2P direct messages #38808 is open and unmerged, fixes the same [Bug]: bot replies outside thread in P2P direct message thread #38806 bug, changes extensions/feishu/src/bot.ts to detect direct thread messages, and adds two extensions/feishu/src/bot.test.ts cases for P2P thread and P2P plain-reply behavior. (1bd355587b9e)
• Prior duplicate was already closed in favor of fix(feishu): reply inside thread for P2P direct messages #38808: PR fix(feishu): reply inside P2P threads instead of main chat #38814 is closed and unmerged, and its discussion includes the maintainer comment: Closing in favor of #38808 which landed first with the same approach.. (f270cda8b42d)
• Latest release is not a shipped fix: The latest release tag still has the old non-group reply/thread gating, so fix(feishu): reply inside P2P thread instead of as standalone message #38996 should not close as implemented-on-main or shipped. (extensions/feishu/src/bot.ts:583, cbcfdf62c729)

So I’m closing this here and keeping the remaining discussion on the canonical linked item.

Codex Review notes: model gpt-5.5, reasoning high; reviewed against 46b9044c3f9d.