Fix Trinity main-session compatibility mismatch by vincentkoc · Pull Request #73388 · openclaw/openclaw

vincentkoc · 2026-04-28T07:42:41Z

Summary

Compare the arcee/trinity-large-thinking main-session path with the subagent path.
Normalize or guard the remaining response-shape/path mismatch so Trinity is not selectable into a bricking main-session state.
Keep the existing current-main connection-error failover behavior from [Bug] Main lane failover is too slow for provider transport failures, allowing TUI/Telegram degradation before fallback #62848 intact.

Credit

Credit to @Adam-Researchh for the reports in #62851 and #62847. #62848 documents the already-landed failover behavior this PR should preserve.

Validation

pnpm -s vitest run src/agents/pi-embedded-helpers.isbillingerrormessage.test.ts
pnpm check:changed

ProjectClownfish replacement details:

Cluster: ghcrawl-156908-autonomous-smoke
Source PRs: none
Credit: Credit Adam-Researchh for reporting the Trinity main-session/subagent mismatch in [Bug] arcee/trinity-large-thinking works as subagent but fails as main session, suggesting lane/path mismatch #62851 and the original bricking symptom in [Bug] Main session can brick on arcee/trinity-large-thinking: repeated connection errors, TUI spam, Telegram nonresponsive until delayed fallback #62847.; Mention that [Bug] Main lane failover is too slow for provider transport failures, allowing TUI/Telegram degradation before fallback #62848 already covered the transport failover loop; this follow-up is limited to the remaining compatibility/path mismatch.
Validation: pnpm -s vitest run src/agents/pi-embedded-helpers.isbillingerrormessage.test.ts; pnpm check:changed

greptile-apps · 2026-04-28T07:43:51Z

Greptile Summary

This PR fixes a main-session compatibility issue with arcee/trinity-large-thinking by adding supportsTools: false to its compat block in extensions/arcee/models.ts. This prevents the model from being dispatched with a tool-bearing request shape in the main-session path, aligning it with the text-only shape already used in the subagent recovery path. Tests are added for both the direct and OpenRouter catalog paths to assert the new compat flag.

Confidence Score: 5/5

Safe to merge — the change is a one-line targeted compat flag addition with direct test coverage on both catalog paths.

The diff is minimal (one property added to a model definition), the existing buildArceeModelDefinition spread already handles compat correctly, normalizeResolvedModel preserves compat via object spread, and the new test assertions cover both the direct and OpenRouter catalog paths. No logic errors or regressions identified.

No files require special attention.

_{Reviews (1): Last reviewed commit: "Fix Trinity main-session compatibility m..." | Re-trigger Greptile}

clawsweeper · 2026-04-28T19:53:34Z

Codex review: passed.

Summary
The PR marks Arcee Trinity Large Thinking tool-incompatible in catalog/config/runtime paths, updates Arcee docs and changelog, and adds provider regression tests.

Reproducibility: yes. The linked reports provide concrete main-session failure logs, and current main still exposes Trinity without compat.supportsTools:false while the runtime sends tools unless that flag is false.

Next step before merge
No repair candidate is indicated; review findings are empty and the remaining action is exact-head automerge/CI gating.

Security
Cleared: The diff changes provider metadata/policy, docs, changelog, and tests without adding third-party dependencies, workflows, secrets handling, install scripts, or publishing changes.

Review details

Best possible solution:

Land the Arcee-owned compat/config normalization patch after exact-head checks and mergeability are green, then let the linked Trinity reports close through the merge.

Do we have a high-confidence way to reproduce the issue?

Yes. The linked reports provide concrete main-session failure logs, and current main still exposes Trinity without compat.supportsTools:false while the runtime sends tools unless that flag is false.

Is this the best way to solve the issue?

Yes. The PR uses existing provider-owned catalog, config-normalization, public-artifact, and resolved-model compat seams instead of adding a core special case.

What I checked:

Current main lacks Trinity tool guard: Current main defines trinity-large-thinking with supportsReasoningEffort:false but no supportsTools:false, so tool-bearing main-session dispatch remains reachable. (extensions/arcee/models.ts:47, 15bbf4f2f304)
Main-session runtime honors supportsTools: supportsModelTools disables tools only when compat.supportsTools is explicitly false, and the embedded main attempt checks that helper before deciding whether file/tool access is available. (src/agents/model-tool-support.ts:1, 15bbf4f2f304)
PR adds provider-owned compatibility policy: The PR adds ARCEE_TRINITY_LARGE_THINKING_COMPAT with supportsTools:false, recognizes direct and Arcee-prefixed Trinity ids, and normalizes stale provider configs through the Arcee policy helper. (extensions/arcee/provider-policy.ts:7, 4c669d66cb15)
PR wires runtime compat without core special casing: The Arcee provider applies Trinity compat while normalizing resolved OpenRouter models, delegates config normalization to the policy helper, and contributes resolved-model compat through the existing provider hook. (extensions/arcee/index.ts:101, 4c669d66cb15)
Regression coverage and docs are included: The diff adds assertions for onboarding catalog, direct catalog, OpenRouter catalog, stale config normalization, resolved model compat, and the lightweight provider-policy artifact, plus docs and changelog updates. (extensions/arcee/index.test.ts:69, 4c669d66cb15)
Related issue context supports the target bug: The PR body credits [Bug] arcee/trinity-large-thinking works as subagent but fails as main session, suggesting lane/path mismatch #62851 and [Bug] Main session can brick on arcee/trinity-large-thinking: repeated connection errors, TUI spam, Telegram nonresponsive until delayed fallback #62847 for Trinity main-session/subagent mismatch and bricking logs, and notes [Bug] Main lane failover is too slow for provider transport failures, allowing TUI/Telegram degradation before fallback #62848 already covered the transport failover loop this patch must preserve. (4c669d66cb15)

Likely related people:

vincentkoc: Prior merged history includes bundled provider policy artifacts, stale provider base-url healing, and tool-support hardening that this PR extends; the current PR author also has relevant prior ownership beyond this branch. (role: recent maintainer and compat-seam owner; confidence: high; commits: 45663f287937, 791dbf4f9dde, 5320ee773167; files: src/plugins/provider-public-artifacts.ts, src/plugins/provider-runtime.ts, src/agents/model-tool-support.ts)
arthurbr11: Git history attributes the initial Arcee provider, OpenRouter support, and Trinity catalog entries to this contributor. (role: original Arcee provider contributor; confidence: high; commits: 5ac2f58c573c, 95106be59ba1, 1dc3ee616504; files: extensions/arcee/models.ts, extensions/arcee/index.ts, docs/providers/arcee.md)
steipete: Recent history around provider policy artifacts, runtime dependency boundaries, and current Arcee file blame is concentrated here. (role: adjacent provider-runtime and public-artifact maintainer; confidence: medium; commits: 65404ceabbb5, 4e168de6d90f, b7d3a263569c; files: src/plugins/provider-public-artifacts.ts, src/plugins/provider-runtime.ts, extensions/arcee/index.ts)

Remaining risk / open question:

Exact-head CI and mergeability for 4c669d66cb15 still need to pass before automerge; the provided timeline shows review queued immediately after the final branch repair.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 15bbf4f2f304.

vincentkoc · 2026-05-01T12:09:45Z

/clawsweeper automerge

clawsweeper · 2026-05-01T12:10:45Z

🦞🦞
ClawSweeper automerge is enabled.

Head: 4c669d66cb15
Label: clawsweeper:automerge
Action: exact-head review queued.
Flow: review this head, repair/rebase only if needed, then re-review the exact repaired head before merge.

Draft PRs stay fix-only until GitHub marks them ready for review. Pause with /clawsweeper stop.

Automerge progress:

2026-05-02 22:28:28 UTC repair completed [`ee3f8b0e1809`](https://github.com/openclaw/openclaw/commit/ee3f8b0e18099bdbcffe8ad689f3a57e520e0a40) (branch updated) in 32m 37s Run: https://github.com/openclaw/clawsweeper/actions/runs/25262796448 initial automerge rebase is delegated to Codex repair
2026-05-02 22:28:28 UTC review queued [`ee3f8b0e1809`](https://github.com/openclaw/openclaw/commit/ee3f8b0e18099bdbcffe8ad689f3a57e520e0a40) (after repair)
2026-05-01 12:22:12 UTC review queued [`ee3f8b0e1809`](https://github.com/openclaw/openclaw/commit/ee3f8b0e18099bdbcffe8ad689f3a57e520e0a40) (queued)
2026-05-02 22:31:34 UTC repair queued [`ee3f8b0e1809`](https://github.com/openclaw/openclaw/commit/ee3f8b0e18099bdbcffe8ad689f3a57e520e0a40) (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/25263513750
2026-05-02 22:32:36 UTC review passed [`ee3f8b0e1809`](https://github.com/openclaw/openclaw/commit/ee3f8b0e18099bdbcffe8ad689f3a57e520e0a40) (structured ClawSweeper verdict: pass (sha=ee3f8b0e18099bdbcffe8ad689f3a57e520e0...)
2026-05-02 22:46:49 UTC repair completed [`bd4ec043d9f2`](https://github.com/openclaw/openclaw/commit/bd4ec043d9f2841a94ff148a5dee4663a3c31810) (branch updated) in 12m 29s Run: https://github.com/openclaw/clawsweeper/actions/runs/25263513750 initial automerge rebase is delegated to Codex repair
2026-05-02 22:46:48 UTC review queued [`bd4ec043d9f2`](https://github.com/openclaw/openclaw/commit/bd4ec043d9f2841a94ff148a5dee4663a3c31810) (after repair)
2026-05-01 12:22:12 UTC review queued [`bd4ec043d9f2`](https://github.com/openclaw/openclaw/commit/bd4ec043d9f2841a94ff148a5dee4663a3c31810) (queued)
2026-05-02 22:49:03 UTC repair queued [`bd4ec043d9f2`](https://github.com/openclaw/openclaw/commit/bd4ec043d9f2841a94ff148a5dee4663a3c31810) (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/25263828589
2026-05-02 22:49:19 UTC review queued [`bd4ec043d9f2`](https://github.com/openclaw/openclaw/commit/bd4ec043d9f2841a94ff148a5dee4663a3c31810) (queued)
2026-05-02 22:51:53 UTC review passed [`bd4ec043d9f2`](https://github.com/openclaw/openclaw/commit/bd4ec043d9f2841a94ff148a5dee4663a3c31810) (structured ClawSweeper verdict: pass (sha=bd4ec043d9f2841a94ff148a5dee4663a3c31...)
2026-05-02 23:05:42 UTC repair completed [`4c669d66cb15`](https://github.com/openclaw/openclaw/commit/4c669d66cb15d6fd0804900d337cbf373aeee9f6) (branch updated) in 13m 55s Run: https://github.com/openclaw/clawsweeper/actions/runs/25263828589 initial automerge rebase is delegated to Codex repair
2026-05-02 23:05:42 UTC review queued [`4c669d66cb15`](https://github.com/openclaw/openclaw/commit/4c669d66cb15d6fd0804900d337cbf373aeee9f6) (after repair)
2026-05-02 23:09:12 UTC review passed [`4c669d66cb15`](https://github.com/openclaw/openclaw/commit/4c669d66cb15d6fd0804900d337cbf373aeee9f6) (structured ClawSweeper verdict: pass (sha=4c669d66cb15d6fd0804900d337cbf373aeee...)
2026-05-02 23:10:16 UTC merged [`4c669d66cb15`](https://github.com/openclaw/openclaw/commit/4c669d66cb15d6fd0804900d337cbf373aeee9f6) (merged by ClawSweeper automerge)
2026-05-02 23:10:19 UTC review queued [`4c669d66cb15`](https://github.com/openclaw/openclaw/commit/4c669d66cb15d6fd0804900d337cbf373aeee9f6) (queued)

vincentkoc · 2026-05-01T12:22:12Z

/clawsweeper automerge

…8 (1)

…8 (2)

…in (3)

Summary: - The PR marks Arcee Trinity Large Thinking tool-incompatible in catalog/config/runtime paths, updates Arcee docs and changelog, and adds provider regression tests. - Reproducibility: yes. The linked reports provide concrete main-session failure logs, and current main still exposes Trinity without `compat.supportsTools:false` while the runtime sends tools unless that flag is false. ClawSweeper fixups: - Included follow-up commit: fix(arcee): disable Trinity tools in main sessions - Included follow-up commit: fix(clawsweeper): address review for automerge-openclaw-openclaw-7338… - Included follow-up commit: fix(arcee): repair Trinity main-session compatibility Validation: - ClawSweeper review passed for head 4c669d6. - Required merge gates passed before the squash merge. Prepared head SHA: 4c669d6 Review: openclaw#73388 (comment) Co-authored-by: Vincent Koc <vincentkoc@ieee.org> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>

vincentkoc added clownfish:human-review labels Apr 28, 2026

openclaw-barnacle Bot added the extensions: arcee label Apr 28, 2026

vincentkoc added the clawsweeper Tracked by ClawSweeper automation label Apr 28, 2026

openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Apr 28, 2026

vincentkoc removed clownfish:human-review labels Apr 28, 2026

vincentkoc self-assigned this Apr 29, 2026

vincentkoc force-pushed the clownfish/ghcrawl-156908-autonomous-smoke branch from 853179f to 163b5ff Compare April 29, 2026 03:51

clawsweeper Bot mentioned this pull request Apr 30, 2026

[Bug] arcee/trinity-large-thinking works as subagent but fails as main session, suggesting lane/path mismatch #62851

Closed

clawsweeper Bot added the clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge label May 1, 2026

clawsweeper Bot force-pushed the clownfish/ghcrawl-156908-autonomous-smoke branch 2 times, most recently from 741693b to 27c456b Compare May 2, 2026 20:16

openclaw-barnacle Bot added docs Improvements or additions to documentation size: S and removed size: XS labels May 2, 2026

clawsweeper Bot force-pushed the clownfish/ghcrawl-156908-autonomous-smoke branch 3 times, most recently from 261bebe to 953e98d Compare May 2, 2026 21:51

openclaw-barnacle Bot added size: M and removed size: S labels May 2, 2026

clawsweeper Bot force-pushed the clownfish/ghcrawl-156908-autonomous-smoke branch 2 times, most recently from ee3f8b0 to bd4ec04 Compare May 2, 2026 22:46

fix(arcee): disable Trinity tools

e9a5b1b

clawsweeper Bot added 9 commits May 2, 2026 23:02

fix(arcee): disable Trinity tools in main sessions

386bc59

fix(clawsweeper): address review for automerge-openclaw-openclaw-7338…

69d0e66

…8 (1)

fix(clawsweeper): address review for automerge-openclaw-openclaw-7338…

16cd6eb

…8 (2)

fix(arcee): repair Trinity main-session compatibility

75925ec

fix(arcee): repair Trinity main-session compatibility

be1d514

fix(clawsweeper): address review for automerge-openclaw-openclaw-7338…

84191c0

…8 (2)

fix(clawsweeper): reconcile automerge-openclaw-openclaw-73388 with ma…

77c930f

…in (3)

Fix Trinity main-session compatibility mismatch

7ed372c

Fix Trinity main-session compatibility mismatch

4c669d6

clawsweeper Bot force-pushed the clownfish/ghcrawl-156908-autonomous-smoke branch from bd4ec04 to 4c669d6 Compare May 2, 2026 23:05

clawsweeper Bot merged commit dd43caa into main May 2, 2026
79 of 80 checks passed

clawsweeper Bot deleted the clownfish/ghcrawl-156908-autonomous-smoke branch May 2, 2026 23:10

clawsweeper Bot mentioned this pull request May 2, 2026

[Bug]: subagents list still empty after spawn on v2026.4.29 #75593

Open

github-actions Bot mentioned this pull request May 3, 2026

📡 Upstream Digest — 2026-05-03 02:05 UTC curtismercier/openclaw-mods#751

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Trinity main-session compatibility mismatch#73388

Fix Trinity main-session compatibility mismatch#73388
clawsweeper[bot] merged 10 commits intomainfrom
clownfish/ghcrawl-156908-autonomous-smoke

vincentkoc commented Apr 28, 2026

Uh oh!

greptile-apps Bot commented Apr 28, 2026

Uh oh!

clawsweeper Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

vincentkoc commented May 1, 2026

Uh oh!

clawsweeper Bot commented May 1, 2026 •

edited

Loading

Uh oh!

vincentkoc commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vincentkoc commented Apr 28, 2026

Summary

Credit

Validation

Uh oh!

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

clawsweeper Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vincentkoc commented May 1, 2026

Uh oh!

clawsweeper Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vincentkoc commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented Apr 28, 2026 •

edited

Loading

clawsweeper Bot commented May 1, 2026 •

edited

Loading