fix(ui): clear webchat pending state only for completed active run#73368
fix(ui): clear webchat pending state only for completed active run#73368vincentkoc merged 1 commit intomainfrom
Conversation
Greptile SummaryThis PR makes WebChat pending-run reconciliation ownership-aware by treating payloads without a Confidence Score: 4/5Safe to merge; the fix is narrowly scoped and well-tested, with only P2 concerns remaining. The logic is coherent and the new tests cover the key scenarios. The only open questions are P2: the undocumented assumption that owned-run terminal events always carry a runId (if violated, aborted/error would stick the indicator), and a benign semantic shift in isEventForDifferentActiveRun for undefined payloads. ui/src/ui/controllers/chat.ts — the aborted/error case in the new foreign-run branch warrants a clarifying comment about the runId-always-present assumption.
|
fdd46f5 to
b89d7ed
Compare
b89d7ed to
1c4af67
Compare
Summary
Credit
This replacement carries forward the stuck-typing diagnosis from haoyu-haoyu in source PR #57887. That PR could not be safely landed because its broad cross-run final clearing was uneditable and Codex review flagged P1 premature-unlock regressions.
Validation
Changelog
ProjectClownfish replacement details: