fix(opencode): expose Claude thinking levels by haishmg · Pull Request #72778 · openclaw/openclaw

haishmg · 2026-04-27T11:15:16Z

Summary

add an OpenCode thinking profile for proxied Claude Opus 4.7 and Opus/Sonnet 4.6 models
keep the default thinking ladder for other OpenCode models
add regression coverage for /think xhigh, adaptive, and max validation

Fixes #72729.

Tests

CI=true OPENCLAW_LOCAL_CHECK=0 npm exec pnpm@10.33.0 -- test extensions/opencode/index.test.ts
CI=true OPENCLAW_LOCAL_CHECK=0 npm exec pnpm@10.33.0 -- lint:extensions
CI=true OPENCLAW_LOCAL_CHECK=0 npm exec pnpm@10.33.0 -- tsgo:prod
git diff --check

haishmg · 2026-04-27T11:15:27Z

@codex review

greptile-apps · 2026-04-27T11:17:08Z

Greptile Summary

This PR exposes Anthropic-specific thinking levels (xhigh, adaptive, max) for proxied Claude Opus 4.7, Opus 4.6, and Sonnet 4.6 models on the OpenCode provider, fixing /think command validation failures for those models. The implementation correctly normalises model IDs to lowercase and dispatches to the right thinking-level set.

Confidence Score: 4/5

Safe to merge; only a minor test symmetry gap was found.

All findings are P2 (style/test coverage). The production code logic is clean and consistent with existing patterns.

extensions/opencode/index.test.ts — missing negative assertion for opus-4.6 thinking levels

Prompt To Fix All With AI

This is a comment left during a code review.
Path: extensions/opencode/index.test.ts
Line: 65-73

Comment:
**Missing negative assertion for `claude-opus-4.6`**

The test verifies that `claude-sonnet-4-6` does not contain `xhigh` or `max` levels (line 82–84), but the same assertion is absent for `claude-opus-4.6`. Both models are resolved through the same `ANTHROPIC_ADAPTIVE_MODEL_PREFIXES` branch, so a regression that accidentally added `xhigh`/`max` to that branch would be caught only for the sonnet model. Adding a parallel `sonnet46Profile?.levels.some(...)` check for the opus profile would close the symmetry gap.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(opencode): expose claude thinking le..." | Re-trigger Greptile}

chatgpt-codex-connector · 2026-04-27T11:20:42Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

haishmg · 2026-04-27T11:21:03Z

@codex review latest head, please

haishmg · 2026-04-27T11:22:57Z

Addressed the Greptile test symmetry note by adding the Opus 4.6 negative assertion, rebased on latest main, and pushed the latest head. @codex review

chatgpt-codex-connector · 2026-04-27T11:26:13Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

haishmg · 2026-04-27T11:34:42Z

Fixed the extension test boundary failure from the new Qwen test import and pushed the rebased head. Local guard and focused provider tests pass. @codex review

chatgpt-codex-connector · 2026-04-27T11:38:44Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

haishmg · 2026-04-27T12:41:46Z

Rebased on latest main and added the generated config schema/docs hash sync required by the OpenCode thinking profile schema change. Focused local checks pass: config:schema:check, config:docs:check, schema.base.generated.test.ts, and extensions/opencode/index.test.ts. @codex review

chatgpt-codex-connector · 2026-04-27T12:47:20Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

haishmg · 2026-04-27T13:06:30Z

Latest head a9dee06 is green in CI now: 57 passing checks, no pending/failing checks. The fast/support failure was resolved by keeping the speech provider registry mock test out of unit-fast; local fast/support shard also passes. @codex review

chatgpt-codex-connector · 2026-04-27T13:11:13Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

* fix(opencode): expose claude thinking levels * test(opencode): cover adaptive claude thinking bounds * docs(changelog): credit opencode thinking contributor --------- Co-authored-by: haishmg <4529977+haishmg@users.noreply.github.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

openclaw-barnacle Bot added the size: S label Apr 27, 2026

greptile-apps Bot reviewed Apr 27, 2026

View reviewed changes

Comment thread extensions/opencode/index.test.ts Outdated

haishmg force-pushed the codex/opencode-anthropic-thinking branch from 2e297b4 to 57ae744 Compare April 27, 2026 11:20

haishmg force-pushed the codex/opencode-anthropic-thinking branch from 57ae744 to 795a295 Compare April 27, 2026 11:22

haishmg force-pushed the codex/opencode-anthropic-thinking branch 2 times, most recently from 137c5e5 to b0cf46e Compare April 27, 2026 11:34

steipete force-pushed the codex/opencode-anthropic-thinking branch from 09a5867 to 69583d2 Compare April 27, 2026 11:54

haishmg mentioned this pull request Apr 27, 2026

fix(gateway): include connecting client in presence snapshot #72793

Closed

25 tasks

steipete force-pushed the codex/opencode-anthropic-thinking branch 2 times, most recently from d7b39e5 to 4a22422 Compare April 27, 2026 12:13

haishmg force-pushed the codex/opencode-anthropic-thinking branch from 4a22422 to 84e1dd9 Compare April 27, 2026 12:18

steipete force-pushed the codex/opencode-anthropic-thinking branch from 84e1dd9 to eb365a2 Compare April 27, 2026 12:18

haishmg mentioned this pull request Apr 27, 2026

test(agents): align unclassified failure expectation #72794

Closed

25 tasks

steipete force-pushed the codex/opencode-anthropic-thinking branch from eb365a2 to 6b0fb5c Compare April 27, 2026 12:28

This was referenced Apr 27, 2026

test(doctor): isolate invalid plugin repair sequencing #72799

Closed

chore(protocol): sync swift node pair remove model #72800

Closed

steipete force-pushed the codex/opencode-anthropic-thinking branch from 6b0fb5c to bd7bd2b Compare April 27, 2026 12:32

haishmg mentioned this pull request Apr 27, 2026

chore(config): sync generated base schema #72803

Closed

8 tasks

haishmg force-pushed the codex/opencode-anthropic-thinking branch from bd7bd2b to 022a2b9 Compare April 27, 2026 12:41

openclaw-barnacle Bot added the docs Improvements or additions to documentation label Apr 27, 2026

steipete force-pushed the codex/opencode-anthropic-thinking branch from 022a2b9 to 37f7933 Compare April 27, 2026 12:45

openclaw-barnacle Bot removed the docs Improvements or additions to documentation label Apr 27, 2026

haishmg and others added 3 commits April 27, 2026 13:58

fix(opencode): expose claude thinking levels

94fef35

test(opencode): cover adaptive claude thinking bounds

544ce9d

docs(changelog): credit opencode thinking contributor

a9dee06

steipete force-pushed the codex/opencode-anthropic-thinking branch from 37f7933 to a9dee06 Compare April 27, 2026 12:59

steipete merged commit f75d882 into openclaw:main Apr 27, 2026
65 checks passed

github-actions Bot mentioned this pull request Apr 27, 2026

📡 Upstream Digest — 2026-04-27 13:21 UTC curtismercier/openclaw-mods#699

Open

MkDev11 mentioned this pull request May 3, 2026

fix(opencode): expose Claude thinking policy #76760

Merged

25 tasks

Uh oh!

Conversation

haishmg commented Apr 27, 2026

Summary

Tests

Uh oh!

haishmg commented Apr 27, 2026

Uh oh!

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 27, 2026

Uh oh!

haishmg commented Apr 27, 2026

Uh oh!

haishmg commented Apr 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 27, 2026

Uh oh!

haishmg commented Apr 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 27, 2026

Uh oh!

haishmg commented Apr 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 27, 2026

Uh oh!

Uh oh!

haishmg commented Apr 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants