Greptile Summary

This PR addresses Windows console flicker and fatal Bonjour/mDNS crash scenarios by adding windowsHide: true to child-process spawns, patching @homebridge/ciao to replace process.exit(1) with console.warn(), and extending advertiser.ts with graceful CANCELLED-error suppression and EADDRINUSE-triggered self-disable logic.

The implementation is well-structured: isCancellationError and isEaddrInUse helpers are correct (both normalise case before searching), disableAdvertiser is correctly extracted and reused for both the EADDRINUSE path and the MAX_CONSECUTIVE_RESTARTS path, and the stop() wrapper in a try/catch is a sound improvement.

Confidence Score: 5/5

Safe to merge — no P0 or P1 issues found; changes are targeted, internally consistent, and well-guarded.

All new code paths are correct: case-normalisation in isEaddrInUse and isCancellationError is consistent, disableAdvertiser idempotency is enforced by the disabled flag, void usage in .catch() and sync catch blocks is intentional, and the @homebridge/ciao patch safely replaces fatal process.exit(1) calls. No logic inversions, data-loss paths, or security concerns were identified.

No files require special attention.

_{Reviews (4): Last reviewed commit: "Merge branch 'main' into fix/windows-gat..." | Re-trigger Greptile}

@greptile-review

Codex automated review: keeping this open.

Keep PR #72332 open. Current main still does not contain the PR’s remaining Windows flicker and Bonjour dependency-hardening work: the TUI relaunch spawn lacks windowsHide, the Bonjour plugin still resolves unpatched @homebridge/ciao@1.3.6, and current advertiser handling only partially covers ciao cancellation/assertion failures without the PR’s EADDRINUSE self-disable path. The PR is recent, contributor-authored, has no protected labels, and is tied to active/recent user bug reports, so it should get maintainer review rather than cleanup closure.

Best possible solution:

Keep the PR open for maintainer review/refinement. Preserve the useful fixes for the TUI windowsHide path, Bonjour EADDRINUSE/conflict handling, and ciao hard-exit/Windows exec behavior; add focused regression tests or strong manual verification for those surfaces; remove unrelated churn; and get explicit maintainer approval for the @homebridge/ciao patch or replace it with an OpenClaw-owned wrapper/upstreamed dependency fix.

What I checked:

• No auto-protection blocker: The provided PR context shows author association CONTRIBUTOR and labels size: M and plugin: bonjour; none of the protected labels (security, beta-blocker, release-blocker, maintainer) are present.
• TUI relaunch still lacks Windows hiding: Current main spawns the relaunched TUI with stdio and env only; there is no windowsHide: true in this path, which is one of the explicit PR fixes. (src/tui/tui-launch.ts:101, ff6044f4411d)
• No TUI regression guard for windowsHide: The TUI launch tests assert stdio: "inherit" via expect.objectContaining, but they do not assert windowsHide, so current main has no test proving the flicker fix. (src/tui/tui-launch.test.ts:70, ff6044f4411d)
• Bonjour still depends on unpatched ciao: The Bonjour plugin depends on @homebridge/ciao with specifier ^1.3.6, while root patchedDependencies only contains the Baileys patch. The lockfile resolves ciao to plain 1.3.6 without a patch hash. (extensions/bonjour/package.json:7, ff6044f4411d)
• Upstream ciao still has implicated hard exits and visible exec: Read-only npm tarball inspection of @homebridge/ciao@1.3.6 shows child_process.exec("arp -a | findstr ...") without windowsHide and process.exit(1) in CiaoService.js and Responder.js; current main has no local patch to replace those behaviors. (88c230ac43b5)
• Current Bonjour mitigation is partial: Main classifies ciao cancellation/assertion process errors and has tests for the unhandled-rejection handler, but startAdvertising and watchdog re-advertise still log rejected advertise calls generically; no EADDRINUSE/address-in-use self-disable path from this PR exists in current main. (extensions/bonjour/src/advertiser.ts:326, ff6044f4411d)

Remaining risk / open question:

• The PR adds a dependency patch for @homebridge/ciao; repo policy says dependency patches/overrides need explicit maintainer approval before landing.
• The PR still needs focused maintainer review for test coverage around windowsHide, EADDRINUSE self-disable behavior, and the patched ciao hard-exit paths.
• The submitted diff includes at least one unrelated formatting-only test change, so it should be cleaned up or split before merge.

Codex Review notes: model gpt-5.5, reasoning high; reviewed against ff6044f4411d.

Thanks @PratikRai0101. I rechecked this against current main, and the PR is now superseded by maintainer-side fixes that already landed.

What is already fixed on main:

• [Bug]: Gateway OpenCLAW spawns flashing command prompt windows in background on Windows #70238 is closed as fixed by the scoped Windows ciao ARP probe wrapper in extensions/bonjour/src/advertiser.ts; current main wraps only arp -a | findstr /C:"---" while the Bonjour advertiser is active and injects windowsHide: true, then restores child_process.exec on cleanup.
• [Bug]: Gateway crashes after update to 2026.4.24 (CIAO PROBING CANCELLED) #72339 and Bonjour/ciao mDNS causes repeated gateway crashes on headless Linux (CIAO PROBING CANCELLED) #72344 are closed as fixed by the scoped ciao process-error handling path: extensions/bonjour/src/ciao.ts classifies CIAO PROBING CANCELLED / CIAO ANNOUNCEMENT CANCELLED and ciao assertion signatures, and extensions/bonjour/src/advertiser.ts registers scoped unhandled rejection / uncaught exception handlers so the gateway can recover instead of exiting.
• Current extensions/bonjour/src/advertiser.test.ts covers the Windows exec-hide behavior and the ciao cancellation/assertion suppression/recovery paths.

I’m closing this PR rather than merging it because the linked crash/window-flicker issues are already fixed on main, while this branch still adds a dependency patch and package metadata churn that we should not carry now that the repo-owned scoped fixes exist.

The newer DNS-label crash in #37705 is a different Bonjour issue and is being tracked separately in #72809.

Closing as superseded by current main; details in the maintainer comment above.