Agents: prevent silent message-tool drops#717
Merged
steipete merged 3 commits intoJan 11, 2026
Conversation
956aeaa to
99fcc82
Compare
Contributor
|
Landed via temp rebase onto main.\n\n- Gate: skipped (per request)\n- Land commit: 99fcc82\n- Merge commit: 225b44a\n\nThanks @theglove44! |
steipete
added a commit
that referenced
this pull request
Jan 11, 2026
2 tasks
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
…-requires-to Agents: prevent silent message-tool drops
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
…-requires-to Agents: prevent silent message-tool drops
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Discord replies can be silently dropped when the message tool is called without
to. The tool fails, but the agent suppresses the fallback reply.Investigation
Logs show
message failed: to requiredfollowed bySkipping block reply - already sent via messaging tool, so the send failure is treated as success.Root Cause
The message tool schema + system prompt didn’t require
toforaction=send, and tool errors returned{status:"error"}without flippingisError, so dedupe logic treated failures as successful sends.Solution
Treat tool results with
{status:"error"|"timeout"}as failures to keep fallback replies, and requireto+messageforaction=sendin the tool schema; clarify prompt guidance.Tests
Not run (not requested).