Skip to content

chore: remove repo PR assets#71510

Merged
BunsDev merged 3 commits intomainfrom
meow/remove-control-ui-chat-detail-assets
Apr 25, 2026
Merged

chore: remove repo PR assets#71510
BunsDev merged 3 commits intomainfrom
meow/remove-control-ui-chat-detail-assets

Conversation

@BunsDev
Copy link
Copy Markdown
Member

@BunsDev BunsDev commented Apr 25, 2026

Summary

  • Problem: .github/pr-assets contained PR-only screenshots checked into the repo.
  • Why it matters: PR execution artifacts should live on the PR/comment or in an artifact store, not in source control.
  • What changed: removed the full .github/pr-assets tree and added maintainer notes that repo PR assets are not valid PR execution behavior.
  • What did NOT change (scope boundary): no product code, generated outputs, workflows, or runtime docs changed.

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor required for the fix
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

  • Closes #
  • Related #
  • This PR fixes a bug or regression

Root Cause (if applicable)

N/A

Regression Test Plan (if applicable)

N/A

User-visible / Behavior Changes

None.

Diagram (if applicable)

N/A

Security Impact (required)

  • New permissions/capabilities? (No)
  • Secrets/tokens handling changed? (No)
  • New/changed network calls? (No)
  • Command/tool execution surface changed? (No)
  • Data access scope changed? (No)
  • If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

  • OS: macOS
  • Runtime/container: Node 22 via repo scripts
  • Model/provider: N/A
  • Integration/channel (if any): N/A
  • Relevant config (redacted): N/A

Steps

  1. Delete .github/pr-assets from the repo.
  2. Add PR execution guidance to AGENTS.md and .agents/skills/openclaw-pr-maintainer/SKILL.md.
  3. Run pnpm check:changed.

Expected

  • The repo no longer tracks PR-only assets.
  • Future PR execution guidance says not to store PR assets in the repo.
  • Changed-file gate passes.

Actual

  • Removed all tracked files under .github/pr-assets.
  • Added notes directing PR artifacts/screenshots to PR comments or external artifact storage instead of repo paths.
  • pnpm check:changed passed after installing dependencies in the fresh worktree.

Evidence

Attach at least one:

  • Failing test/log before + passing after
  • Trace/log snippets
  • Screenshot/recording
  • Perf numbers (if relevant)

N/A for repo hygiene cleanup; validation command above passed.

Human Verification (required)

  • Verified scenarios: confirmed .github/pr-assets is absent and git diff origin/main...HEAD contains only the asset deletions plus the two maintainer guidance lines.
  • Edge cases checked: preserved unrelated dirty work in the original checkout by using a separate worktree.
  • What you did not verify: no runtime UI behavior; no product code changed.

Review Conversations

  • I replied to or resolved every bot review conversation I addressed in this PR.
  • I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

  • Backward compatible? (Yes)
  • Config/env changes? (No)
  • Migration needed? (No)
  • If yes, exact upgrade steps: N/A

Risks and Mitigations

None.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 25, 2026

No reviewable files after applying ignore patterns.

@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Apr 25, 2026
@BunsDev BunsDev force-pushed the meow/remove-control-ui-chat-detail-assets branch from 360e980 to 0cd32be Compare April 25, 2026 09:36
@BunsDev BunsDev changed the title chore: remove obsolete control UI chat detail asset chore: remove repo PR assets Apr 25, 2026
@BunsDev BunsDev merged commit 0bef73d into main Apr 25, 2026
7 checks passed
@BunsDev BunsDev deleted the meow/remove-control-ui-chat-detail-assets branch April 25, 2026 09:40
Angfr95 pushed a commit to Angfr95/openclaw that referenced this pull request Apr 25, 2026
ayesha-aziz123 pushed a commit to ayesha-aziz123/openclaw that referenced this pull request Apr 26, 2026
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant