Skip to content

fix(skills): honor legacy clawdbot metadata#71346

Merged
steipete merged 2 commits intoopenclaw:mainfrom
chen-zhang-cs-code:codex/issue-71323-legacy-skill-metadata
Apr 25, 2026
Merged

fix(skills): honor legacy clawdbot metadata#71346
steipete merged 2 commits intoopenclaw:mainfrom
chen-zhang-cs-code:codex/issue-71323-legacy-skill-metadata

Conversation

@chen-zhang-cs-code
Copy link
Copy Markdown
Contributor

Summary

  • accept legacy metadata.clawdbot manifest blocks alongside metadata.openclaw
  • restore skill requirement checks and install hints for legacy SKILL.md metadata
  • add parser and skill-status regression coverage

Closes #71323.

Verification

  • pnpm exec oxfmt --check --threads=1 src/compat/legacy-names.ts src/shared/frontmatter.test.ts src/agents/skills.buildworkspaceskillstatus.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/skills.buildworkspaceskillstatus.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.unit-fast.config.ts src/shared/frontmatter.test.ts
  • pnpm check:changed
  • git diff --check

@openclaw-barnacle openclaw-barnacle Bot added agents Agent runtime and tooling size: XS labels Apr 25, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 25, 2026

Greptile Summary

This PR adds "clawdbot" as a legacy project name so that SKILL.md files using the old metadata.clawdbot block are recognised alongside the current metadata.openclaw block. The single-line change in legacy-names.ts propagates automatically to LEGACY_MANIFEST_KEYS, which is iterated by resolveOpenClawManifestBlock; both unit and integration-level regression tests are included.

Confidence Score: 5/5

Safe to merge — the change is minimal, well-scoped, and covered by new regression tests.

The only production change is adding one string to a constants array; LEGACY_PROJECT_NAMES is used only to derive LEGACY_MANIFEST_KEYS, which is already consumed correctly by resolveOpenClawManifestBlock. The frontmatter parser's shouldPreferInlineLineValue logic ensures the raw JSON5 metadata string is preserved when YAML would otherwise parse it as a flow mapping, so the end-to-end path is correct. No security implications, no interface changes.

No files require special attention.

Reviews (1): Last reviewed commit: "fix(skills): honor legacy clawdbot metad..." | Re-trigger Greptile

@steipete steipete force-pushed the codex/issue-71323-legacy-skill-metadata branch from a48e931 to 9f4cbed Compare April 25, 2026 02:30
@steipete steipete merged commit 996e922 into openclaw:main Apr 25, 2026
10 checks passed
@steipete
Copy link
Copy Markdown
Contributor

Landed via rebase onto main.

  • Local gates: pnpm test src/shared/frontmatter.test.ts src/agents/skills.buildworkspaceskillstatus.test.ts; pnpm test src/agents/skills.buildworkspaceskillstatus.test.ts src/compat/legacy-names.ts src/compat/legacy-names.test.ts src/shared/frontmatter.test.ts -- --reporter=verbose; pnpm check:changed; pnpm docs:check-mdx
  • Source head: 9f4cbed
  • Landed commits: bb5f523 and 996e922

Thanks @chen-zhang-cs-code!

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation size: S and removed size: XS labels Apr 25, 2026
Angfr95 pushed a commit to Angfr95/openclaw that referenced this pull request Apr 25, 2026
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling docs Improvements or additions to documentation size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skill validator ignores metadata.clawdbot.requires.bins → 24+ skills falsely reported as eligible

2 participants