feat(plugins): warn on ignored setup runtime by vincentkoc · Pull Request #71253 · openclaw/openclaw

vincentkoc · 2026-04-24T20:36:30Z

Summary

Problem: setup.requiresRuntime: false already prevents setup runtime loading, but a plugin can still accidentally ship setup-api or openclaw.setupEntry and get no signal that it is ignored.
Why it matters: descriptor-only setup should be an explicit contract, not a silent footgun during the migration away from setup runtime paths.
What changed: add an additive setup registry diagnostic when descriptor-only setup metadata still has an ignored setup runtime entry, plus docs, changelog, and coverage.
What did NOT change (scope boundary): legacy plugins without requiresRuntime: false still use the setup-api fallback path.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Related feat(plugins): surface manifest provider setup choices #71240
This PR fixes a bug or regression

Root Cause (if applicable)

N/A

Regression Test Plan (if applicable)

N/A

User-visible / Behavior Changes

Plugin authors now get an additive setup diagnostic when setup.requiresRuntime: false ignores a setup runtime entry.

Diagram (if applicable)

Before:
manifest requiresRuntime=false + setup-api -> setup-api ignored silently

After:
manifest requiresRuntime=false + setup-api -> setup-api ignored + diagnostic emitted

Security Impact (required)

New permissions/capabilities? (Yes/No): No
Secrets/tokens handling changed? (Yes/No): No
New/changed network calls? (Yes/No): No
Command/tool execution surface changed? (Yes/No): No
Data access scope changed? (Yes/No): No
If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

OS: macOS
Runtime/container: local Node/pnpm worktree
Model/provider: N/A
Integration/channel (if any): plugins setup registry
Relevant config (redacted): N/A

Steps

Define a plugin manifest with setup.requiresRuntime: false.
Add a setup runtime entry via setup-api or openclaw.setupEntry.
Resolve the setup registry.

Expected

Setup runtime remains ignored.
Registry includes a diagnostic explaining the ignored runtime entry.

Actual

Matches expected.

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

Verified scenarios: pnpm test src/plugins/setup-registry.test.ts; pnpm check:changed; pnpm build
Edge cases checked: descriptor-only setup still does not load setup-api; legacy omitted requiresRuntime behavior remains unchanged by existing setup registry coverage.
What you did not verify: external third-party plugin package manually.

Review Conversations

I replied to or resolved every bot review conversation I addressed in this PR.
I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

Backward compatible? (Yes/No): Yes
Config/env changes? (Yes/No): No
Migration needed? (Yes/No): No
If yes, exact upgrade steps: N/A

Risks and Mitigations

Risk: diagnostic noise for intentionally descriptor-only plugins that forgot to remove old setup entrypoints.
- Mitigation: diagnostic is additive and behavior remains unchanged; docs explain either remove the runtime entry or set requiresRuntime: true.

greptile-apps · 2026-04-24T20:41:48Z

Greptile Summary

This PR adds an additive diagnostic (setup-descriptor-runtime-disabled) to the setup registry when a plugin declares setup.requiresRuntime: false but still ships a detectable setup runtime entry (setup-api file or openclaw.setupEntry). The implementation correctly short-circuits the main registry loop before any file-loading (createJiti) occurs, leaves resolvePluginSetupProvider/resolvePluginSetupCliBackend behavior unchanged, and is well-covered by the updated test.

Confidence Score: 5/5

Safe to merge — additive diagnostic only, no behavioral changes to existing paths.

All findings are P2 (style/defensive-coding observations). The core logic is correct: the diagnostic is conditionally emitted only when a setup runtime source is actually detectable, the early continue prevents unnecessary work, and the runtime cutoff semantics are preserved end-to-end.

No files require special attention.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: src/plugins/setup-registry.ts
Line: 411-413

Comment:
**Redundant guard in `pushDescriptorRuntimeDisabledDiagnostic`**

The `if (params.record.setup?.requiresRuntime !== false)` early-return is unreachable at runtime — the function is only called from within the `if (record.setup?.requiresRuntime === false)` branch in `resolvePluginSetupRegistry`. The guard is defensive but could mislead future readers into thinking the function has broader call sites.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "Merge branch 'main' into feat-setup-runt..." | Re-trigger Greptile}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4789e9c46b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

* feat(plugins): warn on ignored setup runtime * fix(plugins): avoid fallback setup runtime diagnostics * refactor(plugins): clarify setup runtime lookup

openclaw-barnacle Bot added the docs Improvements or additions to documentation label Apr 24, 2026

vincentkoc self-assigned this Apr 24, 2026

openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Apr 24, 2026

vincentkoc marked this pull request as ready for review April 24, 2026 20:39

greptile-apps Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread src/plugins/setup-registry.ts Outdated

chatgpt-codex-connector Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread src/plugins/setup-registry.ts Outdated

vincentkoc added 2 commits April 24, 2026 14:07

feat(plugins): warn on ignored setup runtime

671220c

fix(plugins): avoid fallback setup runtime diagnostics

fcb1efd

vincentkoc force-pushed the feat-setup-runtime-disabled-diagnostic branch from 4789e9c to fcb1efd Compare April 24, 2026 21:10

openclaw-barnacle Bot added size: S and removed size: XS labels Apr 24, 2026

refactor(plugins): clarify setup runtime lookup

ba7f490

vincentkoc merged commit 5b8bd63 into main Apr 24, 2026
65 checks passed

vincentkoc deleted the feat-setup-runtime-disabled-diagnostic branch April 24, 2026 21:23

vincentkoc mentioned this pull request Apr 24, 2026

feat(channels): use manifest configs for read-only discovery #71275

Merged

21 tasks

github-actions Bot mentioned this pull request Apr 24, 2026

📡 Upstream Digest — 2026-04-24 22:33 UTC curtismercier/openclaw-mods#672

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(plugins): warn on ignored setup runtime#71253

feat(plugins): warn on ignored setup runtime#71253
vincentkoc merged 3 commits into
mainfrom
feat-setup-runtime-disabled-diagnostic

vincentkoc commented Apr 24, 2026

Uh oh!

greptile-apps Bot commented Apr 24, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vincentkoc commented Apr 24, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Root Cause (if applicable)

Regression Test Plan (if applicable)

User-visible / Behavior Changes

Diagram (if applicable)

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Review Conversations

Compatibility / Migration

Risks and Mitigations

Uh oh!

greptile-apps Bot commented Apr 24, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant