Skip to content

fix(plugins): warn on invalid install default choice#71011

Merged
vincentkoc merged 2 commits into
mainfrom
feat/plugin-install-default-choice
Apr 24, 2026
Merged

fix(plugins): warn on invalid install default choice#71011
vincentkoc merged 2 commits into
mainfrom
feat/plugin-install-default-choice

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Apr 24, 2026

Copy link
Copy Markdown
Member

Summary

  • add install-source warnings for invalid openclaw.install.defaultChoice values
  • warn when defaultChoice points at an unavailable source, including invalid npm specs
  • document the new default-choice diagnostics and add changelog coverage

Why

Phase 1 source-plane diagnostics should explain malformed install metadata without breaking existing plugins. These warnings keep catalog facts explicit while preserving compatibility: invalid or impossible defaults warn in installSource.warnings; install behavior does not reject them.

Validation

  • pnpm test src/plugins/install-source-info.test.ts src/plugins/provider-install-catalog.test.ts src/channels/plugins/contracts/channel-catalog.contract.test.ts
  • pnpm format:check src/plugins/install-source-info.ts src/plugins/install-source-info.test.ts docs/plugins/architecture-internals.md docs/plugins/manifest.md CHANGELOG.md

Notes

  • pnpm check:changed currently fails in src/plugin-sdk/provider-tools.ts with TS2322 because a compat config is missing supportsLongCacheRetention; this branch does not touch that file.
  • AI-assisted: yes.

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation size: S maintainer Maintainer-authored PR labels Apr 24, 2026
@vincentkoc vincentkoc marked this pull request as ready for review April 24, 2026 15:46
@greptile-apps

greptile-apps Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds two new diagnostic warnings — invalid-default-choice and default-choice-missing-source — to describePluginInstallSource, covering cases where openclaw.install.defaultChoice is an unrecognized value or points at a source that is absent or invalid. The changes are non-breaking (warnings only), well-tested with three targeted new cases, and the documentation updates accurately reflect the new diagnostic category.

Confidence Score: 5/5

Safe to merge — changes are additive warnings only with no behavioral regressions.

All new logic is guarded by mutually exclusive conditions (invalid-default-choice and default-choice-missing-source cannot both fire), tests cover all three new warning paths, and the two existing warning types are unaffected. No P0 or P1 findings.

No files require special attention.

Reviews (1): Last reviewed commit: "Merge branch 'main' into feat/plugin-ins..." | Re-trigger Greptile

@vincentkoc vincentkoc merged commit 5dfc1b9 into main Apr 24, 2026
61 of 65 checks passed
@vincentkoc vincentkoc deleted the feat/plugin-install-default-choice branch April 24, 2026 15:56
@github-actions github-actions Bot mentioned this pull request Apr 24, 2026
Open
Angfr95 pushed a commit to Angfr95/openclaw that referenced this pull request Apr 25, 2026
@vincentkoc
fix(plugins): warn on invalid install default choice (openclaw#71011)
40421c7
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
@vincentkoc
fix(plugins): warn on invalid install default choice (openclaw#71011)
7c1d2c1
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
@vincentkoc
fix(plugins): warn on invalid install default choice (openclaw#71011)
f174322
globalcaos pushed a commit to globalcaos/tinkerclaw that referenced this pull request May 13, 2026
@vincentkoc
fix(plugins): warn on invalid install default choice (openclaw#71011)
99de5cb
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
@vincentkoc
fix(plugins): warn on invalid install default choice (openclaw#71011)
17995ef
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
@vincentkoc
fix(plugins): warn on invalid install default choice (openclaw#71011)
65c7361
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
@vincentkoc
fix(plugins): warn on invalid install default choice (openclaw#71011)
b277631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Improvements or additions to documentation maintainer Maintainer-authored PR size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vincentkoc