fix(tui): arm streaming watchdog on every delta, not only visible ones#69338
Merged
amknight merged 1 commit intoopenclaw:mainfrom Apr 21, 2026
Merged
Conversation
When ingestDelta returns null (first empty/commentary delta or unchanged
content), the handler returned early, skipping setActivityStatus and
armStreamingWatchdog. If all subsequent deltas were also null (e.g.
due to phase filtering), the watchdog was never armed and the status bar
stayed stale as "idle" while a run was live.
Move setActivityStatus("streaming") and armStreamingWatchdog before
the null-displayText guard so they fire on every received delta event.
Fixes openclaw#34513, openclaw#40824
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR fixes a bug where the streaming watchdog and activity status were never set when all received deltas produced no visible output (e.g. commentary-only or tool-call deltas). The fix moves Confidence Score: 5/5Safe to merge — minimal, targeted fix with no regressions introduced. The change is a two-line reorder within a single conditional block. The watchdog guard (activeChatRunId === evt.runId) is preserved, render pressure is unchanged, and finalized-run filtering upstream prevents stale events from reaching this path. No files require special attention. Reviews (1): Last reviewed commit: "fix(tui): arm streaming watchdog on ever..." | Re-trigger Greptile |
Member
|
LGTM 👍 merging |
zhongmairen
pushed a commit
to agencyos-cn/openclaw-bad
that referenced
this pull request
Apr 21, 2026
* 'main' of https://github.com/openclaw/openclaw: fix(agents): enforce subagent envelope inheritance on ACP child sessions [AI-assisted] (openclaw#69383) fix(tui): arm streaming watchdog on every delta, not only visible ones (openclaw#69338) fix(codex): exclude codex-app-server synthetic apiKey from secrets audit (openclaw#69581)
steipete
pushed a commit
that referenced
this pull request
Apr 21, 2026
#69338) When ingestDelta returns null (first empty/commentary delta or unchanged content), the handler returned early, skipping setActivityStatus and armStreamingWatchdog. If all subsequent deltas were also null (e.g. due to phase filtering), the watchdog was never armed and the status bar stayed stale as "idle" while a run was live. Move setActivityStatus("streaming") and armStreamingWatchdog before the null-displayText guard so they fire on every received delta event. Fixes #34513, #40824 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> (cherry picked from commit 89b6d02)
gdibble
pushed a commit
to gdibble/openclaw
that referenced
this pull request
Apr 21, 2026
openclaw#69338) When ingestDelta returns null (first empty/commentary delta or unchanged content), the handler returned early, skipping setActivityStatus and armStreamingWatchdog. If all subsequent deltas were also null (e.g. due to phase filtering), the watchdog was never armed and the status bar stayed stale as "idle" while a run was live. Move setActivityStatus("streaming") and armStreamingWatchdog before the null-displayText guard so they fire on every received delta event. Fixes openclaw#34513, openclaw#40824 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
openclaw#69338) When ingestDelta returns null (first empty/commentary delta or unchanged content), the handler returned early, skipping setActivityStatus and armStreamingWatchdog. If all subsequent deltas were also null (e.g. due to phase filtering), the watchdog was never armed and the status bar stayed stale as "idle" while a run was live. Move setActivityStatus("streaming") and armStreamingWatchdog before the null-displayText guard so they fire on every received delta event. Fixes openclaw#34513, openclaw#40824 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
zhonghe0615
pushed a commit
to zhonghe0615/openclaw
that referenced
this pull request
May 7, 2026
openclaw#69338) When ingestDelta returns null (first empty/commentary delta or unchanged content), the handler returned early, skipping setActivityStatus and armStreamingWatchdog. If all subsequent deltas were also null (e.g. due to phase filtering), the watchdog was never armed and the status bar stayed stale as "idle" while a run was live. Move setActivityStatus("streaming") and armStreamingWatchdog before the null-displayText guard so they fire on every received delta event. Fixes openclaw#34513, openclaw#40824 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
openclaw#69338) When ingestDelta returns null (first empty/commentary delta or unchanged content), the handler returned early, skipping setActivityStatus and armStreamingWatchdog. If all subsequent deltas were also null (e.g. due to phase filtering), the watchdog was never armed and the status bar stayed stale as "idle" while a run was live. Move setActivityStatus("streaming") and armStreamingWatchdog before the null-displayText guard so they fire on every received delta event. Fixes openclaw#34513, openclaw#40824 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ingestDeltareturnsnull(no visible change yet — first commentary-only delta, tool-call delta, or unchanged content), the handler returned early, skippingsetActivityStatus("streaming")andarmStreamingWatchdognull(common when phase filtering drops all content), the streaming watchdog was never armed and the status bar stayed stuck on"idle"while the run was activesetActivityStatusandarmStreamingWatchdogbefore the null check so both fire on every received delta, regardless of visible outputRoot cause
The
tui.requestRender()at the end ofhandleChatEventis intentionally still skipped on null deltas (no visual change), so render pressure is unchanged.Affected issues
Fixes #34513, #40824
Test plan
streamingimmediately when a run starts, even if first visible text arrives after a delaypnpm test src/tui/green🤖 Generated with Claude Code