Greptile Summary

This PR propagates messageProvider into before_compaction, after_compaction, and before_reset hook contexts across three code paths: the embedded-subscribe compaction handler, the command reset flow, and the gateway sessions.reset path. For the gateway path it adds inferMessageProviderFromSessionKey, which parses canonical session keys and extracts the channel segment.

The fix is correct for the targeted channel-scoped session keys (agent:{id}:feishu:…, agent:{id}:discord:…, etc.). One edge case: per-peer DM keys of the form agent:{id}:direct:{peerId} would yield \"direct\" (a chat-type label, not a channel name) from inferMessageProviderFromSessionKey because \"direct\" is not in the sentinel list — consider adding it alongside \"main\", \"cron\", \"subagent\", and \"acp\".

Confidence Score: 5/5

Safe to merge; the edge case with "direct" keys is P2 and unlikely to affect real deployments materially.

All findings are P2. The core fix is correct and well-tested. The inferMessageProviderFromSessionKey gap is a quality improvement rather than a blocking defect.

src/gateway/session-reset-service.ts — the inferMessageProviderFromSessionKey sentinel list.

This is a comment left during a code review.
Path: src/gateway/session-reset-service.ts
Line: 53-63

Comment:
**`inferMessageProviderFromSessionKey` misses non-channel `rest` prefixes**

Session keys built with `dmScope === "per-peer"` use the format `agent:{agentId}:direct:{peerId}`, so `rest.split(":")[0]` yields `"direct"` — a chat-type segment, not a channel name. Since `"direct"` is not in the sentinel list, `normalizeMessageChannel("direct")` is returned as `messageProvider`, giving downstream plugins an incorrect, non-channel value. Similarly, dashboard-scoped keys (`agent:ops:dashboard:…`) would surface `"dashboard"`. For those key shapes the function should return `undefined` to stay consistent with the "unknown provider" fallback the PR is trying to eliminate.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(hooks): preserve messageProvider in ..." | Re-trigger Greptile}

Addressed the follow-up issues in a6e53dfd81.

• threaded messageProvider through the subscribe-time compaction hook path instead of only reading it from SubscribeEmbeddedPiSessionParams without plumbing
• tightened gateway inference so only deliverable channels are returned, leaving keys like agent:main:direct:peer_123 without an inferred provider
• added a regression covering the non-channel direct session-key case

Local verification:

• pnpm build
• pnpm check
• node node_modules/vitest/vitest.mjs run src/agents/pi-embedded-subscribe.handlers.compaction.test.ts src/auto-reply/reply/commands-core.test.ts src/gateway/server.sessions.gateway-server-sessions-a.test.ts

Expanded this into a coordinated compaction/reset invariant fix, per the review suggestion.

Included in this update:

• shared hook messageProvider resolution across subscribe compaction, engine-owned compaction, command reset, and gateway sessions.reset
• normalization of explicit providers before emitting hook context
• strict inference only for real deliverable channel-scoped session keys
• zero-token compaction results now reset cached token/cost accounting instead of leaving safeguard-loop state behind

I also updated the issue/PR title and description to reflect the broader scope.

Local verification:

• pnpm build
• pnpm check
• pnpm exec vitest run src/auto-reply/reply/commands-core.test.ts src/agents/pi-embedded-subscribe.handlers.compaction.test.ts src/auto-reply/reply/reply-state.test.ts src/gateway/server.sessions.gateway-server-sessions-a.test.ts

Codex review: needs real behavior proof before merge.

Summary
The branch adds shared hook message-provider resolution, threads provider context through reset and compaction hooks, handles zero-token compaction accounting/cache cleanup, passes doctor env context, and adds tests plus a changelog entry.

Reproducibility: yes. by source inspection. Current main omits messageProvider on reset and subscribe-time compaction hook contexts, and its positive-only token guards skip zero-token compaction results.

Real behavior proof
Needs stronger real behavior proof before merge: The PR includes copied terminal output from the patched resolver, but it does not show the changed reset/compaction hook paths or zero-token accounting behavior running after the fix.

Next step before merge
Human merge gate only: the branch has no narrow automation repair blocker, but contributor proof is still too helper-level for the changed reset/compaction/accounting behavior.

Security
Cleared: Cleared: the diff adds no dependencies, workflow/package execution changes, downloads, lockfile changes, or secret-output path; the doctor env context stays within existing health contribution plumbing.

ProjectClownfish pushed a narrow repair to this branch so the original contributor path can stay canonical.

Source PR: #69270
Validation: pnpm exec vitest run src/utils/hook-message-provider.test.ts src/agents/pi-embedded-subscribe.handlers.compaction.test.ts src/auto-reply/reply/commands-core.test.ts src/auto-reply/reply/reply-state.test.ts src/gateway/server.sessions.gateway-server-sessions-a.test.ts; pnpm check:changed
Contributor credit is preserved in the branch history and PR context.

ProjectClownfish pushed a narrow repair to this branch so the original contributor path can stay canonical.

Source PR: #69270
Validation: pnpm exec vitest run src/utils/hook-message-provider.test.ts src/agents/pi-embedded-subscribe.handlers.compaction.test.ts src/auto-reply/reply/commands-core.test.ts src/auto-reply/reply/reply-state.test.ts src/gateway/server.sessions.gateway-server-sessions-a.test.ts; pnpm check:changed
Contributor credit is preserved in the branch history and PR context.