fix: add "claude" to Windows cmdCommands shim allowlist#68849
fix: add "claude" to Windows cmdCommands shim allowlist#68849tianhaocui wants to merge 3 commits intoopenclaw:mainfrom
Conversation
On Windows, Node spawn() cannot resolve .cmd shims without shell:true or an explicit extension. resolveWindowsCommandShim handles this for npm/pnpm/yarn/npx but "claude" was missing from the list, causing spawn claude ENOENT when routing to the claude-cli provider. Fixes openclaw#68788
Greptile SummaryAdds Confidence Score: 5/5Safe to merge — minimal, targeted fix with no cross-platform side effects. Single-line addition to an allowlist with a well-understood, deterministic function. Non-Windows behavior is unchanged. No logic issues or security concerns. No files require special attention. Reviews (1): Last reviewed commit: "fix: add "claude" to Windows cmdCommands..." | Re-trigger Greptile |
|
Related work from PRtags group Title: Open PR duplicate: Windows claude cmd shim spawning
|
|
Closing this as duplicate or superseded after Codex automated review. PR #68849 is a narrow allowlist-only duplicate for the Windows Claude CLI shim bug. Current main still has the bug, but open PR #68819 supersedes this PR by tracking the full supervisor Best possible solution: Close PR #68849 as superseded and keep the remaining review on #68819, or an equivalent full core patch that handles supervisor Windows What I checked:
So I’m closing this here and keeping the remaining discussion on the canonical linked item. Codex Review notes: model gpt-5.5, reasoning high; reviewed against c7a0d9b1889c. |
Fixes #68788
Summary
resolveWindowsCommandShimresolves.cmdshims for Nodespawn()on Windows. The allowlist includesnpm,pnpm,yarn,npxbut is missingclaude, causingspawn claude ENOENTwhen routing to theclaude-cliprovider.Changes
Added
"claude"to thecmdCommandsarray insrc/process/supervisor/adapters/child.ts.Test Plan
claude.cmdon PATH, verifyprovider=claude-climodel calls succeedresolveWindowsCommandShimis a no-op)