fix(agents): strip <thought> and <antthinking> tags from output#688
Merged
Conversation
3ce1f7b to
4d0e74a
Compare
Contributor
|
Landed via temp rebase onto main. Thanks @theglove44! |
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
fix(agents): strip <thought> and <antthinking> tags from output
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
fix(agents): strip <thought> and <antthinking> tags from output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the regexes used for stripping thinking blocks to include support for
<thought>and<antthinking>tags. This ensures that reasoning traces from models using these tags (like Claude 3.7 / Google internal models) are properly hidden when thinking mode is disabled.Changes
THINKING_TAG_REand related regexes insrc/agents/pi-embedded-subscribe.tssrc/agents/pi-embedded-utils.tsMotivation
Users reported that thinking blocks were leaking into the output despite being disabled. This was likely due to the model using alternative tags not covered by the previous regex.