fix(telegram): trust explicit proxy DNS for media downloads#66461
Merged
vincentkoc merged 1 commit intomainfrom Apr 14, 2026
Merged
fix(telegram): trust explicit proxy DNS for media downloads#66461vincentkoc merged 1 commit intomainfrom
vincentkoc merged 1 commit intomainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes Telegram media downloads failing behind operator-configured explicit HTTP proxies by introducing a Confidence Score: 5/5
Reviews (1): Last reviewed commit: "fix(telegram): trust explicit proxy DNS ..." | Re-trigger Greptile |
steipete
pushed a commit
that referenced
this pull request
Apr 14, 2026
kvnkho
pushed a commit
to kvnkho/openclaw
that referenced
this pull request
Apr 17, 2026
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
could not download mediaon Bot API file downloads because the proxy is supposed to resolve Telegram CDN hostnames, not the local sandbox.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause (if applicable)
src/media/fetch.tsalways wrapped media downloads in strict guarded-fetch mode, so explicit Telegram proxy dispatcher policies still ranresolvePinnedHostnameWithPolicy()on the target hostname before dialing the proxy.#52162fixed the env-proxy variant for provider HTTP helpers, but Telegram media downloads use explicit proxy dispatchers on a different path.Regression Test Plan (if applicable)
src/infra/net/fetch-guard.ssrf.test.ts,src/media/fetch.test.ts,extensions/telegram/src/bot/delivery.resolve-media-retry.test.tsUser-visible / Behavior Changes
v2026.4.8.Diagram (if applicable)
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation: N/ARepro + Verification
Environment
channels.telegram.proxy=http://<proxy-host>:8888Steps
getFile+ file fetch).Expected
Actual
could not download media.Evidence
Human Verification (required)
pnpm build.allowPrivateProxy, off-allowlist target still blocked in trusted explicit-proxy mode.Review Conversations
Compatibility / Migration
Yes)No)No)Risks and Mitigations