fix(discord): clear stale heartbeat timers in SafeGatewayPlugin.connect()#65087
Merged
vincentkoc merged 5 commits intoopenclaw:mainfrom Apr 12, 2026
Merged
Conversation
Contributor
Greptile SummaryAdds a Confidence Score: 5/5Safe to merge — targeted defensive fix with correct logic and appropriate test coverage for the reported crash scenario. No P0 or P1 issues found. The override correctly clears stale timers on both the normal and early-return code paths without introducing any new races. The mock faithfully represents the fields needed to exercise the override, and the test structure follows repo conventions. No files require special attention. Reviews (1): Last reviewed commit: "test(discord): assert super.connect() de..." | Re-trigger Greptile |
9a951fa to
ff03a1e
Compare
…ct()
The @buape/carbon@0.15.0 heartbeat setup has a race where stopHeartbeat()
runs before heartbeatInterval is assigned, leaving a stale setInterval with
a closed reconnectCallback. When the stale interval fires ~41s later it
throws an uncaught exception that bypasses the EventEmitter error path and
crashes the gateway process via process.on('uncaughtException').
Add a connect() override in SafeGatewayPlugin that unconditionally clears
both heartbeatInterval and firstHeartbeatTimeout before calling super. The
parent's connect() only calls stopHeartbeat() when isConnecting=false; when
isConnecting=true it returns early without clearing — this override fills
that gap.
Fixes openclaw#65009. Related: openclaw#64011, openclaw#63387, openclaw#62038.
The connect() override added in the heartbeat fix shifted the two pre-existing fetch() callsites from lines 370/436 to 387/453.
ff03a1e to
360d38e
Compare
This was referenced Apr 25, 2026
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
…ct() (openclaw#65087) * fix(discord): clear stale heartbeat timers in SafeGatewayPlugin.connect() The @buape/carbon@0.15.0 heartbeat setup has a race where stopHeartbeat() runs before heartbeatInterval is assigned, leaving a stale setInterval with a closed reconnectCallback. When the stale interval fires ~41s later it throws an uncaught exception that bypasses the EventEmitter error path and crashes the gateway process via process.on('uncaughtException'). Add a connect() override in SafeGatewayPlugin that unconditionally clears both heartbeatInterval and firstHeartbeatTimeout before calling super. The parent's connect() only calls stopHeartbeat() when isConnecting=false; when isConnecting=true it returns early without clearing — this override fills that gap. Fixes openclaw#65009. Related: openclaw#64011, openclaw#63387, openclaw#62038. * test(discord): assert super.connect() delegation in SafeGatewayPlugin tests * fix(ci): update raw-fetch allowlist line numbers for gateway-plugin.ts The connect() override added in the heartbeat fix shifted the two pre-existing fetch() callsites from lines 370/436 to 387/453. * docs(changelog): add discord heartbeat crash note * test(cli): align plugin registry load-context mock --------- Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
…ct() (openclaw#65087) * fix(discord): clear stale heartbeat timers in SafeGatewayPlugin.connect() The @buape/carbon@0.15.0 heartbeat setup has a race where stopHeartbeat() runs before heartbeatInterval is assigned, leaving a stale setInterval with a closed reconnectCallback. When the stale interval fires ~41s later it throws an uncaught exception that bypasses the EventEmitter error path and crashes the gateway process via process.on('uncaughtException'). Add a connect() override in SafeGatewayPlugin that unconditionally clears both heartbeatInterval and firstHeartbeatTimeout before calling super. The parent's connect() only calls stopHeartbeat() when isConnecting=false; when isConnecting=true it returns early without clearing — this override fills that gap. Fixes openclaw#65009. Related: openclaw#64011, openclaw#63387, openclaw#62038. * test(discord): assert super.connect() delegation in SafeGatewayPlugin tests * fix(ci): update raw-fetch allowlist line numbers for gateway-plugin.ts The connect() override added in the heartbeat fix shifted the two pre-existing fetch() callsites from lines 370/436 to 387/453. * docs(changelog): add discord heartbeat crash note * test(cli): align plugin registry load-context mock --------- Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
…ct() (openclaw#65087) * fix(discord): clear stale heartbeat timers in SafeGatewayPlugin.connect() The @buape/carbon@0.15.0 heartbeat setup has a race where stopHeartbeat() runs before heartbeatInterval is assigned, leaving a stale setInterval with a closed reconnectCallback. When the stale interval fires ~41s later it throws an uncaught exception that bypasses the EventEmitter error path and crashes the gateway process via process.on('uncaughtException'). Add a connect() override in SafeGatewayPlugin that unconditionally clears both heartbeatInterval and firstHeartbeatTimeout before calling super. The parent's connect() only calls stopHeartbeat() when isConnecting=false; when isConnecting=true it returns early without clearing — this override fills that gap. Fixes openclaw#65009. Related: openclaw#64011, openclaw#63387, openclaw#62038. * test(discord): assert super.connect() delegation in SafeGatewayPlugin tests * fix(ci): update raw-fetch allowlist line numbers for gateway-plugin.ts The connect() override added in the heartbeat fix shifted the two pre-existing fetch() callsites from lines 370/436 to 387/453. * docs(changelog): add discord heartbeat crash note * test(cli): align plugin registry load-context mock --------- Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
connect()override toSafeGatewayPluginthat clears stale heartbeat timers before delegating to the parent, preventing an intermittent uncaught exception that crashes the Discord gateway process and drops in-flight replies.Root Cause
@buape/carbon@0.15.0has a race in its heartbeat initialisation:When
sendHeartbeatdetects a zombie connection it callsstopHeartbeat(), which clearsheartbeatInterval— but the interval has not been assigned yet. ThesetIntervalon the next line then creates a timer whose closure holdsclosed=true. When it fires ~41 seconds later,reconnectCallback(closed=true)throws inside asetIntervalcallback. Node.js routes this toprocess.on('uncaughtException'), bypassing theEventEmitter.on('error')path the gateway supervisor monitors. systemd restarts the service and in-flight replies fail.Solution Applied
Override
connect()inSafeGatewayPluginto unconditionally clear bothheartbeatIntervalandfirstHeartbeatTimeoutbefore callingsuper.connect():The parent's
connect()only callsstopHeartbeat()whenisConnecting=false. WhenisConnecting=trueit returns early — leaving any stale timer alive. This override runs before that early-return check, ensuring stale timers are always cleared on reconnect.Bottleneck Solved
setIntervalfiring with a closedreconnectCallback@buape/carbon@0.15.0without requiring a version bumpTesting
Two new unit tests added to
extensions/discord/src/monitor/gateway-plugin.test.tsverifying thatheartbeatIntervalandfirstHeartbeatTimeoutare cleared whenconnect()is called whileisConnecting=true.Fixes #65009