feat(memory): harden grounded REM extraction#63297
Merged
Conversation
🔒 Aisle Security AnalysisWe found 4 potential security issue(s) in this PR:
1. 🟠 Potential secret/credential persistence in REM grounded evidence extraction
DescriptionThe grounded REM extraction logic can promote and persist lines containing secrets/credentials into durable memory surfaces (e.g., REM backfill diary entries), due to the interaction between the new monitoring-suppression filter and the durable-signal bypass. Key points:
Vulnerable code paths:
.filter(
(entry) =>
!REM_MONITORING_SIGNAL_RE.test(`${section.title} ${entry.snippet.text}`) ||
isDurableSignalSnippet(entry.snippet.text, section.title),
)
return (
REM_MEMORY_SIGNAL_RE.test(text) ||
REM_PERSISTENCE_SIGNAL_RE.test(text) ||
REM_EXPLICIT_PREFERENCE_SIGNAL_RE.test(text) ||
REM_STABLE_PERSON_SIGNAL_RE.test(`${title} ${text}`) ||
REM_PERSON_PATTERN_SIGNAL_RE.test(text)
);
Impact:
RecommendationAdd explicit secret/credential detection and ensure it is never eligible for promotion or persistence, regardless of "durable" signals. Recommended changes:
Example (hard block): const REM_SECRET_SIGNAL_RE = /\b(password|passkey|credential|api[_-]?key|bearer\s+[a-z0-9._-]+|secret)\b/i;
function containsSecret(text: string, title: string): boolean {
return REM_SECRET_SIGNAL_RE.test(`${title} ${text}`);
}
// In chooseFactSnippets / chooseCandidateSnippets
.filter((entry) => !containsSecret(entry.snippet.text, section.title))Example (redaction, if you must keep context): function redactSecrets(value: string): string {
return value
.replace(/(bearer\s+)[a-z0-9._-]+/gi, "$1[REDACTED]")
.replace(/(password\s*[:=]\s*)\S+/gi, "$1[REDACTED]");
}Also add tests that include lines combining durable signals (e.g., "prefers") with credentials/tokens and assert they are excluded or redacted. 2. 🟡 Algorithmic complexity DoS in atomizeClaimText clause splitting
DescriptionThe claim atomization logic can exhibit quadratic-time behavior on long, delimiter-heavy input lines.
Vulnerable code: function splitTopLevelClauses(text: string, delimiter: string): string[] {
const parts: string[] = [];
let rest = text;
while (rest.length > 0) {
const splitAt = findTopLevelDelimiter(rest, delimiter);
if (splitAt < 0) {
parts.push(rest);
break;
}
parts.push(rest.slice(0, splitAt));
rest = rest.slice(splitAt + 1);
}
return parts.map((part) => normalizeWhitespace(part)).filter(Boolean);
}RecommendationAvoid repeated rescans of the remaining string. Option A (single pass): scan once and record delimiter positions at top level, then slice once. function splitTopLevelClauses(text: string, delimiter: string): string[] {
const parts: string[] = [];
let roundDepth = 0;
let squareDepth = 0;
let last = 0;
for (let i = 0; i < text.length; i += 1) {
const c = text[i];
if (c === "(") roundDepth += 1;
else if (c === ")") roundDepth = Math.max(0, roundDepth - 1);
else if (c === "[") squareDepth += 1;
else if (c === "]") squareDepth = Math.max(0, squareDepth - 1);
else if (c === delimiter && roundDepth === 0 && squareDepth === 0) {
parts.push(text.slice(last, i));
last = i + 1;
if (parts.length >= 3) break; // if you only ever use the first few atoms
}
}
if (last <= text.length && parts.length < 3) {
parts.push(text.slice(last));
}
return parts.map((p) => normalizeWhitespace(p)).filter(Boolean);
}Option B (limits): enforce maximum file size / maximum line length / maximum delimiter splits processed (e.g., stop after N splits or after M characters) before calling atomization. This prevents a crafted markdown file from causing excessive CPU/memory usage during scanning. 3. 🟡 Unbounded markdown traversal and heavy regex scoring can cause CPU/memory DoS
DescriptionThe This creates a denial-of-service risk when
Even without catastrophic backtracking, this is enough to cause CLI/UI lockups or high memory usage when processing untrusted or accidentally huge workspaces. RecommendationAdd explicit resource limits and early exits so large/untrusted inputs cannot exhaust CPU/RAM. Suggested mitigations (choose appropriate defaults for your environment):
Example (size + file-count limits): const MAX_FILES = 500;
const MAX_BYTES = 1_000_000; // 1MB
if (found.size >= MAX_FILES) return;
...
if (stat.isFile() && resolved.toLowerCase().endsWith('.md')) {
if (stat.size <= MAX_BYTES) found.add(resolved);
}If this code can be triggered by remote/untrusted content (e.g., in an extension processing arbitrary workspaces), treat this as a security boundary and enforce conservative limits. 4. 🟡 PII retention amplification by atomizing person/relationship lines into multiple durable memory candidates
DescriptionThe grounded REM extraction now splits a single line into multiple atomic claims (e.g., This creates a privacy/PII risk because:
Vulnerable flow (privacy amplification):
Vulnerable code: return chooseCandidateSnippets(section, snippets).flatMap((snippet) =>
atomizeClaimText(snippet.text)
.map((claim) => {
const score = scoreCandidateSnippet(claim, section.title);
const text = buildCandidateSnippetText(section.title, claim);
return {
text,
refs: [makeRef(params.relPath, snippet.line)],
lean: classifyCandidateLeanFromText(claim, section.title),
score,
};
})
.filter((candidate) => candidate.text.length >= 12 && candidate.score >= 1.8),
);While this may be intended behavior, it materially increases the likelihood that sensitive relationship facts become durable, independently retrievable memory entries. RecommendationAdd privacy minimization controls before persisting/surfacing atomized claims, especially for person-identifying content. Options (can be combined):
const isPersonRelationship = REM_STABLE_PERSON_SIGNAL_RE.test(`${section.title} ${snippet.text}`);
const claims = isPersonRelationship && !opts.allowPersonAtomization
? [snippet.text]
: atomizeClaimText(snippet.text);
Analyzed PR: #63297 at commit Last updated on: 2026-04-08T18:27:48Z |
Contributor
Author
|
Merged via squash.
Thanks @mbelinky! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e188b7e26d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+608
to
+609
| const match = /^(?<subject>.+?(?:—|–|-))\s*(?<rest>.+)$/u.exec(text); | ||
| if (!match?.groups) { |
There was a problem hiding this comment.
Limit subject splitting to actual dash separators
Update splitSubjectLeadClaim so it only treats a dash as a subject separator when it appears as a real delimiter (for example, spaced - / —), not any hyphen character. The current pattern matches hyphenated words, so inputs like Use long-term plan, avoid reactive tasks are split into malformed atomic claims (e.g., Use long- term plan), which can then be surfaced in ## Candidates/## Possible Lasting Updates as noisy or corrupted memory candidates.
Useful? React with 👍 / 👎.
Contributor
Greptile SummaryThis PR hardens the grounded REM backfill lane by tightening Confidence Score: 5/5Safe to merge; all findings are P2 style suggestions that do not affect correctness. The implementation is well-layered: monitoring suppression, durable-candidate scoring, and atomisation all have explicit score-threshold guards (1.4 / 1.8) that make borderline splits benign in practice. New tests directly exercise the three targeted scenarios. The only concern is the ASCII-hyphen in No files require special attention beyond the minor hyphen-regex note in
|
Comment on lines
+607
to
+627
| function splitSubjectLeadClaim(text: string): string[] { | ||
| const match = /^(?<subject>.+?(?:—|–|-))\s*(?<rest>.+)$/u.exec(text); | ||
| if (!match?.groups) { | ||
| return [text]; | ||
| } | ||
| const subject = normalizeWhitespace(match.groups.subject); | ||
| const rest = normalizeWhitespace(match.groups.rest); | ||
| if (!subject || !rest) { | ||
| return [text]; | ||
| } | ||
| const commaIndex = findTopLevelDelimiter(rest, ","); | ||
| if (commaIndex < 0) { | ||
| return [text]; | ||
| } | ||
| const first = normalizeWhitespace(rest.slice(0, commaIndex)); | ||
| const remainder = normalizeWhitespace(rest.slice(commaIndex + 1)); | ||
| if (first.length < 3 || remainder.length < 6) { | ||
| return [text]; | ||
| } | ||
| return [`${subject} ${first}`, `${subject} ${remainder}`]; | ||
| } |
Contributor
There was a problem hiding this comment.
(?:—|–|-) includes a plain ASCII hyphen -, so inputs like "non-trivial claim, worth noting" or "self-aware, sometimes unreliable" will match at the first hyphen: subject = "non-", rest = "trivial claim, worth noting". The first.length < 3 guard ("trivial claim" is well over 3 chars) and remainder.length < 6 don't block this, so it would return ["non- trivial claim", "non- worth noting"] — syntactically odd but harmless only because the score filter tends to reject them.
If you want to restrict splitting to semantic dashes only, consider excluding the plain hyphen:
Suggested change
| function splitSubjectLeadClaim(text: string): string[] { | |
| const match = /^(?<subject>.+?(?:—|–|-))\s*(?<rest>.+)$/u.exec(text); | |
| if (!match?.groups) { | |
| return [text]; | |
| } | |
| const subject = normalizeWhitespace(match.groups.subject); | |
| const rest = normalizeWhitespace(match.groups.rest); | |
| if (!subject || !rest) { | |
| return [text]; | |
| } | |
| const commaIndex = findTopLevelDelimiter(rest, ","); | |
| if (commaIndex < 0) { | |
| return [text]; | |
| } | |
| const first = normalizeWhitespace(rest.slice(0, commaIndex)); | |
| const remainder = normalizeWhitespace(rest.slice(commaIndex + 1)); | |
| if (first.length < 3 || remainder.length < 6) { | |
| return [text]; | |
| } | |
| return [`${subject} ${first}`, `${subject} ${remainder}`]; | |
| } | |
| function splitSubjectLeadClaim(text: string): string[] { | |
| const match = /^(?<subject>.+?(?:—|–))\s*(?<rest>.+)$/u.exec(text); |
Alternatively, require at least one whitespace around the hyphen when it's an ASCII dash: (?:—|–|\s+-\s+). Either way, the current behaviour is low-risk because of the downstream score threshold, but it's easy to tighten.
Prompt To Fix With AI
This is a comment left during a code review.
Path: extensions/memory-core/src/rem-evidence.ts
Line: 607-627
Comment:
**Hyphen in dash character class may split compound words**
`(?:—|–|-)` includes a plain ASCII hyphen `-`, so inputs like `"non-trivial claim, worth noting"` or `"self-aware, sometimes unreliable"` will match at the first hyphen: `subject = "non-"`, `rest = "trivial claim, worth noting"`. The `first.length < 3` guard (`"trivial claim"` is well over 3 chars) and `remainder.length < 6` don't block this, so it would return `["non- trivial claim", "non- worth noting"]` — syntactically odd but harmless only because the score filter tends to reject them.
If you want to restrict splitting to semantic dashes only, consider excluding the plain hyphen:
```suggestion
function splitSubjectLeadClaim(text: string): string[] {
const match = /^(?<subject>.+?(?:—|–))\s*(?<rest>.+)$/u.exec(text);
```
Alternatively, require at least one whitespace around the hyphen when it's an ASCII dash: `(?:—|–|\s+-\s+)`. Either way, the current behaviour is low-risk because of the downstream score threshold, but it's easy to tighten.
How can I resolve this? If you propose a fix, please make it concise.
25 tasks
eleqtrizit
pushed a commit
that referenced
this pull request
Apr 8, 2026
greidron
added a commit
to greidron/openclaw
that referenced
this pull request
Apr 10, 2026
* release: mirror bundled channel deps at root (openclaw#63065) Merged via squash. Prepared head SHA: ac26799 Co-authored-by: scoootscooob <167050519+scoootscooob@users.noreply.github.com> Co-authored-by: scoootscooob <167050519+scoootscooob@users.noreply.github.com> Reviewed-by: @scoootscooob * fix(test): keep warn log capture under openclaw temp dir * revert: undo background alive review findings fix * feat: add qa character vibes eval * test: stabilize plugin boundary invariants * test: isolate agent gateway cli command mocks * test: skip duplicate package boundary wrapper in ci * test: fix postpublish verifier sidecar handling * test: keep status tests off live usage probes * auto-reply: type status auth overrides * plugins: read contract inventory from manifests * test: inline cli metadata channel fixture * ci: skip duplicate full extension shard * test: isolate discord directory live token env * test: keep followup runner memory mock complete * ci: split parallel full suite into leaf shards * test: guard loader fixtures against broad sdk imports * test: keep bundled channel entry smokes descriptor-only * ci: reduce full suite test parallelism * test: avoid bundled test api smokes in matrix and telegram * test: keep discord and irc entry smokes descriptor-only * test: keep web provider artifact coverage manifest-only * test: keep provider policy artifact coverage narrow * test: keep web provider artifact test in boundary * test: keep status message tests off auth auto-detection * status: avoid plugin lookup for direct channel model overrides * channels: fast-path direct model override matches * test: restore manifest-only web provider coverage * fix: allow blank TLS manual port default (openclaw#63134) (thanks @Tyler-RNG) * make port optional for TLS manual connections * fix: restrict manual blank-port fallback to tls * fix: allow blank TLS manual port default (openclaw#63134) (thanks @Tyler-RNG) --------- Co-authored-by: Ayaan Zaidi <hi@obviy.us> * test: fix full suite CI test isolation * fix: align LLM idle timeout policy * test: exercise models json file mode without provider discovery * test: keep shared dm policy contract off channel facades * test: keep web provider artifact test in boundary * test: keep kilocode provider tests on plugin-owned helpers * ci: restore sequential full suite tests * test: keep public artifact coverage on cheap boundaries * test: keep openclaw tools registration tests on a fast shell * test: keep bundled metadata sidecar scan inventory-only * docs(inferrs): fix Gemma model id from gg-hf-gg to google (openclaw#62586) * fix: harden bundled plugin dependency release checks * ci: isolate full suite leaf shards * test: keep openclaw tools registration policy pure * fix: support Codex CLI QA auth * feat: add QA character eval reports * docs: document QA character eval workflow * refactor: dedupe media generation tool helpers * refactor: dedupe internal helper glue * refactor: dedupe shared helper branches * refactor: dedupe browser navigation guard tests * refactor: dedupe config and subagent tests * refactor: dedupe test helpers and script warning filter * refactor: dedupe plugin test harnesses * refactor: dedupe media runtime test mocks * refactor: dedupe plugin metadata test helpers * refactor: dedupe firecrawl and directive helpers * refactor: dedupe exec defaults tests * refactor: dedupe approval runtime tests * refactor: dedupe matrix exec approval tests * refactor: dedupe telegram exec approval tests * refactor: dedupe doctor codex oauth tests * refactor: dedupe agent command test fixtures * refactor: dedupe embedding provider test fixtures * refactor: share html entity tool call decoding * fix: keep minimax provider mocks package-local * test: keep pdf and update-plan registration tests pure * test: keep model reasoning override coverage on merge helpers * fix: default OpenAI reasoning effort to high * test: keep kimi implicit provider tests on provider catalog * fix(build): prune stale bundled plugin node_modules * fix(build): address bundled plugin prune review * fix(build): honor postinstall disable flag * test: keep chutes implicit provider tests on provider catalog * fix(plugin-sdk): export channel plugin base * docs: reorder changelog entries * test: keep bundled web-search owner checks on public artifacts * fix(build): keep tsdown prune best-effort * test: trust gateway exec fixture node path * fix: keep runtime task test harness behind task seams * test: explain gateway exec fixture trust * Reply: surface OAuth reauth failures (openclaw#63217) Merged via squash. Prepared head SHA: 68b7ffd Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky * test: make character eval scenario natural * feat: add character eval model options * test: keep pi fs workspace tests on fs tool factories * test: keep media runtime tests on same-directory provider mocks * fix(android): auto-resume pairing approval * fix(android): prefer bootstrap auth on qr pairing * fix(android): reset auth on new setup codes * fix(android): tighten pairing retry behavior * fix(android): prefer stored device auth after pairing * fix: restore android qr pairing flow (openclaw#63199) * fix(auto-reply): strip leading NO_REPLY tokens to prevent silent-reply leak (openclaw#63068) * fix(auto-reply): strip leading NO_REPLY tokens to prevent silent-reply leak * fix(auto-reply): preserve substantive NO_REPLY leading text * fix(agents): preserve ACP silent-prefix cumulative deltas * fix(auto-reply): harden silent-token streaming paths * fix(auto-reply): normalize glued silent tokens consistently --------- Co-authored-by: termtek <termtek@ubuntu.tail2b72cd.ts.net> * fix(gateway): clear auto-fallback model override on session reset (openclaw#63155) * fix(gateway): clear auto-fallback model override on session reset When `persistFallbackCandidateSelection()` writes a fallback provider override with `authProfileOverrideSource: "auto"`, the override was incorrectly preserved across `/reset` and `/new` commands. This caused sessions to keep using the fallback provider even after the user changed the agent config primary provider, because the session store override takes precedence over the config default. Now the override fields (`providerOverride`, `modelOverride`, `authProfileOverride`, `authProfileOverrideSource`, `authProfileOverrideCompactionCount`) are only carried forward when `authProfileOverrideSource === "user"` (i.e. explicit `/model` command). System-driven overrides are dropped on reset so the session picks up the current config default. Introduced in cb0a752 ("fix: preserve reset session behavior config") * fix(gateway): preserve explicit reset model selection * fix(gateway): track reset model override source * fix(gateway): preserve legacy reset model overrides * docs(changelog): add session reset merge note --------- Co-authored-by: termtek <termtek@ubuntu.tail2b72cd.ts.net> * test: stabilize ci test isolation * test: isolate volcengine byteplus auth resolver imports * fix: patch hono security advisories * fix: pass system prompt to codex cli * fix(plugins): prevent untrusted workspace plugins from hijacking bundled provider auth choices [AI] (openclaw#62368) * fix: address issue * fix: address review feedback * docs(changelog): add onboarding auth-choice guard entry * fix: address PR review feedback * fix: address PR review feedback * fix: address PR review feedback * fix: address PR review feedback * fix: address PR review feedback * fix: address PR review feedback * fix: address PR review feedback * fix: address PR review feedback --------- Co-authored-by: Devin Robison <drobison@nvidia.com> * test: isolate provider runtime test mocks * feat(plugins): support provider auth aliases * feat(memory): add grounded REM backfill lane (openclaw#63273) Merged via squash. Prepared head SHA: 4450f25 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky * feat(memory): harden grounded REM extraction (openclaw#63297) Merged via squash. Prepared head SHA: e188b7e Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky * feat(ui): add dreaming diary controls and navigation (openclaw#63298) Merged via squash. Prepared head SHA: 0a2ae66 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky * chore(ui): refresh zh-TW control ui locale * chore(ui): refresh zh-CN control ui locale * chore(ui): refresh pt-BR control ui locale * chore(ui): refresh de control ui locale * chore(ui): refresh es control ui locale * chore(ui): refresh ko control ui locale * chore(ui): refresh ja-JP control ui locale * chore(ui): refresh fr control ui locale * docs(matrix): tighten setup and config guidance * chore(ui): refresh tr control ui locale * chore(ui): refresh uk control ui locale * chore(ui): refresh pl control ui locale * chore(ui): refresh id control ui locale * test: stabilize full-suite execution * fix(matrix): contain sync outage failures (openclaw#62779) Merged via squash. Prepared head SHA: 901bb76 Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com> Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com> Reviewed-by: @gumadeiras * Align remote node exec event system messages with untrusted handling (openclaw#62659) * fix(nodes): downgrade remote exec system events * docs(changelog): add remote node exec event entry --------- Co-authored-by: Devin Robison <drobison@nvidia.com> * test: reuse image generate tool imports * test: reuse followup runner imports * docs(config): tighten wording in reference * test: harden provider mock isolation * fix(memory): accept embedded dreaming heartbeat tokens * test: harden Parallels macOS smoke fallback * build: narrow plugin SDK declaration build * fix(dotenv): block workspace runtime env vars (openclaw#62660) * fix(dotenv): block workspace runtime env vars Co-authored-by: zsx <git@zsxsoft.com> * docs(changelog): add workspace dotenv runtime-control entry * fix(dotenv): block workspace gateway port override --------- Co-authored-by: zsx <git@zsxsoft.com> Co-authored-by: Devin Robison <drobison@nvidia.com> * build: stage nostr runtime dependencies * fix: load QA live provider overrides * feat: parallelize character eval runs * auth: avoid external cli sync on profile upsert * test(doctor): mock memory-core runtime seam * auth: persist explicit profile upserts directly * Matrix: report startup failures as errors * fix(browser): harden browser control override loading (openclaw#62663) * fix(browser): harden browser control overrides * fix(lint): prepare boundary artifacts for extension oxlint * docs(changelog): add browser override hardening entry * fix(lint): avoid duplicate boundary prep --------- Co-authored-by: Devin Robison <drobison@nvidia.com> Co-authored-by: Devin Robison <drobison00@users.noreply.github.com> * test: reuse exec directive reply imports * test: reuse verbose directive reply imports * fix(browser): re-check interaction-driven navigations (openclaw#63226) * fix(browser): guard interaction-driven navigations * fix(browser): avoid rechecking unchanged interaction urls * fix(browser): guard delayed interaction navigations * fix(browser): guard interaction-driven navigations for full action duration * fix(browser): avoid waiting on interaction grace timer * fix(browser): ignore same-document hash-only URL changes in navigation guard * fix(browser): dedupe interaction nav guards * fix(browser): guard same-URL reloads in interaction navigation listeners * docs(changelog): add interaction navigation guard entry * fix(browser): drop duplicate ssrfPolicy props * fix(browser): tighten interaction navigation guards --------- Co-authored-by: Devin Robison <drobison@nvidia.com> * test: move directive state coverage to pure tests * fix: enable thinking support for the ollama api (openclaw#62712) Merged via squash. Prepared head SHA: c0b9950 Co-authored-by: hoyyeva <63033505+hoyyeva@users.noreply.github.com> Co-authored-by: BruceMacD <5853428+BruceMacD@users.noreply.github.com> Reviewed-by: @BruceMacD * Slack: treat ACP block text as visible output (openclaw#62858) Merged via squash. Prepared head SHA: 14f202e Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com> Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com> Reviewed-by: @gumadeiras * fix: fail fast on qa live auth errors * fix: fail fast across qa scenario wait paths * test: cover qa scenario wait failure replies * fix: sanitize qa missing-key replies * test: cover sanitized qa missing-key replies * fix: align qa wait cursor semantics * test: cover mixed-traffic qa wait cursors * fix: classify curated qa missing-key replies * test: cover curated qa missing-key reply classification * fix: harden qa missing-key provider messages * test: cover unsafe qa missing-key providers * docs(changelog): add qa auth fail-fast entry (openclaw#63333) (thanks @shakkernerd) * fix(matrix/doctor): migrate legacy channels.matrix.dm.policy 'trusted' (fixes openclaw#62931) (openclaw#62942) Merged via squash. Prepared head SHA: d9f553b Co-authored-by: lukeboyett <46942646+lukeboyett@users.noreply.github.com> Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com> Reviewed-by: @gumadeiras * Memory/dreaming: feed grounded backfill into short-term promotion (openclaw#63370) Merged via squash. Prepared head SHA: 5dfe246 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky * docs: update unreleased changelog * fix(gateway): classify dream diary actions * fix(memory): align dreaming status payloads * Memory/dreaming: harden grounded backfill follow-ups * test: reuse inline directive reply imports * Docs/memory: explain grounded backfill flows * fix(deps): patch basic-ftp advisory * test: move inline directive collisions to pure tests * Slack: dedupe partial streaming replies (openclaw#62859) Merged via squash. Prepared head SHA: cbecb50 Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com> Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com> Reviewed-by: @gumadeiras * test: replace exec directive e2e with pure coverage * fix(plugins): keep test helpers out of contract barrels (openclaw#63311) Merged via squash. Prepared head SHA: 769e90c Co-authored-by: altaywtf <9790196+altaywtf@users.noreply.github.com> Co-authored-by: altaywtf <9790196+altaywtf@users.noreply.github.com> Reviewed-by: @altaywtf * test: move cron heartbeat delivery coverage below full turns * fix: inter-session messages must not overwrite established external lastRoute (openclaw#58013) Merged via squash. Prepared head SHA: 820ea20 Co-authored-by: duqaXxX <12242811+duqaXxX@users.noreply.github.com> Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Reviewed-by: @jalehman * fix(gateway): suppress announce/reply skip chat leakage (openclaw#51739) Merged via squash. Prepared head SHA: 2f53f3b Co-authored-by: Pinghuachiu <9033138+Pinghuachiu@users.noreply.github.com> Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Reviewed-by: @jalehman * Slack: key turn-local dedupe by dispatch kind Scope Slack turn-local delivery dedupe by reply dispatch kind so identical tool and final payloads on the same thread do not collapse into one send. Expose the existing dispatcher kind on the public reply-runtime seam and cover the Slack tracker and preview-fallback paths with regression tests. * Dreaming: surface grounded scene lane (openclaw#63395) Merged via squash. Prepared head SHA: 0c7f586 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky * test: avoid runtime auth overlays in failure-state coverage * fix(ci): align ollama thinking expectations * chore(ui): refresh zh-CN control ui locale * chore(ui): refresh pt-BR control ui locale * chore(ui): refresh zh-TW control ui locale * chore(ui): refresh de control ui locale * test(docker): reduce e2e log noise * chore(ui): refresh es control ui locale * chore(ui): refresh fr control ui locale * chore(ui): refresh ja-JP control ui locale * chore(ui): refresh ko control ui locale * chore(ui): refresh uk control ui locale * chore(ui): refresh id control ui locale * chore(ui): refresh pl control ui locale * chore(ui): refresh tr control ui locale * fix: restore main ci * fix(ci): drop silent history before truncation * docs: reorder unreleased changelog * test(docker): quiet success-path e2e logs * style: sort session import * build: mirror bundled plugin runtime deps * plugins: load lightweight provider discovery entries * ci: narrow Windows node test lane * fix: filter provider auth aliases by plugin trust * fix: surface delayed browser navigation blocks * style: format memory and gateway touchups * Delete docs/plans directory Unused artifact * test: avoid remote ollama timeout in api-key preservation coverage * test: keep auth-choice default-model coverage on lightweight provider * test: keep undefined-token auth-choice coverage generic * fix: stabilize character eval and Qwen model routing * test: keep agent command tests off external auth overlays * fix openrouter model picker refs (openclaw#63416) * fix openrouter model picker refs Signed-off-by: sallyom <somalley@redhat.com> * test(ui): cover openrouter slash-id /model resolution --------- Signed-off-by: sallyom <somalley@redhat.com> Co-authored-by: Vignesh Natarajan <vignesh.natarajan92@gmail.com> * ci: stabilize macOS and transcript policy tests * test: keep cli-provider agent command tests off external auth overlays * chore(lint): clear extension lint regressions and add openclaw#63416 changelog * test: update modelstudio catalog contract sentinel * test: update character eval public panel * fix: repair Windows dev-channel updater * test: move copilot models-json injection coverage to plan tests * plugin-sdk: split command status surface * plugin-sdk: keep command status compatibility path light * plugin-sdk: drop investigative weixin repro harness * tests: document config mock choice for eager warmup * fix: update command-status SDK baseline (openclaw#63174) (thanks @hxy91819) * test: cap broad live model sweeps * fix: drop raw gateway chat control replies * test: make shared-token reload deterministic * test: isolate agentic suite smoke tests * test: replace models-config matrix with narrow coverage * test: isolate onboard skills status mock * plugins: add lightweight anthropic vertex discovery * test: isolate model auth module state * test: isolate subagent registry resume imports * plugins: keep google provider policy lightweight * test: keep ollama unreachable discovery on localhost * test: mock auth profile external overlay in oauth tests * auth: avoid plugin setup scans during common auth resolution * fix(logging): break console/logger type cycle * fix(config): stop owner-display barrel cycles * fix(commands): split auth choice apply types * fix(infra): extract exec approvals allowlist types * fix(commands): split doctor prompt option types * chore: prepare 2026.4.9-beta.1 release * chore: refresh config schema version for 2026.4.9-beta.1 * chore: refresh plugin SDK API baseline * test: run local full suite project shards in parallel * wizard: add explicit skip option to plugin setup (openclaw#63436) * Wizard: allow skipping plugin setup * Agents: reset nodes tool test modules * tests: reset discord native-command seams in model picker (openclaw#63267) * ci: tolerate noisy npm pack json output * test: isolate slack thread-ts recovery * fix(msteams): isolate channel thread sessions by replyToId (openclaw#58615) (openclaw#62713) * fix(msteams): isolate thread sessions by replyToId (openclaw#58615) * fix(msteams): align thread ID extraction + fix test types * fix(msteams): route thread replies to correct thread via replyToId (openclaw#58030) (openclaw#62715) * fix(msteams): pin reply target at inbound time to prevent DM/channel leak (openclaw#54520) (openclaw#62716) * test: keep local full suite serial by default * chore: prepare 2026.4.9 stable release * Agents: guard legacy pi transport override * Agents: restore upstream pi runner sources --------- Signed-off-by: sallyom <somalley@redhat.com> Co-authored-by: scoootscooob <zhentongfan@gmail.com> Co-authored-by: scoootscooob <167050519+scoootscooob@users.noreply.github.com> Co-authored-by: Peter Steinberger <steipete@gmail.com> Co-authored-by: Nimrod Gutman <nimrod.gutman@gmail.com> Co-authored-by: Tyler Warburton <Ethan.gold-Steinberg@protonmail.com> Co-authored-by: Ayaan Zaidi <hi@obviy.us> Co-authored-by: Eric Curtin <eric.curtin@docker.com> Co-authored-by: Mariano <mbelinky@gmail.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: Frank Yang <frank.ekn@gmail.com> Co-authored-by: termtek <termtek@ubuntu.tail2b72cd.ts.net> Co-authored-by: Pavan Kumar Gondhi <pgondhi@nvidia.com> Co-authored-by: Devin Robison <drobison@nvidia.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com> Co-authored-by: Agustin Rivera <31522568+eleqtrizit@users.noreply.github.com> Co-authored-by: zsx <git@zsxsoft.com> Co-authored-by: Devin Robison <drobison00@users.noreply.github.com> Co-authored-by: Eva H <63033505+hoyyeva@users.noreply.github.com> Co-authored-by: BruceMacD <5853428+BruceMacD@users.noreply.github.com> Co-authored-by: Shakker <shakkerdroid@gmail.com> Co-authored-by: lukeboyett <46942646+lukeboyett@users.noreply.github.com> Co-authored-by: Altay <altay@uinaf.dev> Co-authored-by: altaywtf <9790196+altaywtf@users.noreply.github.com> Co-authored-by: Accunza <12242811+duqaXxX@users.noreply.github.com> Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Co-authored-by: Pinghuachiu <9033138+Pinghuachiu@users.noreply.github.com> Co-authored-by: Radek Sienkiewicz <mail@velvetshark.com> Co-authored-by: Sally O'Malley <somalley@redhat.com> Co-authored-by: Vignesh Natarajan <vignesh.natarajan92@gmail.com> Co-authored-by: Mason Huang <masonxhuang@tencent.com> Co-authored-by: Vincent Koc <vincentkoc@ieee.org> Co-authored-by: pashpashpash <nik@vault77.ai> Co-authored-by: sudie-codes <suvenkat95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What Happenedselection, suppressed monitoring sludge, split durable subfacts out of multi-fact candidate lines, and made reflections more relationship-aware when that is the real signal.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause / Regression History (if applicable)
git blame, prior PR, issue, or refactor if known): follow-up hardening on top of feat(memory): add grounded REM backfill lane #63273.Regression Test Plan (if applicable)
extensions/memory-core/src/cli.test.tsUser-visible / Behavior Changes
What Happenedprefers more persistence-shaped grounded facts.CandidatesandPossible Lasting Updatescan split durable subfacts out of mixed person lines.Diagram (if applicable)
Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation:Repro + Verification
Environment
mb-serverfor gatesSteps
openclaw memory rem-harness --json --grounded --path <history-dir>on noisy and relationship-heavy day files.What Happened,Reflections, andCandidates.Expected
Actual
Evidence
Human Verification (required)
Review Conversations
Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoRisks and Mitigations