Skip to content

Matrix: prompt invite auto-join during onboarding#62168

Merged
gumadeiras merged 3 commits intomainfrom
codex/matrix-onboarding-autojoin-step
Apr 7, 2026
Merged

Matrix: prompt invite auto-join during onboarding#62168
gumadeiras merged 3 commits intomainfrom
codex/matrix-onboarding-autojoin-step

Conversation

@gumadeiras
Copy link
Copy Markdown
Member

@gumadeiras gumadeiras commented Apr 6, 2026

Summary

  • add a Matrix onboarding step for invite auto-join with an explicit warning that the default is off
  • persist autoJoin and autoJoinAllowlist through the Matrix account config writer, including clearing stale allowlists when switching away from allowlist mode
  • cover the add-account, env-shortcut, and stale-allowlist regression paths in Matrix onboarding tests and document the new wizard step

Testing

  • pnpm test extensions/matrix/src/onboarding.test.ts
  • pnpm test extensions/matrix/src/channel.setup.test.ts
  • pnpm format

Notes

  • pnpm tsgo is currently blocked by unrelated pre-existing extensions/msteams/src/monitor-handler/message-handler.ts errors on this branch/worktree

Copilot AI review requested due to automatic review settings April 6, 2026 22:51
@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation channel: matrix Channel integration: matrix size: M maintainer Maintainer-authored PR labels Apr 6, 2026
@gumadeiras gumadeiras self-assigned this Apr 6, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 6, 2026

Greptile Summary

Adds a Matrix onboarding step that prompts for invite auto-join (allowlist / always / off) with an explicit default-off warning, persisting autoJoin and autoJoinAllowlist through the account config writer — including stale-allowlist cleanup when switching modes. The room-access prompts are refactored into a shared configureMatrixAccessPrompts helper so both the env-shortcut and full wizard paths reach the new step consistently.

Confidence Score: 5/5

This PR is safe to merge — no blocking issues found.

All remaining findings are P2 or lower. The implementation correctly persists the new fields via applyNullableArrayField with null-deletion semantics, clears stale allowlists when switching modes, and the tests cover the key regression paths (env-shortcut add-account, stale-allowlist cleanup, warning note presence, allowlist write-through). The top-level storage fix in config-update.ts is a genuine correctness improvement.

No files require special attention.

Reviews (1): Last reviewed commit: "Matrix: prompt invite auto-join during o..." | Re-trigger Greptile

Copilot AI reviewed Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Matrix onboarding wizard to explicitly configure invite auto-join (defaulting to off with a warning), and persists the resulting autoJoin/autoJoinAllowlist settings via the Matrix config writer, including clearing stale allowlists when switching away from allowlist mode.

Changes:

  • Add a new Matrix onboarding step for configuring invite auto-join, including a default-off warning.
  • Persist autoJoin and autoJoinAllowlist through updateMatrixAccountConfig, clearing allowlists when auto-join is not allowlist.
  • Expand Matrix onboarding test coverage for env-shortcut add-account flow and stale allowlist clearing; update Matrix docs and changelog.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
extensions/matrix/src/runtime-api.ts Re-export splitSetupEntries from plugin-sdk to reuse shared setup parsing.
extensions/matrix/src/onboarding.ts Add invite auto-join wizard step and refactor access prompts to include it.
extensions/matrix/src/onboarding.test.ts Add onboarding regression tests covering env-shortcut add-account + stale allowlist clearing.
extensions/matrix/src/onboarding.test-harness.ts Update harness to drive the new invite auto-join prompts.
extensions/matrix/src/matrix/config-update.ts Add persistence/clearing support for autoJoin and autoJoinAllowlist.
docs/channels/matrix.md Document the new wizard step and clarify env-shortcut behavior.
CHANGELOG.md Add release note for the Matrix onboarding invite auto-join step.

Comment thread extensions/matrix/src/onboarding.ts Outdated
Comment thread extensions/matrix/src/onboarding.test-harness.ts Outdated
Comment thread extensions/matrix/src/matrix/config-update.ts
@openclaw-barnacle openclaw-barnacle Bot added channel: msteams Channel integration: msteams size: L and removed size: M labels Apr 7, 2026
@gumadeiras gumadeiras force-pushed the codex/matrix-onboarding-autojoin-step branch from 3d2637c to 6900536 Compare April 7, 2026 01:29
@openclaw-barnacle openclaw-barnacle Bot removed the channel: msteams Channel integration: msteams label Apr 7, 2026
@gumadeiras gumadeiras force-pushed the codex/matrix-onboarding-autojoin-step branch from c26860a to aec7a22 Compare April 7, 2026 03:21
@gumadeiras gumadeiras merged commit 9fd47a5 into main Apr 7, 2026
10 checks passed
@gumadeiras gumadeiras deleted the codex/matrix-onboarding-autojoin-step branch April 7, 2026 03:22
@gumadeiras
Copy link
Copy Markdown
Member Author

gumadeiras commented Apr 7, 2026

Merged via squash.

Thanks @gumadeiras!

@github-actions github-actions Bot mentioned this pull request Apr 7, 2026
Open
@gumadeiras gumadeiras mentioned this pull request Apr 8, 2026
Merged
25 tasks
lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026
@gumadeiras
Matrix: prompt invite auto-join during onboarding (openclaw#62168)
5e52ac4 
Merged via squash.

Prepared head SHA: aec7a22
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
@gumadeiras
Matrix: prompt invite auto-join during onboarding (openclaw#62168)
6d48958 
Merged via squash.

Prepared head SHA: aec7a22
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@gumadeiras gumadeiras

Labels

channel: matrix Channel integration: matrix docs Improvements or additions to documentation maintainer Maintainer-authored PR size: L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gumadeiras