fix(build): remove non-functional smoke test from package-mac-app.sh#615
Merged
steipete merged 2 commits intoopenclaw:mainfrom Jan 9, 2026
Merged
fix(build): remove non-functional smoke test from package-mac-app.sh#615steipete merged 2 commits intoopenclaw:mainfrom
steipete merged 2 commits intoopenclaw:mainfrom
Conversation
The --smoke qr argument was removed from the relay CLI, but the smoke test remained in the macOS app packaging script. This caused the build to fail with exit code 1 when the bundled relay didn't recognize the argument. Removes the 2-line smoke test section to fix the build. Fixes openclaw#317 Co-Authored-By: Claude <noreply@anthropic.com>
c9b46a0 to
0730e15
Compare
Contributor
|
Landed via temp rebase onto main. Thanks @YuriNachos! |
steipete
added a commit
that referenced
this pull request
Jan 9, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
fix(build): remove non-functional smoke test from package-mac-app.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS app build failing with exit code 1 due to a non-functional smoke test.
Changes
scripts/package-mac-app.sh: Removed lines 275-276echo "🧪 Smoke testing bundled relay QR modules""$RELAY_OUT" --smoke qr >/dev/nullRoot Cause
The
--smoke qrargument was removed from the relay CLI, but the smoke test call remained in the macOS app packaging script. When the bundled relay doesn't recognize this argument, it exits with code 1, causing the entire build to fail (due toset -euo pipefailat the top of the script).Testing
bash -n scripts/package-mac-app.sh- passedRelated Issues
Fixes #317
AI-Assisted PR
This PR was created with assistance from Claude Code (Anthropic).
Co-Authored-By: Claude noreply@anthropic.com