Greptile Summary

This PR aligns exec approval UX with the host-effective ask policy by propagating allowedDecisions through the entire approval pipeline — from host resolution in bash-tools.exec-host-gateway/node.ts, through the tool result shape (ExecToolDetails), forwarder messages, reply payloads, interactive buttons, and the Telegram extension. When a host sets ask=always, allow-always is filtered from all surfaces (message text, buttons, channelData, Telegram keyboards), and the gateway server method now enforces the same restriction at resolution time. The PR also introduces a new shared module (exec-approvals-effective.ts) that replaces the inline resolveHostExecPolicy helper previously duplicated in doctor-security.ts, and surfaces effective-policy breakdowns in openclaw approvals get and openclaw doctor.

Key changes:

• New resolveExecApprovalAllowedDecisions / isExecApprovalDecisionAllowed helpers gate allow-always when ask=always
• New exec-approvals-effective.ts module centralises requested ↔ host ↔ effective policy summaries with correct wildcard agents.* source attribution
• buildExecApprovalPendingReplyPayload and buildApprovalPendingMessage now derive the displayed decision list from allowedDecisions, not hardcoded strings
• openclaw approvals get (local + gateway) renders an effective-policy table and includes it in --json output
• /approve usage error text now points users to the pending-approval message rather than hardcoding allow-once|allow-always|deny
• Telegram handler and forwarding module pass allowedDecisions through correctly

Issues found:

• formatHostSource in exec-approvals-effective.ts is a no-op wrapper over resolveHostFieldSource — it can be removed
• The new allow-always guard in the gateway resolve handler is skipped when the approval snapshot is null; a missing-ID attempt with a disallowed decision silently falls through to the generic "not resolved" error rather than the policy-specific one

Confidence Score: 4/5

• Safe to merge — all enforcement paths are covered, tests validate the key scenarios, and no regressions were found in the approval pipeline.
• The change is well-scoped and thoroughly tested: new unit tests cover wildcard source attribution, ask=always filtering across message text, buttons, channelData, Telegram, the gateway resolver, and the CLI JSON output. The shared exec-approvals-effective.ts module correctly replaces two independent implementations. The only actionable findings are a redundant private helper (style) and a minor edge case in the gateway validation guard (won't cause incorrect approvals, just a slightly less-precise error response for a stale ID).
• src/infra/exec-approvals-effective.ts (redundant wrapper), src/gateway/server-methods/exec-approval.ts (guard skipped on null snapshot)

This is a comment left during a code review.
Path: src/infra/exec-approvals-effective.ts
Line: 110-115

Comment:
**Redundant wrapper function**

`formatHostSource` is a pass-through to `resolveHostFieldSource` with no added formatting logic. All three call sites could invoke `resolveHostFieldSource` directly, removing this layer of indirection.

```suggestion
```

Replace all three `formatHostSource(...)` calls with `resolveHostFieldSource(...)` and remove this function entirely.

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: src/gateway/server-methods/exec-approval.ts
Line: 328-344

Comment:
**Server-side `allow-always` guard only runs when snapshot is present**

The `isExecApprovalDecisionAllowed` check is wrapped in `if (snapshot && ...)`. When `snapshot` is `null` (i.e., the approval ID isn't found), the guard is skipped and `manager.resolve` is called with an unknown ID, which will return `false`. The overall outcome is the same — the resolve fails — but an `allow-always` attempt on a missing ID won't produce the specific policy-rejection error. This is a pre-existing limitation of the ID-not-found path, but worth noting in case a distinct error response is expected for stale IDs with disallowed decisions.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "exec: align approval UX with host policy" | Re-trigger Greptile}

Merged via squash.

• Prepared head SHA: d579b97a93b720876048c85fe6fed2a51d5893ef
• Merge commit: ba735d015809f1732eae13cf2c9f838c5d3def1f

Thanks @gumadeiras!