Bearer token silently stale after first injection

process.env["AWS_BEARER_TOKEN_BEDROCK"] is only written when it is absent (!baseEnv["…"].trim()). On the very first call the value is injected, but on every subsequent catalog refresh baseEnv["AWS_BEARER_TOKEN_BEDROCK"] is already truthy, so the branch is skipped. If the user later rotates the token in their plugin config, params.bearerToken will hold the new value but the guard will prevent it from reaching process.env — the AWS SDK will keep using the stale token until the process restarts.

The intent of the guard is presumably to avoid clobbering a token that was set independently in the real OS environment. A simple way to honour both goals is to also overwrite when the existing value differs from the incoming one:

This is a comment left during a code review.
Path: extensions/amazon-bedrock/discovery.ts
Line: 252-257

Comment:
**Bearer token silently stale after first injection**

`process.env["AWS_BEARER_TOKEN_BEDROCK"]` is only written when it is absent (`!baseEnv["…"].trim()`). On the very first call the value is injected, but on every subsequent catalog refresh `baseEnv["AWS_BEARER_TOKEN_BEDROCK"]` is already truthy, so the branch is skipped. If the user later rotates the token in their plugin config, `params.bearerToken` will hold the new value but the guard will prevent it from reaching `process.env` — the AWS SDK will keep using the stale token until the process restarts.

The intent of the guard is presumably to avoid clobbering a token that was set independently in the real OS environment. A simple way to honour both goals is to also overwrite when the existing value differs from the incoming one:

```suggestion
  if (params.bearerToken && params.bearerToken !== baseEnv["AWS_BEARER_TOKEN_BEDROCK"]?.trim()) {
```

How can I resolve this? If you propose a fix, please make it concise.

region plugin config property is not wired up

The schema exposes a region field under plugins.entries.amazon-bedrock.config, but extensions/amazon-bedrock/index.ts only reads pluginConfig?.bearerToken — it never reads pluginConfig?.region. The actual region is resolved from config.models.bedrockDiscovery.region (a different config path) inside resolveImplicitBedrockProvider.

A user who sets plugins.entries.amazon-bedrock.config.region expecting it to control the Bedrock region will have that value silently ignored. Either wire it up in index.ts before the resolveImplicitBedrockProvider call, or remove this field from the schema until it is implemented.

This is a comment left during a code review.
Path: src/plugins/bundled-plugin-metadata.generated.ts
Line: 159-163

Comment:
**`region` plugin config property is not wired up**

The schema exposes a `region` field under `plugins.entries.amazon-bedrock.config`, but `extensions/amazon-bedrock/index.ts` only reads `pluginConfig?.bearerToken` — it never reads `pluginConfig?.region`. The actual region is resolved from `config.models.bedrockDiscovery.region` (a different config path) inside `resolveImplicitBedrockProvider`.

A user who sets `plugins.entries.amazon-bedrock.config.region` expecting it to control the Bedrock region will have that value silently ignored. Either wire it up in `index.ts` before the `resolveImplicitBedrockProvider` call, or remove this field from the schema until it is implemented.

How can I resolve this? If you propose a fix, please make it concise.

Silent no-op test when tmpDir is outside home dir

When relToHome.startsWith("..") the test body returns without any assertions — it passes unconditionally, giving no signal that tilde expansion was not exercised. CI will show a green checkmark even though the feature was never verified.

Use Vitest's conditional skip instead:

or split the condition into beforeEach with it.skip(), so a skipped run is visible in the test report rather than silently passing.

This is a comment left during a code review.
Path: src/hooks/bundled/bootstrap-alternate-files/handler.test.ts
Line: 189-215

Comment:
**Silent no-op test when `tmpDir` is outside home dir**

When `relToHome.startsWith("..")` the test body returns without any assertions — it passes unconditionally, giving no signal that tilde expansion was not exercised. CI will show a green checkmark even though the feature was never verified.

Use Vitest's conditional skip instead:

```suggestion
  it.skipIf(path.relative(os.homedir(), tmpDir).startsWith(".."))("expands tilde in source paths", async () => {
```

or split the condition into `beforeEach` with `it.skip()`, so a skipped run is visible in the test report rather than silently passing.

How can I resolve this? If you propose a fix, please make it concise.

Avoid mutating process env with plugin bearer token

Writing params.bearerToken into process.env creates sticky global state that survives later config changes. If a user removes plugins.entries.amazon-bedrock.config.bearerToken, this value is never cleared, so subsequent discovery runs can continue authenticating with stale credentials and keep Bedrock implicitly enabled until process restart.

Useful? React with 👍 / 👎.

Fixed in 64a3b9142f. When params.bearerToken is absent but a plugin-injected value exists in process.env, we now delete it so removing the config from plugin.entries.amazon-bedrock.config actually clears bearer-token auth on the next catalog run.

Resolve SecretRef bearer tokens before normalization

The plugin now advertises bearerToken as string | object (SecretRef), but this path only calls normalizeSecretInputString, which returns undefined for objects. That means SecretRef-configured bearer tokens are silently ignored during Bedrock discovery, so users who follow the new schema/description will still fail auth unless they use a plain string or external env var.

Useful? React with 👍 / 👎.

Fixed in 64a3b9142f. Added inline env-source SecretRef resolution in index.ts: if bearerTokenRaw is an object with source: "env", we read ctx.env[ref.id] directly. File/exec refs fall through to undefined in non-interactive catalog runs — env/credential discovery still works in that case.

Preserve env Bedrock token when plugin token is unset

This branch removes process.env.AWS_BEARER_TOKEN_BEDROCK whenever params.bearerToken is missing, regardless of whether the value came from plugin config or the operator environment. In normal catalog runs params.env is process.env, so users relying on AWS_BEARER_TOKEN_BEDROCK lose their credential on the first discovery pass, hasAwsCreds can flip false, and implicit Bedrock discovery may be disabled until restart. The cleanup should only clear a token that was explicitly injected by plugin config, not a pre-existing env credential.

Useful? React with 👍 / 👎.

Avoid preselecting inherited model as explicit override

buildModelOptions now marks every option selected when option.value === current, but current is passed as effectivePrimary (which includes inherited defaults). For non-default agents with no explicit primary, this makes a concrete model option selected at the same time as the empty “Inherit default” option, and single-select behavior resolves to the concrete option, so inherited agents can appear explicitly pinned after reload. Selection marking should use the explicit override value, not the effective inherited value.

Useful? React with 👍 / 👎.