fix(subagents): preserve requester agent for inline announces#55998
Conversation
Greptile SummaryThis PR fixes a regression where named subagents without channel bindings would lose their requester identity when inline deterministic tool actions (e.g. a
Confidence Score: 5/5Safe to merge — the code change is minimal, correct, and covered by a targeted regression test; the only finding is a P2 changelog style concern. The one-line source fix is straightforward and consistent with the pattern used elsewhere in the codebase (pi-tools.ts). The new test properly mocks the dependency, resets state in beforeEach, and directly asserts the regression is covered. No P0 or P1 issues were found. CHANGELOG.md — the self-referential "Maintainer follow-up" entry on line 67 should be removed or merged into the preceding entry.
|
| Filename | Overview |
|---|---|
| src/auto-reply/reply/get-reply-inline-actions.ts | Minimal one-line fix: passes requesterAgentIdOverride: agentId to createOpenClawTools so named agents retain their identity when inline deterministic tool dispatches create OpenClaw tools. Correctly mirrors the pattern already used in pi-tools.ts. |
| src/auto-reply/reply/get-reply-inline-actions.skip-when-config-empty.test.ts | Regression test added for the named-agent spawn path. Mock for createOpenClawTools is properly registered and reset in beforeEach. The new test verifies requesterAgentIdOverride is forwarded and the tool is actually executed. |
| CHANGELOG.md | Two new entries added under Fixes. The first correctly documents the bug fix and credits the original reporter. The second 'Maintainer follow-up' entry is self-referential (author thanks themselves), which diverges from the established convention. |
Comments Outside Diff (1)
-
CHANGELOG.md, line 67 (link)Self-referential "Maintainer follow-up" changelog entry
Line 67 adds a second changelog entry that thanks
@vincentkoc— the same author as this PR. Every otherThanks @<handle>in the changelog credits an external reporter or contributor, not the person who wrote the fix. The actual bug report credit is already captured on line 66 (Thanks @kAIborg24). This second entry appears redundant and doesn't fit the established convention.Consider removing it, or folding the "mainline path" detail into line 66 if it adds meaningful context:
Prompt To Fix With AI
This is a comment left during a code review. Path: CHANGELOG.md Line: 67 Comment: **Self-referential "Maintainer follow-up" changelog entry** Line 67 adds a second changelog entry that thanks `@vincentkoc` — the same author as this PR. Every other `Thanks @<handle>` in the changelog credits an _external_ reporter or contributor, not the person who wrote the fix. The actual bug report credit is already captured on line 66 (`Thanks @kAIborg24`). This second entry appears redundant and doesn't fit the established convention. Consider removing it, or folding the "mainline path" detail into line 66 if it adds meaningful context: How can I resolve this? If you propose a fix, please make it concise.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix All With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 67
Comment:
**Self-referential "Maintainer follow-up" changelog entry**
Line 67 adds a second changelog entry that thanks `@vincentkoc` — the same author as this PR. Every other `Thanks @<handle>` in the changelog credits an _external_ reporter or contributor, not the person who wrote the fix. The actual bug report credit is already captured on line 66 (`Thanks @kAIborg24`). This second entry appears redundant and doesn't fit the established convention.
Consider removing it, or folding the "mainline path" detail into line 66 if it adds meaningful context:
```suggestion
- Subagents/announcements: preserve the requester agent id for inline deterministic tool spawns so named agents without channel bindings can still announce completions through the correct owner session. (#55437) Thanks @kAIborg24.
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Merge branch 'main' into fix/subagent-an..." | Re-trigger Greptile
8496964 to
b329b5f
Compare
…aw#55998) * fix(subagents): preserve requester agent on inline announce * docs(changelog): remove maintainer follow-up entry
…aw#55998) * fix(subagents): preserve requester agent on inline announce * docs(changelog): remove maintainer follow-up entry
…aw#55998) * fix(subagents): preserve requester agent on inline announce * docs(changelog): remove maintainer follow-up entry
…aw#55998) * fix(subagents): preserve requester agent on inline announce * docs(changelog): remove maintainer follow-up entry
…aw#55998) * fix(subagents): preserve requester agent on inline announce * docs(changelog): remove maintainer follow-up entry
…aw#55998) * fix(subagents): preserve requester agent on inline announce * docs(changelog): remove maintainer follow-up entry
…aw#55998) * fix(subagents): preserve requester agent on inline announce * docs(changelog): remove maintainer follow-up entry
…aw#55998) * fix(subagents): preserve requester agent on inline announce * docs(changelog): remove maintainer follow-up entry
Summary
Validation
Fixes #55437