@codex review

Greptile Summary

This PR adds targeted detection and auto-repair of legacy bundled plugin load paths that still point at extensions/<id> rather than the current dist/extensions/<id> layout, wiring the new repair into both doctor --fix and the preview-warnings pipeline so users see an actionable hint before startup fails.\n\nKey changes:\n- bundled-plugin-load-paths.ts (new): scanBundledPluginLoadPathMigrations builds a map of expected legacy paths derived from each bundled plugin's current localPath, then matches against user config entries; maybeRepairBundledPluginLoadPaths rewrites matched entries in a structuredClone of the config and returns change notes; collectBundledPluginLoadPathWarnings formats the user-facing hint.\n- repair-sequencing.ts: inserts the new repair before maybeRepairStalePluginConfig, ensuring stale-plugin cleanup sees already-migrated paths.\n- preview-warnings.ts: integrates the scan into the existing warning pipeline.\n- Tests: new unit tests cover detection, repair, warning formatting, and the no-op (already-new-path) case; an integration test covers the end-to-end preview-warning path.\n\nOne minor concern: maybeRepairBundledPluginLoadPaths silently drops non-string entries from paths when rebuilding the array, whereas the scan phase preserves them. In practice paths entries are always strings, but making the two phases consistent would be more defensive.

Confidence Score: 5/5

Safe to merge; targeted fix with solid test coverage and no changes to startup-time behaviour.

Core detection and repair logic is correct: buildLegacyBundledPath correctly inverts the dist/extensions/ suffix, the seen-set deduplication handles the edge case where both the legacy and new paths are already present, and the repair is correctly ordered before maybeRepairStalePluginConfig. The only identified gap (non-string path entries silently dropped during repair) is a defensive-coding concern rather than a correctness bug under realistic configs. Test coverage is thorough.

No files require special attention; the P2 comment on bundled-plugin-load-paths.ts is optional hardening.

This is a comment left during a code review.
Path: src/commands/doctor/shared/bundled-plugin-load-paths.ts
Line: 120-132

Comment:
**Non-string path entries silently dropped during repair**

When a legacy hit is detected, `maybeRepairBundledPluginLoadPaths` rebuilds the `paths` array but silently omits any non-string entries via the `continue` branch. The scan phase correctly skips non-strings without affecting them, but the repair phase drops them entirely — so a config with `paths: ["/legacy/feishu", 42, "/other/path"]` would be written back as `["/new/feishu", "/other/path"]` with no corresponding entry in `changes`.

In practice `paths` entries should always be strings, so this is unlikely to matter today, but making the repair preserve unrecognised entries would make the behaviour consistent with the scan:

```suggestion
  for (const entry of paths) {
    if (typeof entry !== "string") {
      // Preserve non-string entries as-is; only rewrite known legacy paths.
      rewritten.push(entry as string);
      continue;
    }
    const resolved = path.normalize(resolveUserPath(entry, env));
    const replacement = replacements.get(resolved)?.toPath ?? entry;
    const replacementResolved = path.normalize(resolveUserPath(replacement, env));
    if (seen.has(replacementResolved)) {
      continue;
    }
    seen.add(replacementResolved);
    rewritten.push(replacement);
  }
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(doctor): migrate legacy bundled plug..." | Re-trigger Greptile}

Codex Review: Didn't find any major issues. What shall we delve into next?

Follow-up:

• preserved non-string plugins.load.paths entries during repair instead of silently dropping them
• added regression coverage for mixed arrays like [legacyPath, 42, /other/path]

Local verification still passes:

• pnpm test -- src/commands/doctor/shared/bundled-plugin-load-paths.test.ts src/commands/doctor/shared/preview-warnings.test.ts
• pnpm exec oxfmt --check src/commands/doctor/shared/bundled-plugin-load-paths.ts src/commands/doctor/shared/bundled-plugin-load-paths.test.ts src/commands/doctor/shared/preview-warnings.ts src/commands/doctor/shared/preview-warnings.test.ts src/commands/doctor/repair-sequencing.ts

@obviyus when you have a moment, could you take a quick look?

This branch is now fully green again after the follow-up. The latest update only preserves mixed plugins.load.paths entries during doctor repair and adds regression coverage for that edge case; the overall scope is still the same focused doctor --fix migration for legacy bundled plugin load paths.

Thanks!

Landed on main.

• Landed source commit: ba35989
• Merge commit: 7016659

Thanks @SnowSky1.