refactor(plugins): route iMessage runtime through plugin sdk by scoootscooob · Pull Request #51770 · openclaw/openclaw

scoootscooob · 2026-03-21T17:08:24Z

Summary

route src/plugins/runtime/runtime-imessage.ts through src/plugin-sdk/imessage.ts
remove the stale iMessage entry from the plugin-extension import boundary inventory
reduce the remaining grandfathered direct imports from 4 to 3

Testing

pnpm lint:plugins:no-extension-imports
pnpm test -- src/plugin-sdk/runtime-api-guardrails.test.ts
pnpm test -- extensions/imessage/src/channel.outbound.test.ts extensions/imessage/src/probe.test.ts
node --import tsx - <<'EON'
import { createRuntimeIMessage } from './src/plugins/runtime/runtime-imessage.ts';
const runtime = createRuntimeIMessage();
console.log(JSON.stringify({
hasMonitor: typeof runtime.monitorIMessageProvider === 'function',
hasProbe: typeof runtime.probeIMessage === 'function',
hasSend: typeof runtime.sendMessageIMessage === 'function'
}, null, 2));
EON

greptile-apps · 2026-03-21T17:10:26Z

Greptile Summary

This PR routes two plugin runtime files (runtime-imessage.ts and runtime-slack-ops.runtime.ts) through their respective plugin-SDK façades instead of importing directly from extension-owned runtime-api.js files. Both src/plugin-sdk/imessage.ts and src/plugin-sdk/slack.ts already re-export all the necessary symbols, so this is a pure import-path refactor with no behavioral change.

Key points:

runtime-imessage.ts: import swapped from extensions/imessage/runtime-api.js → plugin-sdk/imessage.js; all three symbols (monitorIMessageProvider, probeIMessage, sendMessageIMessage) are verified present in the SDK re-export.
runtime-slack-ops.runtime.ts: import swapped from extensions/slack/runtime-api.js → plugin-sdk/slack.js; all eight aliased symbols are confirmed in the SDK re-export.
Inventory fixture: two resolved grandfathered entries removed, leaving 3 Telegram entries still to migrate.
Minor: the PR description says "reduce from 4 to 3" but two entries are removed (5 → 3), and only the iMessage removal is called out in the description text, even though the Slack routing also happens here.

Confidence Score: 5/5

Safe to merge — purely a refactor of import paths with no logic changes and all required symbols verified in place.
All three changed symbols in the iMessage SDK re-export and all eight aliased symbols in the Slack SDK re-export are confirmed correct. The inventory is updated consistently with the code. The only issue is a minor count discrepancy in the PR description (5→3, not 4→3) which has no bearing on correctness.
No files require special attention.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: test/fixtures/plugin-extension-import-boundary-inventory.json
Line: 1-3

Comment:
**Inventory count discrepancy with PR description**

The PR description states "reduce the remaining grandfathered direct imports from 4 to 3", but this diff removes **two** entries (both `runtime-imessage.ts` and `runtime-slack-ops.runtime.ts`) from a previous total of 5, bringing the count to 3 — a reduction of 2, not 1. The description also only calls out removing "the stale iMessage entry", while the Slack entry is removed here as well.

The code changes themselves are correct and consistent (both files now import through the plugin SDK, and both entries are rightfully removed). The mismatch is just in the PR description's accounting, which may be confusing to future readers of the inventory's git history.

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: "refactor: route iMes..."}

greptile-apps · 2026-03-21T17:10:30Z

 [
-  {
-    "file": "src/plugins/runtime/runtime-imessage.ts",
-    "line": 5,
-    "kind": "import",
-    "specifier": "../../../extensions/imessage/runtime-api.js",
-    "resolvedPath": "extensions/imessage/runtime-api.js",
-    "reason": "imports extension-owned file from src/plugins"
-  },
-  {
-    "file": "src/plugins/runtime/runtime-slack-ops.runtime.ts",
-    "line": 10,
-    "kind": "import",
-    "specifier": "../../../extensions/slack/runtime-api.js",
-    "resolvedPath": "extensions/slack/runtime-api.js",
-    "reason": "imports extension-owned file from src/plugins"
-  },
  {
    "file": "src/plugins/runtime/runtime-telegram-ops.runtime.ts",


Inventory count discrepancy with PR description

The PR description states "reduce the remaining grandfathered direct imports from 4 to 3", but this diff removes two entries (both runtime-imessage.ts and runtime-slack-ops.runtime.ts) from a previous total of 5, bringing the count to 3 — a reduction of 2, not 1. The description also only calls out removing "the stale iMessage entry", while the Slack entry is removed here as well.

The code changes themselves are correct and consistent (both files now import through the plugin SDK, and both entries are rightfully removed). The mismatch is just in the PR description's accounting, which may be confusing to future readers of the inventory's git history.

Prompt To Fix With AI

This is a comment left during a code review. Path: test/fixtures/plugin-extension-import-boundary-inventory.json Line: 1-3 Comment: **Inventory count discrepancy with PR description** The PR description states "reduce the remaining grandfathered direct imports from 4 to 3", but this diff removes **two** entries (both `runtime-imessage.ts` and `runtime-slack-ops.runtime.ts`) from a previous total of 5, bringing the count to 3 — a reduction of 2, not 1. The description also only calls out removing "the stale iMessage entry", while the Slack entry is removed here as well. The code changes themselves are correct and consistent (both files now import through the plugin SDK, and both entries are rightfully removed). The mismatch is just in the PR description's accounting, which may be confusing to future readers of the inventory's git history. How can I resolve this? If you propose a fix, please make it concise.

@GodsBoy

* main: (516 commits) fix: use content hash for memory flush dedup instead of compactionCount (openclaw#30115) (openclaw#34222) fix(tts): add matrix to VOICE_BUBBLE_CHANNELS (openclaw#37080) feat(memory): pluggable system prompt section for memory plugins (openclaw#40126) fix: detect nvm services from installed command (openclaw#51146) fix: handle Linux nvm CA env before startup (openclaw#51146) (thanks @GodsBoy) refactor: route Telegram runtime through plugin sdk (openclaw#51772) refactor: route iMessage runtime through plugin sdk (openclaw#51770) refactor: route Slack runtime through plugin sdk (openclaw#51766) refactor(doctor): extract provider and shared config helpers (openclaw#51753) Fix Discord `/codex_resume` picker expiration (openclaw#51260) fix(ci): remove duplicate embedding default export fix(ci): restore embedding defaults and plugin boundaries fix: compaction safeguard summary budget (openclaw#27727) web UI: fix context notice using accumulated inputTokens instead of prompt snapshot (openclaw#51721) fix(status): skip cold-start status probes refactor(doctor): extract telegram provider warnings (openclaw#51704) fix(telegram): default fresh setups to mention-gated groups docs(changelog): note telegram doctor first-run guidance fix(doctor): add telegram first-run guidance fix(doctor): suppress telegram fresh-install group warning ...

openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Mar 21, 2026

greptile-apps Bot reviewed Mar 21, 2026

View reviewed changes

scoootscooob self-assigned this Mar 21, 2026

refactor: route iMessage runtime through plugin sdk

79d0107

scoootscooob force-pushed the codex/imessage-runtime-plugin-sdk branch from e750c68 to 79d0107 Compare March 21, 2026 17:20

scoootscooob merged commit c0e482f into openclaw:main Mar 21, 2026
36 checks passed

github-actions Bot mentioned this pull request Mar 21, 2026

📡 Upstream Digest — 2026-03-21 18:25 UTC curtismercier/openclaw-mods#324

Open

MaheshBhushan pushed a commit to MaheshBhushan/openclaw that referenced this pull request Mar 22, 2026

refactor: route iMessage runtime through plugin sdk (openclaw#51770)

94624de

frankekn pushed a commit to artwalker/openclaw that referenced this pull request Mar 23, 2026

refactor: route iMessage runtime through plugin sdk (openclaw#51770)

f7840fd

furaul pushed a commit to furaul/openclaw that referenced this pull request Mar 24, 2026

refactor: route iMessage runtime through plugin sdk (openclaw#51770)

d1e5c21

alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Apr 4, 2026

refactor: route iMessage runtime through plugin sdk (openclaw#51770)

66f2965

lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026

refactor: route iMessage runtime through plugin sdk (openclaw#51770)

378cc64

ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026

refactor: route iMessage runtime through plugin sdk (openclaw#51770)

bd53ea0

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026

refactor: route iMessage runtime through plugin sdk (openclaw#51770)

550877d

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026

refactor: route iMessage runtime through plugin sdk (openclaw#51770)

c1ee7ab

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(plugins): route iMessage runtime through plugin sdk#51770

refactor(plugins): route iMessage runtime through plugin sdk#51770
scoootscooob merged 1 commit into
openclaw:mainfrom
scoootscooob:codex/imessage-runtime-plugin-sdk

scoootscooob commented Mar 21, 2026

Uh oh!

greptile-apps Bot commented Mar 21, 2026

Uh oh!

greptile-apps Bot Mar 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

scoootscooob commented Mar 21, 2026

Summary

Testing

Uh oh!

greptile-apps Bot commented Mar 21, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

greptile-apps Bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant