fix(daemon): query Windows task runtime directly#51486
fix(daemon): query Windows task runtime directly#51486wangji0923 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69a6a226d2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Greptile SummaryThis PR fixes #49187 by removing the unnecessary global Key changes:
One minor robustness note: the removed Confidence Score: 5/5
|
f62277c to
87009a1
Compare
|
Refreshed this PR onto the current The runtime path still needs the original fix on main:
Re-verified with focused checks:
|
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. Source inspection of current main shows a high-confidence mocked reproduction path: make broad Real behavior proof Next step before merge Security Review detailsBest possible solution: Land the narrow patch after exact-head CI is green and someone adds redacted live Windows Do we have a high-confidence way to reproduce the issue? Yes. Source inspection of current main shows a high-confidence mocked reproduction path: make broad Is this the best way to solve the issue? Yes for the code direction. Removing only the runtime-status preflight while preserving task-scoped failure fallback is the narrow maintainable fix, but merge readiness still depends on real behavior proof and final CI. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against cf0f1a171a04. |
87009a1 to
b80ae7a
Compare
|
Maintainer refresh: ported this onto current Prepared head: Local verification passed:
Waiting on fresh GitHub CI before merge. |
Summary
schtasks /Querypreflight fromreadScheduledTaskRuntime()so Windows status reads go straight to the task-scoped/Query /TN ... /V /FO LISTlookupLinked Issue
Repro + Verification
corepack pnpm test -- src/daemon/schtasks.test.ts src/daemon/schtasks.startup-fallback.test.ts src/daemon/inspect.test.tscorepack pnpm exec oxfmt --check src/daemon/schtasks.ts src/daemon/schtasks.startup-fallback.test.tsHuman Verification
Review Conversations
Risks and Mitigations
assertSchtasksAvailable()preflight.schtasks /Querypath when the task-scoped query is the only data this code path needs.pnpm checkdid not finish within the local timeout window, andnode scripts/tsdown-build.mjshit a Rolldown panic in this environment rather than a repo-specific TypeScript/build error.