Daemon: query Windows task runtime directly

LXT · BradGroux · commit b80ae7a0dabf · 2026-05-09T04:25:33.000-05:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -64,6 +64,7 @@ Docs: https://docs.openclaw.ai
 - Codex app-server: disarm the short post-tool completion watchdog after current-turn activity, expose `appServer.turnCompletionIdleTimeoutMs`, and include raw assistant item context in idle-timeout diagnostics so status-only post-tool stalls stop failing as idle. Fixes #77984. Thanks @roseware-dev and @rubencu.
 - Plugin skills/Windows: publish plugin-provided skill directories as junctions on Windows so standard users without Developer Mode can register plugin skills without symlink EPERM failures. Fixes #77958. (#77971) Thanks @hclsys and @jarro.
 - Shell env/Windows: hide the login-shell environment probe child window so gateway startup and shell-env refreshes do not flash a console on Windows. Fixes #78159. (#78266) Thanks @BradGroux.
+- Gateway/Windows: read scheduled-task runtime from the named task query directly so a fragile broad `schtasks /Query` preflight cannot make `openclaw status` report the gateway as unavailable. Fixes #49187. (#51486) Thanks @wangji0923.
 - MS Teams: surface blocked Bot Framework egress by logging JWKS fetch network failures and adding a Bot Connector send hint for transport-level reply failures. Fixes #77674. (#78081) Thanks @Beandon13.
 - Gateway/sessions: fast-path already-qualified model refs while building session-list rows so `openclaw sessions` and Control UI session lists avoid heavyweight model resolution on large stores. (#77902) Thanks @ragesaq.
 - Contributor PRs: remind external contributors to redact private information like IP addresses, API keys, phone numbers, and non-public endpoints from real behavior proof. Thanks @pashpashpash.
diff --git a/src/daemon/schtasks.startup-fallback.test.ts b/src/daemon/schtasks.startup-fallback.test.ts
@@ -7,6 +7,8 @@ import {
   inspectPortUsage,
   killProcessTree,
   resetSchtasksBaseMocks,
+  schtasksCalls,
+  schtasksThrownErrors,
   schtasksResponses,
   withWindowsEnv,
   writeGatewayScript,
@@ -122,12 +124,12 @@ function expectGatewayTermination(pid: number) {
 
 function addStartupFallbackMissingResponses(
   extraResponses: Array<{ code: number; stdout: string; stderr: string }> = [],
+  opts?: { includePreflight?: boolean },
 ) {
-  schtasksResponses.push(
-    { code: 0, stdout: "", stderr: "" },
-    { code: 1, stdout: "", stderr: "not found" },
-    ...extraResponses,
-  );
+  if (opts?.includePreflight ?? true) {
+    schtasksResponses.push({ code: 0, stdout: "", stderr: "" });
+  }
+  schtasksResponses.push({ code: 1, stdout: "", stderr: "not found" }, ...extraResponses);
 }
 
 function installGatewayScheduledTask(env: Record<string, string>, stdout = new PassThrough()) {
@@ -147,11 +149,9 @@ function fastForwardTaskStartWait(): void {
 
 function addAcceptedRunNeverStartsResponses(): void {
   addStartupFallbackMissingResponses([
-    { code: 0, stdout: "", stderr: "" },
     { code: 0, stdout: "", stderr: "" },
     { code: 0, stdout: "", stderr: "" },
     { code: 0, stdout: notYetRunTaskQueryOutput(), stderr: "" },
-    { code: 0, stdout: "", stderr: "" },
     { code: 0, stdout: notYetRunTaskQueryOutput(), stderr: "" },
   ]);
 }
@@ -341,10 +341,7 @@ describe("Windows startup fallback", () => {
     await withWindowsEnv("openclaw-win-startup-", async ({ env }) => {
       await writeGatewayScript(env);
       findVerifiedGatewayListenerPidsOnPortSync.mockReturnValue([4242]);
-      schtasksResponses.push(
-        { code: 0, stdout: "", stderr: "" },
-        { code: 0, stdout: notYetRunTaskQueryOutput(), stderr: "" },
-      );
+      schtasksResponses.push({ code: 0, stdout: notYetRunTaskQueryOutput(), stderr: "" });
 
       await expect(readScheduledTaskRuntime(env)).resolves.toMatchObject({
         status: "running",
@@ -364,10 +361,7 @@ describe("Windows startup fallback", () => {
         listeners: [{ pid: 4242, command: "node.exe" }],
         hints: [],
       });
-      schtasksResponses.push(
-        { code: 0, stdout: "", stderr: "" },
-        { code: 0, stdout: notYetRunTaskQueryOutput(), stderr: "" },
-      );
+      schtasksResponses.push({ code: 0, stdout: notYetRunTaskQueryOutput(), stderr: "" });
 
       await expect(readScheduledTaskRuntime(env)).resolves.toMatchObject({
         status: "stopped",
@@ -379,7 +373,7 @@ describe("Windows startup fallback", () => {
 
   it("treats an installed Startup-folder launcher as loaded", async () => {
     await withWindowsEnv("openclaw-win-startup-", async ({ env }) => {
-      addStartupFallbackMissingResponses();
+      addStartupFallbackMissingResponses([], { includePreflight: false });
       await writeStartupFallbackEntry(env);
 
       await expect(isScheduledTaskInstalled({ env })).resolves.toBe(true);
@@ -388,7 +382,47 @@ describe("Windows startup fallback", () => {
 
   it("reports runtime from the gateway listener when using the Startup fallback", async () => {
     await withWindowsEnv("openclaw-win-startup-", async ({ env }) => {
-      addStartupFallbackMissingResponses();
+      addStartupFallbackMissingResponses([], { includePreflight: false });
+      await writeStartupFallbackEntry(env);
+      inspectPortUsage.mockResolvedValue({
+        port: 18789,
+        status: "busy",
+        listeners: [{ pid: 4242, command: "node.exe" }],
+        hints: [],
+      });
+
+      await expect(readScheduledTaskRuntime(env)).resolves.toMatchObject({
+        status: "running",
+        pid: 4242,
+      });
+    });
+  });
+
+  it("reads runtime from the task-scoped schtasks query without a global preflight", async () => {
+    await withWindowsEnv("openclaw-win-startup-", async ({ env }) => {
+      schtasksResponses.push({
+        code: 0,
+        stdout: [
+          "TaskName: \\OpenClaw Gateway",
+          "Status: Running",
+          "Last Run Time: 2026/3/21 14:00:00",
+          "Last Run Result: 267009",
+        ].join("\r\n"),
+        stderr: "",
+      });
+
+      await expect(readScheduledTaskRuntime(env)).resolves.toMatchObject({
+        status: "running",
+        state: "Running",
+        lastRunResult: "267009",
+      });
+      expect(schtasksCalls).toEqual([["/Query", "/TN", "OpenClaw Gateway", "/V", "/FO", "LIST"]]);
+    });
+  });
+
+  it("falls back to Startup runtime when the task-scoped schtasks query throws", async () => {
+    await withWindowsEnv("openclaw-win-startup-", async ({ env }) => {
+      schtasksThrownErrors.push(new Error("spawn ENOENT"));
       await writeStartupFallbackEntry(env);
       inspectPortUsage.mockResolvedValue({
         port: 18789,
@@ -401,15 +435,19 @@ describe("Windows startup fallback", () => {
         status: "running",
         pid: 4242,
       });
+      expect(schtasksCalls).toEqual([["/Query", "/TN", "OpenClaw Gateway", "/V", "/FO", "LIST"]]);
     });
   });
 
   it("restarts the Startup fallback by killing the current pid and relaunching the entry", async () => {
     await withWindowsEnv("openclaw-win-startup-", async ({ env }) => {
-      addStartupFallbackMissingResponses([
-        { code: 0, stdout: "", stderr: "" },
-        { code: 1, stdout: "", stderr: "not found" },
-      ]);
+      addStartupFallbackMissingResponses(
+        [
+          { code: 0, stdout: "", stderr: "" },
+          { code: 1, stdout: "", stderr: "not found" },
+        ],
+        { includePreflight: true },
+      );
       await writeGatewayScript(env);
       await writeStartupFallbackEntry(env);
       inspectPortUsage.mockResolvedValue({
@@ -445,9 +483,7 @@ describe("Windows startup fallback", () => {
         { code: 0, stdout: "", stderr: "" },
         { code: 0, stdout: "", stderr: "" },
         { code: 0, stdout: "", stderr: "" },
-        { code: 0, stdout: "", stderr: "" },
         { code: 0, stdout: notYetRunTaskQueryOutput(), stderr: "" },
-        { code: 0, stdout: "", stderr: "" },
         { code: 0, stdout: notYetRunTaskQueryOutput(), stderr: "" },
       );
 
diff --git a/src/daemon/schtasks.ts b/src/daemon/schtasks.ts
@@ -1025,19 +1025,14 @@ export async function isScheduledTaskInstalled(args: GatewayServiceEnvArgs): Pro
 export async function readScheduledTaskRuntime(
   env: GatewayServiceEnv = process.env as GatewayServiceEnv,
 ): Promise<GatewayServiceRuntime> {
-  try {
-    await assertSchtasksAvailable();
-  } catch (err) {
-    if (await isStartupEntryInstalled(env)) {
-      return await resolveFallbackRuntime(env);
-    }
-    return {
-      status: "unknown",
-      detail: String(err),
-    };
-  }
   const taskName = resolveTaskName(env);
-  const res = await execSchtasks(["/Query", "/TN", taskName, "/V", "/FO", "LIST"]);
+  const res = await execSchtasks(["/Query", "/TN", taskName, "/V", "/FO", "LIST"]).catch(
+    (err: unknown) => ({
+      code: 1,
+      stdout: "",
+      stderr: String(err),
+    }),
+  );
   if (res.code !== 0) {
     if (await isStartupEntryInstalled(env)) {
       return await resolveFallbackRuntime(env);
diff --git a/src/daemon/test-helpers/schtasks-base-mocks.ts b/src/daemon/test-helpers/schtasks-base-mocks.ts
@@ -3,12 +3,17 @@ import {
   inspectPortUsage,
   killProcessTree,
   schtasksCalls,
+  schtasksThrownErrors,
   schtasksResponses,
 } from "./schtasks-fixtures.js";
 
 vi.mock("../schtasks-exec.js", () => ({
   execSchtasks: async (argv: string[]) => {
     schtasksCalls.push(argv);
+    const thrown = schtasksThrownErrors.shift();
+    if (thrown !== undefined) {
+      throw thrown;
+    }
     return schtasksResponses.shift() ?? { code: 0, stdout: "", stderr: "" };
   },
 }));
diff --git a/src/daemon/test-helpers/schtasks-fixtures.ts b/src/daemon/test-helpers/schtasks-fixtures.ts
@@ -8,6 +8,7 @@ import type { MockFn } from "../../test-utils/vitest-mock-fn.js";
 import { resolveTaskScriptPath } from "../schtasks.js";
 
 export const schtasksResponses: Array<{ code: number; stdout: string; stderr: string }> = [];
+export const schtasksThrownErrors: unknown[] = [];
 export const schtasksCalls: string[][] = [];
 
 export const inspectPortUsage: MockFn<(port: number) => Promise<PortUsage>> = vi.fn();
@@ -33,6 +34,7 @@ export async function withWindowsEnv(
 
 export function resetSchtasksBaseMocks() {
   schtasksResponses.length = 0;
+  schtasksThrownErrors.length = 0;
   schtasksCalls.length = 0;
   inspectPortUsage.mockReset();
   killProcessTree.mockReset();
