feat(github-copilot): resolve any model ID dynamically by fuller-stack-dev · Pull Request #51325 · openclaw/openclaw

fuller-stack-dev · 2026-03-20T23:35:39Z

Summary

Makes the GitHub Copilot extension's resolveDynamicModel handler a catch-all: any model ID not already in the Pi SDK registry gets a synthetic definition created automatically
New Copilot models (e.g. gpt-5.4-mini, claude-opus-4.6-fast) can now be used by adding them to agents.defaults.models in config — no code change or release required
Preserves the existing gpt-5.3-codex → gpt-5.2-codex template cloning for backward compat (falls through to synthetic catch-all if template is missing)
Infers reasoning: true for o1/o3 model IDs via heuristic, matching the existing supportsXHighThinking pattern
The Copilot API is OpenAI-compatible and returns its own error if a model isn't available on the user's plan, so there's no risk of silent failures

Motivation

Currently, every time GitHub adds a new model to Copilot, users hit Unknown model: github-copilot/<new-model> until a code change adds it to the registry or a forward-compat resolver. This is unnecessary friction — the extension should accept any model ID and let the API validate availability.

Test plan

Unit tests for all branches in models.test.ts
Verify github-copilot/gpt-5.4-mini resolves without "Unknown model" error
Verify existing models (e.g. claude-sonnet-4.6, gpt-4o) still resolve via the registry path
Verify gpt-5.3-codex still uses the template cloning path
Verify an invalid model ID gets a clean API error from Copilot rather than a gateway crash

greptile-apps · 2026-03-20T23:39:48Z

Greptile Summary

This PR refactors the GitHub Copilot extension's resolveDynamicModel handler into a dedicated models.ts module and expands it into a proper catch-all: any model ID not already in the registry now gets a synthetic definition created on the fly, eliminating the "Unknown model" error when Copilot adds new models that haven't been explicitly coded into the registry.

Key changes:

resolveCopilotForwardCompatModel is extracted from index.ts into the new models.ts, making it independently testable and cleanly separating concerns.
The handler now returns undefined (delegates to the normal path) for any model that is already in the registry, using a correctly-normalized (lowercased) lookup.
The gpt-5.3-codex → gpt-5.2-codex template-clone path is preserved for backward compatibility, falling through to the catch-all when the template is absent.
The synthetic catch-all uses api: "openai-responses", input: ["text", "image"] (optimistic multimodal, consistent with how the Copilot API behaves), and infers reasoning: true for model IDs matching /^o[13](\b|$)/ — anchored to the start of the string to avoid mid-string false positives.
All previously flagged issues (regex anchoring, unnecessary exports, input capability, casing normalization, test coverage for o3 and mid-string false positives) have been resolved across the series of fixup commits.

Confidence Score: 5/5

This PR is safe to merge — the changes are well-scoped, all previously flagged issues have been addressed, and the new code is covered by a thorough unit test suite.
All issues identified in prior review rounds have been fixed in subsequent commits (regex anchoring, casing normalization, export surface, input capabilities, and test coverage). The logic is straightforward — a simple guard-clause flow — and the optimistic ["text", "image"] choice is justified by the API's own error-return behavior for unsupported input types. No new critical issues were found.
No files require special attention.

_{Last reviewed commit: "fix(github-copilot):..."}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74d09d4d55

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 994648b9f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

fuller-stack-dev · 2026-03-21T00:20:17Z

@greptileai another review please

fuller-stack-dev · 2026-03-21T00:31:17Z

@greptileai another review please

fuller-stack-dev · 2026-03-21T00:40:31Z

@greptileai another review please

…y known ones

…ristic and tests

…nts, add mid-string test

…planatory comment

…st case

…ller-stack-dev

…ller-stack-dev)

obviyus · 2026-03-21T12:08:09Z

Landed on main.

Landed source commit: fef3a8c
Merge commit: 5137a51

Thanks @fuller-stack-dev.

chatgpt-codex-connector

💡 Codex Review

openclaw/extensions/github-copilot/index.ts

Lines 136 to 139 in fef3a8c

    
           provider: { 
        
             baseUrl, 
        
             models: [], 
        
           },

Publish forward-compat Copilot models into the model catalog

Returning an empty Copilot catalog here means the new runtime-only fallback never feeds loadModelCatalog(). In the common path this PR advertises—adding github-copilot/<new-id> under agents.defaults.models—buildAllowedModelSet() can only synthesize a bare {id,name,provider} entry, so resolveDefaultThinkingLevel() / resolveDefaultReasoningLevel() still treat models like github-copilot/gpt-5.4-mini as non-reasoning and default them to off. OpenAI/OpenAI-Codex pair their forward-compat resolver with catalog augmentation for exactly this reason; without the same step here, the “no code change required” flow ships incomplete behavior for every new Copilot model ID.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fuller-stack-dev

* feat(github-copilot): resolve any model ID dynamically instead of only known ones * refactor(github-copilot): extract model resolution, add reasoning heuristic and tests * fix(github-copilot): default synthetic models to text-only input * ci: retrigger checks * copilot: mark synthetic catch-all models as vision-capable * fix(github-copilot): anchor reasoning regex, unexport internal constants, add mid-string test * fix(github-copilot): default synthetic models to text-only input * fix(github-copilot): restore image input for synthetic models with explanatory comment * fix(github-copilot): normalize registry lookup casing, add bare o3 test case * fix: preserve configured overrides for dynamic models * fix: allow dynamic GitHub Copilot models (openclaw#51325) (thanks @fuller-stack-dev) --------- Co-authored-by: Ayaan Zaidi <hi@obviy.us>

@fuller-stack-dev

* feat(github-copilot): resolve any model ID dynamically instead of only known ones * refactor(github-copilot): extract model resolution, add reasoning heuristic and tests * fix(github-copilot): default synthetic models to text-only input * ci: retrigger checks * copilot: mark synthetic catch-all models as vision-capable * fix(github-copilot): anchor reasoning regex, unexport internal constants, add mid-string test * fix(github-copilot): default synthetic models to text-only input * fix(github-copilot): restore image input for synthetic models with explanatory comment * fix(github-copilot): normalize registry lookup casing, add bare o3 test case * fix: preserve configured overrides for dynamic models * fix: allow dynamic GitHub Copilot models (openclaw#51325) (thanks @fuller-stack-dev) --------- Co-authored-by: Ayaan Zaidi <hi@obviy.us>

@fuller-stack-dev

* feat(github-copilot): resolve any model ID dynamically instead of only known ones * refactor(github-copilot): extract model resolution, add reasoning heuristic and tests * fix(github-copilot): default synthetic models to text-only input * ci: retrigger checks * copilot: mark synthetic catch-all models as vision-capable * fix(github-copilot): anchor reasoning regex, unexport internal constants, add mid-string test * fix(github-copilot): default synthetic models to text-only input * fix(github-copilot): restore image input for synthetic models with explanatory comment * fix(github-copilot): normalize registry lookup casing, add bare o3 test case * fix: preserve configured overrides for dynamic models * fix: allow dynamic GitHub Copilot models (openclaw#51325) (thanks @fuller-stack-dev) --------- Co-authored-by: Ayaan Zaidi <hi@obviy.us>

@fuller-stack-dev

* feat(github-copilot): resolve any model ID dynamically instead of only known ones * refactor(github-copilot): extract model resolution, add reasoning heuristic and tests * fix(github-copilot): default synthetic models to text-only input * ci: retrigger checks * copilot: mark synthetic catch-all models as vision-capable * fix(github-copilot): anchor reasoning regex, unexport internal constants, add mid-string test * fix(github-copilot): default synthetic models to text-only input * fix(github-copilot): restore image input for synthetic models with explanatory comment * fix(github-copilot): normalize registry lookup casing, add bare o3 test case * fix: preserve configured overrides for dynamic models * fix: allow dynamic GitHub Copilot models (openclaw#51325) (thanks @fuller-stack-dev) --------- Co-authored-by: Ayaan Zaidi <hi@obviy.us>

@fuller-stack-dev

* feat(github-copilot): resolve any model ID dynamically instead of only known ones * refactor(github-copilot): extract model resolution, add reasoning heuristic and tests * fix(github-copilot): default synthetic models to text-only input * ci: retrigger checks * copilot: mark synthetic catch-all models as vision-capable * fix(github-copilot): anchor reasoning regex, unexport internal constants, add mid-string test * fix(github-copilot): default synthetic models to text-only input * fix(github-copilot): restore image input for synthetic models with explanatory comment * fix(github-copilot): normalize registry lookup casing, add bare o3 test case * fix: preserve configured overrides for dynamic models * fix: allow dynamic GitHub Copilot models (openclaw#51325) (thanks @fuller-stack-dev) --------- Co-authored-by: Ayaan Zaidi <hi@obviy.us>

@fuller-stack-dev

* feat(github-copilot): resolve any model ID dynamically instead of only known ones * refactor(github-copilot): extract model resolution, add reasoning heuristic and tests * fix(github-copilot): default synthetic models to text-only input * ci: retrigger checks * copilot: mark synthetic catch-all models as vision-capable * fix(github-copilot): anchor reasoning regex, unexport internal constants, add mid-string test * fix(github-copilot): default synthetic models to text-only input * fix(github-copilot): restore image input for synthetic models with explanatory comment * fix(github-copilot): normalize registry lookup casing, add bare o3 test case * fix: preserve configured overrides for dynamic models * fix: allow dynamic GitHub Copilot models (openclaw#51325) (thanks @fuller-stack-dev) --------- Co-authored-by: Ayaan Zaidi <hi@obviy.us>

openclaw-barnacle Bot added the size: S label Mar 20, 2026

greptile-apps Bot reviewed Mar 20, 2026

View reviewed changes

Comment thread extensions/github-copilot/models.ts Outdated

Comment thread extensions/github-copilot/models.ts Outdated

Comment thread extensions/github-copilot/models.test.ts

chatgpt-codex-connector Bot reviewed Mar 20, 2026

View reviewed changes

Comment thread extensions/github-copilot/models.ts

openclaw-barnacle Bot added size: M and removed size: S labels Mar 21, 2026

chatgpt-codex-connector Bot reviewed Mar 21, 2026

View reviewed changes

Comment thread extensions/github-copilot/models.ts

Comment thread extensions/github-copilot/models.ts

greptile-apps Bot reviewed Mar 21, 2026

View reviewed changes

Comment thread extensions/github-copilot/models.ts Outdated

greptile-apps Bot reviewed Mar 21, 2026

View reviewed changes

Comment thread extensions/github-copilot/models.ts Outdated

Comment thread extensions/github-copilot/models.test.ts

openclaw-barnacle Bot added the agents Agent runtime and tooling label Mar 21, 2026

obviyus self-assigned this Mar 21, 2026

fuller-stack-dev and others added 11 commits March 21, 2026 17:35

feat(github-copilot): resolve any model ID dynamically instead of onl…

f05fc16

…y known ones

refactor(github-copilot): extract model resolution, add reasoning heu…

5713be9

…ristic and tests

fix(github-copilot): default synthetic models to text-only input

ff8db11

ci: retrigger checks

4924089

copilot: mark synthetic catch-all models as vision-capable

28984e2

fix(github-copilot): anchor reasoning regex, unexport internal consta…

3c6cc91

…nts, add mid-string test

fix(github-copilot): default synthetic models to text-only input

3e7733d

fix(github-copilot): restore image input for synthetic models with ex…

33cfa72

…planatory comment

fix(github-copilot): normalize registry lookup casing, add bare o3 te…

429e77d

…st case

fix: preserve configured overrides for dynamic models

ccd5591

fix: allow dynamic GitHub Copilot models (openclaw#51325) (thanks @fu…

fef3a8c

…ller-stack-dev)

obviyus force-pushed the feat/copilot-catchall-dynamic-model branch from 8229a32 to fef3a8c Compare March 21, 2026 12:07

obviyus merged commit 5137a51 into openclaw:main Mar 21, 2026
11 checks passed

chatgpt-codex-connector Bot reviewed Mar 21, 2026

View reviewed changes

MoerAI mentioned this pull request Apr 8, 2026

fix(github-copilot): strip reasoning params for gpt-5-mini (#54844) #55432

Closed

clawsweeper Bot mentioned this pull request May 2, 2026

fix(copilot): remove stale claude-opus-4.6 from default model IDs #75391

Closed

clawsweeper Bot mentioned this pull request May 23, 2026

GitHub Copilot plugin: agents.defaults.imageModel for unknown Copilot model ID falls back to OpenAI provider with confusing 401 #85660

Closed

Uh oh!

Conversation

fuller-stack-dev commented Mar 20, 2026

Summary

Motivation

Test plan

Uh oh!

greptile-apps Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

fuller-stack-dev commented Mar 21, 2026

Uh oh!

Uh oh!

fuller-stack-dev commented Mar 21, 2026

Uh oh!

Uh oh!

Uh oh!

fuller-stack-dev commented Mar 21, 2026

Uh oh!

Uh oh!

obviyus commented Mar 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Mar 20, 2026 •

edited

Loading