Track ACP sessions_spawn runs and emit ACP lifecycle events by xaeon2026 · Pull Request #40885 · openclaw/openclaw

xaeon2026 · 2026-03-09T10:48:44Z

Summary

This fixes the missing completion path for ACP sessions_spawn runs in two places:

sessions_spawn(runtime="acp") now registers accepted non-streamTo="parent" child runs with the existing subagent registry so agent.wait/announce cleanup can run
ACP dispatch now emits lifecycle end/error events using the active run id, so listeners such as the parent stream relay can observe completion consistently

Why both changes are needed

The original issue points at missing ACP lifecycle completion events, which is real, but ACP sessions_spawn also was not feeding accepted child runs into the registry path that powers auto-announce cleanup.

Without registry tracking, one-shot ACP child runs had nothing waiting on agent.wait or triggering the announce flow.
Without ACP lifecycle end/error, listeners that subscribe directly to agent events still missed completion.

This patch keeps the fix narrow:

default ACP spawns now opt into the existing announce pipeline
streamTo="parent" ACP spawns keep relying on the dedicated parent relay instead of double-announcing through both paths
ACP runtime dispatch now reports terminal lifecycle state with the current run id

Tests

Added regression coverage for:

ACP sessions_spawn run-mode spawns are tracked for auto-announce cleanup via agent.wait
ACP streamTo="parent" spawns do not also register through the auto-announce path
ACP dispatch emits lifecycle end events with the active run id
ACP dispatch emits lifecycle error events with the active run id

Verification

pnpm vitest run src/agents/openclaw-tools.subagents.sessions-spawn.lifecycle.test.ts
pnpm vitest run src/auto-reply/reply/dispatch-from-config.test.ts

greptile-apps · 2026-03-09T10:53:15Z

Greptile Summary

This PR closes two gaps in the ACP lifecycle completion path: non-streamTo="parent" ACP sessions_spawn runs are now registered with the subagent registry (enabling agent.wait-based announce/cleanup), and tryDispatchAcpReply now emits lifecycle end/error agent events when a runId is present, letting direct onAgentEvent subscribers (e.g. parent stream relays) observe ACP turn completion consistently.

sessions-spawn-tool.ts: adds post-spawn registry tracking guarded by shouldTrackViaRegistry; on registration failure, best-effort cleanup deletes the already-created ACP session
dispatch-acp.ts: emits lifecycle end/error events via emitAgentEvent using the caller-supplied runId
dispatch-from-config.ts: propagates replyOptions?.runId to both the primary and AcpDispatchTailAfterReset ACP dispatch calls
Four new regression tests cover: registry tracking for ACP run-mode spawns, exclusion of streamTo="parent" spawns from the registry path, and lifecycle end/error event emission

Confidence Score: 4/5

This PR is safe to merge; the logic is sound with targeted changes and good regression test coverage.
The core mechanics are correct: shouldTrackViaRegistry correctly gates registry tracking on status === "accepted", non-empty keys, and streamTo !== "parent". The lifecycle event emission in dispatch-acp.ts is properly guarded. The fallback branch in resolveTrackedSpawnMode is dead code in practice (since spawnAcpDirect always populates mode on accepted results) but is harmless. The one area of imprecision is the cleanup-on-registration-failure path: the in-flight ACP turn may continue briefly after sessions.delete since the gateway dispatch is already in progress, but this is best-effort and acknowledged in comments. No data-loss or correctness regressions are introduced.
src/agents/tools/sessions-spawn-tool.ts — specifically the cleanup path when registerSubagentRun throws (lines 254–262); callers receiving the error result should not assume the child process has been terminated.

_{Last reviewed commit: a836cd4}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b60881f5ab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…e test

vincentkoc · 2026-03-29T07:59:47Z

Re-checked against current origin/main on 2026-03-29. This one still looks live. The key reason is unchanged: dispatch-acp.ts still does not appear to emit terminal ACP lifecycle events on the normal path, so the lifecycle/announce seam remains open.

This is currently my leading candidate for the lifecycle side of the ACP relay family.

vincentkoc · 2026-03-29T08:00:36Z

Re-checked against current origin/main on 2026-03-29. This one still looks live. The key reason is unchanged: dispatch-acp.ts still does not appear to emit terminal ACP lifecycle events on the normal path, so the lifecycle/announce seam remains open.

This is currently my leading candidate for the lifecycle side of the ACP relay family.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 230247d74d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vincentkoc · 2026-03-29T09:08:56Z

Follow-up review note after re-checking current main: codex-connector d/ looks valid. spawnAcpDirect() computes effectiveStreamToParent, but the accepted return shape still does not surface that bit, so sessions-spawn-tool.ts can only gate on the explicit streamTo !== "parent" request. That leaves the implicit parent-relay path at risk of being registry-tracked and double-signaled. This PR likely needs one more narrow fix before merge.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 219aa92af0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-29T09:32:29Z

+              cleanup: trackedCleanup,
+              label: label || undefined,
+              runTimeoutSeconds,
+              expectsCompletionMessage: true,


Suppress completion announces for inline ACP deliveries

When an ACP run-mode spawn originates from a non-subagent session with a usable delivery target, spawnAcpDirect already sends the child result inline to the user (deliver: true via its bootstrap delivery plan). This new registration always sets expectsCompletionMessage: true, which causes the subagent cleanup pipeline to run an additional completion announce and produce a second user-facing message for the same run. In normal channel sessions this creates deterministic duplicate replies; this should be gated so completion announces are only enabled for ACP spawns that were not already delivered inline.

Useful? React with 👍 / 👎.

…#40885) * Fix ACP sessions_spawn lifecycle tracking * fix(tests): resolve leftover merge markers in sessions spawn lifecycle test * fix(agents): clarify acp spawn cleanup semantics --------- Co-authored-by: Vincent Koc <vincentkoc@ieee.org>

pidgeon777 · 2026-04-01T19:33:09Z

We really hope this PR is merged soon because OpenClaw is currently unusable with sub-agents. In the latest version (2026.03.31), the inability to use sub-agents causes significant operational delays and makes the system much slower for multi-task workflows.

TheBlippo · 2026-04-04T17:05:48Z

This PR is what got sub-agents working again for me. Thanks @xaeon2026 for the thorough fix and @vincentkoc for pushing it through to merge. The detailed breakdown in the description made it easy to follow what was going wrong. Much appreciated.

…#40885) * Fix ACP sessions_spawn lifecycle tracking * fix(tests): resolve leftover merge markers in sessions spawn lifecycle test * fix(agents): clarify acp spawn cleanup semantics --------- Co-authored-by: Vincent Koc <vincentkoc@ieee.org>

Fix ACP sessions_spawn lifecycle tracking

a836cd4

openclaw-barnacle Bot added agents Agent runtime and tooling size: M labels Mar 9, 2026

greptile-apps Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread src/agents/tools/sessions-spawn-tool.ts

Comment thread src/agents/tools/sessions-spawn-tool.ts

jorgensandhaug mentioned this pull request Mar 18, 2026

RFC: ACP completion relay — unified approach to close the parent notification loop #49782

Closed

vincentkoc self-assigned this Mar 27, 2026

merge main into fix-acp-sessions-spawn-lifecycle

b60881f

chatgpt-codex-connector Bot reviewed Mar 28, 2026

View reviewed changes

Comment thread src/agents/openclaw-tools.subagents.sessions-spawn.lifecycle.test.ts Outdated

fix(tests): resolve leftover merge markers in sessions spawn lifecycl…

a84565a

…e test

This was referenced Mar 29, 2026

fix: enable ACP completion relay for main sessions #53256

Closed

fix: relay ACP parent completions reliably #53125

Closed

fix: register ACP runs in subagent registry and enable delivery to external channels #46412

Closed

Merge branch 'main' into fix-acp-sessions-spawn-lifecycle

230247d

chatgpt-codex-connector Bot reviewed Mar 29, 2026

View reviewed changes

Comment thread src/agents/tools/sessions-spawn-tool.ts

fix(agents): clarify acp spawn cleanup semantics

815db01

Merge branch 'main' into fix-acp-sessions-spawn-lifecycle

219aa92

vincentkoc merged commit 4432954 into openclaw:main Mar 29, 2026
8 checks passed

chatgpt-codex-connector Bot reviewed Mar 29, 2026

View reviewed changes

github-actions Bot mentioned this pull request Mar 29, 2026

📡 Upstream Digest — 2026-03-29 10:24 UTC curtismercier/openclaw-mods#400

Open

TheBlippo mentioned this pull request Apr 1, 2026

[Bug]: sessions_spawn returns (allowed: none) for subagent runtime despite valid configuration #58085

Closed

ronan-dandelion-cult mentioned this pull request Apr 3, 2026

Compaction death spiral on copilot proxy: heavier upstream compaction + provider timeout ceiling = unrecoverable sessions karmaterminal/openclaw#61

Open

This was referenced May 14, 2026

ACP: recover parent relay output from gateway state #45739

Closed

Codex ACP run can stall silently when gateway child environment lacks proxy/network access #44810

Closed

scotthuang mentioned this pull request Jun 3, 2026

fix: keep stream-to-parent spawns registered #89939

Merged

Uh oh!

Conversation

xaeon2026 commented Mar 9, 2026

Summary

Why both changes are needed

Tests

Verification

Uh oh!

greptile-apps Bot commented Mar 9, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

vincentkoc commented Mar 29, 2026

Uh oh!

vincentkoc commented Mar 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

vincentkoc commented Mar 29, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

pidgeon777 commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheBlippo commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pidgeon777 commented Apr 1, 2026 •

edited

Loading