Greptile Summary

This PR adds two configurable display-name resolution features to the Feishu integration — resolveGroupNames for group chat labels and resolveDmDisplayNames for DM labels — both defaulting to true for backward compatibility. The implementation refactors name resolution into dedicated helpers and aligns the DM member lookup with the current SDK path while retaining a compatibility fallback.

Key observations:

• The new config flags and defaults are correctly defined in config-schema.ts and respected at runtime in bot.ts with ?? true guards.
• The shared senderNameCache between DM and group lookup paths is an intentional optimization; display output is best-effort and does not affect routing or session keys.
• The channel.ts JSON schema receives the two new boolean fields but omits the closely-related pre-existing resolveSenderNames flag, creating an inconsistency where all three optimization flags are declared together in config-schema.ts (lines 172–174 and 221–223) but the schema only documents two of them.

Confidence Score: 4/5

• Safe to merge; all changes are display-only and backward-compatible with defaults of true.
• The logic is well-scoped (display labels only, no routing changes), defaults preserve existing behaviour, caching is correct, and 73 tests pass. One minor inconsistency exists in the channel.ts JSON schema where resolveSenderNames is absent alongside the two newly documented flags, creating incomplete documentation of the optimization flags group.
• extensions/feishu/src/channel.ts — the JSON schema omits resolveSenderNames while adding the two sibling flags.

_{Last reviewed commit: 823e02f}

Follow-up update: preserve Feishu unicode group names in session display labels and add topic/thread labels for topic-scoped Feishu sessions.

• Group display names now keep human-readable subject text (instead of slug fallback like g-oc_...).
• Topic-scoped sessions now attach ThreadLabel / MessageThreadId when root/topic context exists, so WebUI can show sub-topic context.
• Non-topic sessions keep thread fields unset (no fake topic).

Validation:

• extensions/feishu/src/bot.test.ts + extensions/feishu/src/config-schema.test.ts
• src/config/sessions.test.ts

Pushed a follow-up commit to fix the failing CI check on this PR:

• fix(ci): sync doctor gateway auth token test formatting
• Syncs src/commands/doctor-gateway-auth-token.test.ts with current main formatting so pnpm check passes again.

Local verification on the updated branch:

• pnpm check ✅
• pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/config-schema.test.ts ✅
• pnpm vitest run src/commands/doctor-gateway-auth-token.test.ts ✅

CI has been re-triggered after push; waiting for the full matrix results.

Follow-up update:

• Rebased this PR branch onto latest main and force-pushed.
• PR head is now 3a56c540adf30c28e2ba356e6107d0d0293d146f.
• Core regression checks for this PR change set are passing (including check).

Current blocker:

• secrets still fails on appcast.xml:364 during full detect-secrets fallback.
• This appears to be an upstream baseline issue (same failure pattern is present on recent main CI runs), not specific to this PR diff.

I can proceed with a baseline-focused follow-up patch if maintainers prefer unblocking this PR directly from here.

Refreshed this PR onto current main and reduced it to the remaining Feishu behavior changes that are still missing upstream. Duplicate combined draft #48898 was closed; this PR remains the canonical upstream Feishu thread.

Status update after refresh onto current main:

• This PR was rebuilt on top of current openclaw/main and now only keeps the remaining Feishu runtime behavior that is not in upstream yet.
• Older config-schema/type-layer churn from the previous branch version was intentionally dropped because current upstream main already covers that part.
• The duplicate combined draft PR was closed instead of maintaining overlapping review threads.

Current CI note:

• The failing Windows shards are hitting the same unrelated failures seen on another independent refreshed PR in this maintenance batch.
• The current failures are in src/plugins/bundle-mcp.test.ts, src/plugin-sdk/index.test.ts, src/memory/embeddings-gemini.test.ts, src/logging/logger.browser-import.test.ts, and src/hooks/plugin-hooks.test.ts.
• Those files are outside this PR's diff.

I am keeping this PR open because the remaining Feishu diff is still real and not covered by upstream yet.

Addressed the remaining lookup-compat concern in 79dae3206b. The refreshed branch now restores the original opt-out semantics by gating both DM display-name lookup and group-name lookup behind
esolveSenderNames again, so existing deployments with
esolveSenderNames: false do not start making new Feishu lookup calls. A regression test was added in extensions/feishu/src/bot.test.ts to cover both the DM and group paths.

Refreshed this PR onto current main and force-pushed the branch at 5ee8ac60fd.

This refresh ports the remaining Feishu behavior onto the current upstream sender-name split instead of keeping the older inline implementation:

• restore DM display-name fallback via chat-members lookup
• preserve the existing resolveSenderNames: false opt-out semantics for both DM and group lookups
• keep group session labels human-readable instead of falling back to raw or sluggified ids
• restore topic/thread labels for topic-scoped Feishu sessions
• keep sender name resolution working when the inbound event has user_id but thread history still uses open_id

Validation rerun on the refreshed branch:

• pnpm exec vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts
• pnpm exec vitest run src/config/sessions.test.ts
• pnpm check

CI has been re-triggered after the force-push.

Addressed one more multi-account edge here.

The sender/direct-member display-name cache is now scoped by �ccount.accountId, so the same open_id / user_id no longer leaks names across different Feishu accounts.

Pushed in 846684478c8ab925ead1d836f5767f2e0690cb22.

Added regression coverage in extensions/feishu/src/bot-sender-name.test.ts and verified with:

• pnpm exec vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot-sender-name.test.ts

Refreshed this branch onto the latest origin/main and kept the verified Feishu fixes in place.

Additional follow-up in this refresh:

• normalized topic thread labels so they no longer emit literal ? placeholders
• switched the group/topic separator to /
• switched truncated topic/thread-id fallbacks to ...
• added an assertion that the finalized ThreadLabel is now oc-group / Role-Task-Routing and does not contain ?

Scoped verification completed:

• pnpm exec vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/bot-sender-name.test.ts
• pnpm exec vitest run src/config/sessions.test.ts
• pnpm build

pnpm check still hits the current unrelated origin/main lint failure in src/infra/exec-approvals-allow-always.test.ts, so I did not expand this PR to fix that separate mainline issue.

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

Codex automated review: keeping this open.

Keep #38958 open. Current main at 406ae72 still lacks the PR's remaining Feishu runtime behavior: DM display-name fallback through chatMembers, resolved human-readable group labels, and root/topic-derived thread labels. The provided PR discussion also shows #38378 and #48898 were closed unmerged in favor of this thread, while #51032 only overlaps the group-label subset and does not supersede the DM/topic work.

Best possible solution:

Keep #38958 open for maintainer review, or land an equivalent focused Feishu implementation on main: add DM chatMembers display-name fallback with contact fallback and permission notices, scope sender/direct/group caches by account and relevant chat/sender ids, resolve group names after admission/dedup checks while preserving resolveSenderNames opt-out semantics, preserve human-readable Feishu group labels in session display names, surface root/topic labels only for topic-scoped sessions, and keep regression coverage for cache scoping plus user_id/open_id matching.

What I checked:

• DM path still uses sender/contact lookup only: handleFeishuMessage gates lookup with resolveSenderNames and calls resolveFeishuSenderName using ctx.senderOpenId; current main does not call a DM chatMembers fallback in this inbound path. (extensions/feishu/src/bot.ts:380, 406ae72fd278)
• Sender resolver is not the PR behavior: resolveFeishuSenderName still uses client.contact.user.get and a cache keyed only by normalized sender id. Current main has no resolveFeishuDirectNameFromChatMember, directMemberNameCache, or resolveFeishuGroupName symbols in the Feishu bot/sender resolver files. (extensions/feishu/src/bot-sender-name.ts:91, 406ae72fd278)
• Group subject remains raw chat id: The inbound context builder still sets GroupSubject to ctx.chatId for group messages, so session metadata is not receiving a resolved Feishu group display name from this path. (extensions/feishu/src/bot.ts:1065, 406ae72fd278)
• Topic labels remain generic: Topic-scoped sessions still synthesize ThreadLabel as Feishu thread in ${ctx.chatId} instead of deriving a root/topic label from fetched Feishu message content as requested by the PR. (extensions/feishu/src/bot.ts:946, 406ae72fd278)
• Session label builder still slugifies group labels generically: buildGroupDisplayName normalizes the raw group label through normalizeGroupLabel; there is no Feishu-specific branch preserving unicode group names and appending the stable chat id as in the PR diff. (src/config/sessions/group.ts:63, 406ae72fd278)
• Related PR context does not supersede this PR: The provided GitHub context records feat(feishu): split DM/group display names with members-only DM lookup #38378 and fix(feishu): restore naming paths and split control UI context notices #48898 as closed unmerged in favor of feat(feishu): configurable group and DM display-name resolution #38958. feat(feishu): display group name instead of chat_id in session labels #51032 remains a narrower group-name PR and does not cover the DM chatMembers fallback or topic/root label behavior.

Remaining risk / open question:

• The PR still needs normal maintainer review and CI because it changes Feishu runtime display metadata, lookup ordering, cache scoping, and permission-notice behavior.
• If maintainers prefer a narrower group-label implementation such as feat(feishu): display group name instead of chat_id in session labels #51032, the DM chatMembers fallback and topic/root label behavior from feat(feishu): configurable group and DM display-name resolution #38958 still need their own canonical tracker before this PR could close.

Codex Review notes: model gpt-5.5, reasoning high; reviewed against 406ae72fd278.

ProjectClownfish could not safely update this branch, so it opened a narrow replacement PR instead.

Replacement PR: #73399
Source PR: #38958
Contributor credit is preserved in the replacement PR body and changelog plan.