Skip to content

fix(feishu): remove invalid timeout properties from SDK method calls#38267

Merged
thewilloftheshadow merged 1 commit intoopenclaw:mainfrom
ant1eicher:fix/feishu-media-timeout-types
Mar 6, 2026
Merged

fix(feishu): remove invalid timeout properties from SDK method calls#38267
thewilloftheshadow merged 1 commit intoopenclaw:mainfrom
ant1eicher:fix/feishu-media-timeout-types

Conversation

@ant1eicher
Copy link
Copy Markdown
Contributor

@ant1eicher ant1eicher commented Mar 6, 2026 •
edited
Loading

Summary

  • Removes timeout property from four Lark SDK method calls in extensions/feishu/src/media.ts
  • The property is not part of the SDK method type signatures, causing TS2353 errors that break CI on main
  • The client-level httpTimeoutMs (set via createFeishuClient) already applies the 120s timeout to all requests, so no behavior change

Test plan

  • pnpm build passes
  • Feishu type errors resolved
  • CI passes

🤖 Generated with Claude Code

@openclaw-barnacle openclaw-barnacle Bot added channel: feishu Channel integration: feishu size: XS labels Mar 6, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 6, 2026

Greptile Summary

This PR fixes four TypeScript TS2353 compilation errors in extensions/feishu/src/media.ts by removing the timeout property from Lark SDK method call arguments, where it was never a valid option in the SDK's type signatures.

  • The 120-second timeout (FEISHU_MEDIA_HTTP_TIMEOUT_MS) is still correctly applied via httpTimeoutMs passed to createFeishuClient, which internally creates a createTimeoutHttpInstance wrapper that injects the timeout into every HTTP request. No behavior change occurs.
  • The constant FEISHU_MEDIA_HTTP_TIMEOUT_MS remains defined and used correctly at the client creation sites on lines 104, 142, 189, and 259.
  • The fix is minimal, accurate, and unblocks CI on main.

Confidence Score: 5/5

  • This PR is safe to merge — it's a purely type-correctness fix with no behavior change.
  • The removed timeout properties were silently ignored by the SDK at runtime (since they weren't in the method signatures), and the 120s timeout is fully preserved through the client-level httpTimeoutMs → createTimeoutHttpInstance mechanism. The change is isolated to a single file, affects only TS type correctness, and has no runtime impact.
  • No files require special attention.

Last reviewed commit: 3356c75

@ant1eicher @claude
fix(feishu): remove invalid timeout properties from SDK method calls
74f5a16 
The `timeout` property is not part of the Lark SDK method signatures,
causing TS2353 errors. The client-level `httpTimeoutMs` already applies
the timeout to all requests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ant1eicher ant1eicher force-pushed the fix/feishu-media-timeout-types branch from 3356c75 to 74f5a16 Compare March 6, 2026 18:51
@thewilloftheshadow thewilloftheshadow self-assigned this Mar 6, 2026
thewilloftheshadow added a commit that referenced this pull request Mar 6, 2026
@thewilloftheshadow
fix: remove Feishu SDK timeout fields (#38267) (thanks @ant1eicher)
973650e
@thewilloftheshadow thewilloftheshadow merged commit 20db7af into openclaw:main Mar 6, 2026
29 checks passed
@thewilloftheshadow thewilloftheshadow mentioned this pull request Mar 6, 2026
Merged
@thewilloftheshadow
Copy link
Copy Markdown
Member

thewilloftheshadow commented Mar 6, 2026

Landed via temp rebase onto main.

  • Gate: pnpm lint && pnpm build && pnpm test extensions/feishu/src/media.test.ts
  • Land commit: 20db7af
  • Merge commit: 20db7af

Thanks @ant1eicher!

@altaywtf altaywtf mentioned this pull request Mar 6, 2026
Closed
18 tasks
@jalehman jalehman mentioned this pull request Mar 6, 2026
Closed
3 tasks
mrosmarin added a commit to mrosmarin/openclaw that referenced this pull request Mar 6, 2026
@mrosmarin
Merge branch 'main' into feat/add-extraargs-to-zod-schema-tests
dd3e37e 
* main:
  fix: add no-ci-pr auto-response label
  docs: add changelog entry for Feishu timeouts (openclaw#38356)
  fix(feishu): remove invalid timeout properties from SDK method calls (openclaw#38267)
  docs: fix broken dashboard image on i18n pages (openclaw#38031)
@alexyyyander alexyyyander mentioned this pull request Mar 7, 2026
Closed
@ademczuk ademczuk mentioned this pull request Mar 7, 2026
Closed
7 tasks
vincentkoc pushed a commit to BryanTegomoh/openclaw-upstream that referenced this pull request Mar 8, 2026
@ant1eicher @claude @vincentkoc
fix(feishu): remove invalid timeout properties from SDK method calls (o…
7bb780a 
…penclaw#38267)

The `timeout` property is not part of the Lark SDK method signatures,
causing TS2353 errors. The client-level `httpTimeoutMs` already applies
the timeout to all requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot mentioned this pull request Mar 8, 2026
Open
jenawant pushed a commit to jenawant/openclaw that referenced this pull request Mar 10, 2026
@ant1eicher @claude @jenawant
fix(feishu): remove invalid timeout properties from SDK method calls (o…
f36a27a 
…penclaw#38267)

The `timeout` property is not part of the Lark SDK method signatures,
causing TS2353 errors. The client-level `httpTimeoutMs` already applies
the timeout to all requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@raymondworks raymondworks mentioned this pull request Mar 10, 2026
Closed
V-Gutierrez pushed a commit to V-Gutierrez/openclaw-vendor that referenced this pull request Mar 17, 2026
@ant1eicher @claude @V-Gutierrez
fix(feishu): remove invalid timeout properties from SDK method calls (o…
c6750c2 
…penclaw#38267)

The `timeout` property is not part of the Lark SDK method signatures,
causing TS2353 errors. The client-level `httpTimeoutMs` already applies
the timeout to all requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 20, 2026
@ant1eicher @claude @alexey-pelykh
fix(feishu): remove invalid timeout properties from SDK method calls (o…
577ff84 
…penclaw#38267)

The `timeout` property is not part of the Lark SDK method signatures,
causing TS2353 errors. The client-level `httpTimeoutMs` already applies
the timeout to all requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
(cherry picked from commit 20db7af)
alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 20, 2026
@ant1eicher @claude @alexey-pelykh
fix(feishu): remove invalid timeout properties from SDK method calls (o…
7617495 
…penclaw#38267)

The `timeout` property is not part of the Lark SDK method signatures,
causing TS2353 errors. The client-level `httpTimeoutMs` already applies
the timeout to all requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
(cherry picked from commit 20db7af)
dustin-olenslager pushed a commit to dustin-olenslager/ironclaw-supreme that referenced this pull request Mar 24, 2026
@thewilloftheshadow
fix: remove Feishu SDK timeout fields (openclaw#38267) (thanks @ant1e…
d8ed42a 
…icher)
lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026
@ant1eicher @claude
fix(feishu): remove invalid timeout properties from SDK method calls (o…
28cd996 
…penclaw#38267)

The `timeout` property is not part of the Lark SDK method signatures,
causing TS2353 errors. The client-level `httpTimeoutMs` already applies
the timeout to all requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
@ant1eicher @claude
fix(feishu): remove invalid timeout properties from SDK method calls (o…
eec999c 
…penclaw#38267)

The `timeout` property is not part of the Lark SDK method signatures,
causing TS2353 errors. The client-level `httpTimeoutMs` already applies
the timeout to all requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
DexterSLamb pushed a commit to DexterSLamb/openclaw-tianjun that referenced this pull request May 3, 2026
@thewilloftheshadow
fix: remove Feishu SDK timeout fields (openclaw#38267) (thanks @ant1e…
875c057 
…icher)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thewilloftheshadow thewilloftheshadow

Labels

channel: feishu Channel integration: feishu size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ant1eicher @thewilloftheshadow