Fix Control UI duplicate iMessage replies for internal webchat turns by vincentkoc · Pull Request #36151 · openclaw/openclaw

vincentkoc · 2026-03-05T13:01:19Z

Summary

Problem: Control UI webchat turns were rerouting replies to OriginatingChannel and duplicating messages into iMessage.
Why it matters: Dashboard users were seeing every reply echoed to iMessage after upgrading to 2026.3.2+.
What changed: tightened routing guard in dispatchReplyFromConfig to keep true internal webchat turns on dispatcher delivery.
What did NOT change (scope boundary): preserved webchat-provider relay behavior when Surface carries a non-webchat external channel.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Control UI chat replies no longer duplicate to iMessage when the turn is internal webchat (provider=webchat, surface=webchat).
Existing routed relay flows (for example provider webchat with external surface metadata) still route to the originating external channel.

Security Impact (required)

New permissions/capabilities? (No)
Secrets/tokens handling changed? (No)
New/changed network calls? (No)
Command/tool execution surface changed? (No)
Data access scope changed? (No)
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: macOS
Runtime/container: Node.js + pnpm
Model/provider: n/a
Integration/channel (if any): Control UI webchat + iMessage
Relevant config (redacted): provider=webchat, surface=webchat, originatingChannel=imessage

Steps

Send a message from Control UI webchat in a shared/main session with iMessage origin metadata present.
Observe reply dispatch path.
Repeat for relayed flow where provider is webchat but surface/origin is external.

Expected

Internal webchat turns stay in UI dispatcher path.
Relayed external surface turns still route externally.

Actual

Verified with targeted regression tests.

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

pnpm test src/auto-reply/reply/dispatch-from-config.test.ts

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios: targeted routing behavior for internal webchat vs relayed external surface cases.
Edge cases checked: provider=webchat with Surface=telegram|feishu still routes; provider=webchat with Surface=webchat does not reroute externally.
What you did not verify: full end-to-end live iMessage run on hardware.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly: revert this PR commits.
Files/config to restore: src/auto-reply/reply/dispatch-from-config.ts
Known bad symptoms reviewers should watch for: relayed webchat-origin messages failing to route to their external channel.

Risks and Mitigations

Risk: Routing guard could suppress legitimate cross-provider relay sends.
- Mitigation: explicit regression tests cover provider=webchat + external surface routing and provider-matches-origin no-route behavior.

…igin metadata

…uard

greptile-apps · 2026-03-06T05:31:23Z

Greptile Summary

This PR fixes a regression introduced in 2026.3.2 where Control UI webchat replies were being erroneously duplicated into iMessage. The root cause was that dispatchReplyFromConfig would route to OriginatingChannel (e.g., iMessage) even when the current turn was a pure internal webchat turn (provider=webchat, surface=webchat), because the existing guard only checked that originatingChannel !== currentSurface without accounting for the fact that webchat surface metadata can have iMessage origin context from a shared session.

Key changes:

Introduces an isInternalWebchatTurn boolean that is true when both currentSurface and surfaceChannel resolve to INTERNAL_MESSAGE_CHANNEL ("webchat"), or when surfaceChannel is absent (indicating no relay metadata).
Gates shouldRouteToOriginating behind !isInternalWebchatTurn, so pure webchat turns stay on the local dispatcher delivery path.
Preserves the relay path for cases where Provider=webchat but Surface carries an external channel identifier (e.g., Surface=feishu), which is the legitimate cross-provider relay scenario.
Adds a targeted regression test covering provider=webchat, surface=webchat, originatingChannel=imessage to confirm routeReply is not invoked.

Confidence Score: 4/5

This PR is safe to merge — the routing guard is logically sound and well-tested, with a minor unverified attribution in the CHANGELOG.
The fix is minimal and focused: a two-condition boolean guard that correctly preserves the relay path for external surfaces while blocking erroneous rerouting for pure internal webchat turns. The new test directly covers the regression scenario, and existing tests confirm relay flows (feishu, telegram, provider-matches-origin) still behave correctly. The only flag is a potential @alicexmolt vs @vincentkoc attribution mismatch in the CHANGELOG, which is cosmetic and doesn't affect correctness.
CHANGELOG.md — verify the @alicexmolt attribution is intentional given the PR author is vincentkoc.

Comments Outside Diff (1)

CHANGELOG.md, line 24 (link)

Potential attribution mismatch

The new CHANGELOG entry credits @alicexmolt, but the PR author is vincentkoc. The preceding entry (for the inline reply tags fix) correctly credits @vincentkoc. If @alicexmolt is not the actual contributor of this fix, this attribution should be corrected to avoid crediting the wrong person.

_{Last reviewed commit: 07498a7}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07498a78e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/auto-reply/reply/dispatch-from-config.ts

… turns

…penclaw#36151) * Auto-reply: avoid routing external replies from internal webchat turns * Auto-reply tests: cover internal webchat non-routing with external origin metadata * Changelog: add Control UI iMessage duplicate-reply fix note * Auto-reply context: track explicit deliver routes * Gateway chat: mark explicit external deliver routes in context * Auto-reply: preserve explicit deliver routes for internal webchat turns * Auto-reply tests: cover explicit deliver routes from internal webchat turns * Gateway chat tests: assert explicit deliver route context tagging

vincentkoc added 3 commits March 5, 2026 08:00

Auto-reply: avoid routing external replies from internal webchat turns

2b8588b

Auto-reply tests: cover internal webchat non-routing with external or…

be71fda

…igin metadata

Changelog: add Control UI iMessage duplicate-reply fix note

def1ec2

vincentkoc self-assigned this Mar 5, 2026

openclaw-barnacle bot added size: XS maintainer Maintainer-authored PR labels Mar 5, 2026

vincentkoc marked this pull request as ready for review March 6, 2026 05:29

Merge branch 'main' into vincentkoc-code/fix-webchat-origin-routing-g…

07498a7

…uard

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

src/auto-reply/reply/dispatch-from-config.ts Show resolved Hide resolved

vincentkoc added 5 commits March 6, 2026 00:40

Auto-reply context: track explicit deliver routes

b437be4

Gateway chat: mark explicit external deliver routes in context

732d1e5

Auto-reply: preserve explicit deliver routes for internal webchat turns

4353207

Auto-reply tests: cover explicit deliver routes from internal webchat…

ec08a8d

… turns

Gateway chat tests: assert explicit deliver route context tagging

1abdf03

openclaw-barnacle bot added app: web-ui App: web-ui gateway Gateway runtime size: S and removed size: XS labels Mar 6, 2026

vincentkoc merged commit 6c39616 into main Mar 6, 2026
31 of 32 checks passed

vincentkoc deleted the vincentkoc-code/fix-webchat-origin-routing-guard branch March 6, 2026 05:48

github-actions bot mentioned this pull request Mar 6, 2026

📡 Upstream Digest — 2026-03-06 06:37 UTC curtismercier/openclaw-mods#190

Open

alexyyyander mentioned this pull request Mar 7, 2026

fix/gateway token mismatch 38617 #38676

Closed

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: gateway HEIC images, schema lookup, SecretRef degradation remoteclaw/remoteclaw#835

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Control UI duplicate iMessage replies for internal webchat turns#36151

Fix Control UI duplicate iMessage replies for internal webchat turns#36151
vincentkoc merged 9 commits intomainfrom
vincentkoc-code/fix-webchat-origin-routing-guard

vincentkoc commented Mar 5, 2026

Uh oh!

greptile-apps bot commented Mar 6, 2026 •

edited

Loading

Comments Outside Diff (1)

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vincentkoc commented Mar 5, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

greptile-apps bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Comments Outside Diff (1)

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps bot commented Mar 6, 2026 •

edited

Loading