feishu: honor configured default account in outbound resolution by bmendonca3 · Pull Request #32253 · openclaw/openclaw

bmendonca3 · 2026-03-02T22:36:56Z

Summary

Problem: Feishu defaultAccount preference can be ignored when the preferred id is not present in accounts map.
Why it matters: outbound account resolution can route through an unintended account.
What changed: default account resolution now honors configured defaultAccount directly, with normalization and regression coverage.
What did NOT change: no changes to credential loading semantics beyond account selection precedence.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related #

User-visible / Behavior Changes

Feishu account selection now respects configured defaultAccount even when account entries are sparse.

Security Impact (required)

New permissions/capabilities? (Yes/No) No
Secrets/tokens handling changed? (Yes/No) No
New/changed network calls? (Yes/No) No
Command/tool execution surface changed? (Yes/No) No
Data access scope changed? (Yes/No) No

Repro + Verification

Steps

Configure channels.feishu.defaultAccount to a value not present in channels.feishu.accounts keys.
Resolve default Feishu account id and run account resolution without explicit accountId.
Verify preferred defaultAccount is used.

Evidence

Failing test/log before + passing after

Human Verification (required)

Verified scenarios: pnpm -s vitest run extensions/feishu/src/accounts.test.ts
Edge cases checked: normalization and missing-account-map preference behavior.
What you did not verify: live Feishu API call path.

Compatibility / Migration

Backward compatible? (Yes/No) Yes
Config/env changes? (Yes/No) No
Migration needed? (Yes/No) No

Failure Recovery (if this breaks)

How to disable/revert this change quickly: revert this PR commit.
Files/config to restore: extensions/feishu/src/accounts.ts, extensions/feishu/src/accounts.test.ts
Known bad symptoms reviewers should watch for: wrong Feishu account selected for outbound actions.

Risks and Mitigations

Risk: behavior shift for configurations that relied on previous fallback selection.
- Mitigation: explicit regression tests document and lock expected precedence.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d46a70387

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T22:40:45Z

extensions/feishu/src/accounts.ts

+  if (preferred) {
    return preferred;


Restore fallback when preferred account has no config

Returning preferred unconditionally here causes stale or typoed channels.feishu.defaultAccount values to resolve to an account ID that may not exist in accounts. In common multi-account configs where credentials are only stored under accounts[...], resolveFeishuAccount then produces an unconfigured account and downstream calls (for example message sends) fail with missing-credentials errors, while the previous logic safely fell back to default/first configured account. This can be triggered after deleting the previously default account because defaultAccount is not cleared in extensions/feishu/src/channel.ts.

Useful? React with 👍 / 👎.

greptile-apps · 2026-03-02T22:41:41Z

Greptile Summary

This PR fixes a bug in Feishu account resolution where the configured defaultAccount preference could be silently ignored if that account ID wasn't present in the accounts map. The fix removes the validation check ids.includes(preferred) so that the configured defaultAccount is always honored, even when not explicitly defined in the accounts map. This allows the account to fall back to base credentials, which is the correct behavior per the configuration hierarchy. The change is minimal (3 lines of code logic), focused on the specific issue, and includes regression test coverage that documents the expected precedence behavior.

Confidence Score: 4/5

Safe to merge with minimal risk
The change is focused, well-tested, and fixes a legitimate bug in account resolution logic. Downstream code (resolveFeishuAccount) handles the case where an account ID might not be in the accounts map by gracefully falling back to base credentials. One point deducted for potential backward compatibility impact on configurations that may have relied on the previous fallback behavior, though the old behavior was arguably incorrect as it ignored explicit user configuration.
No files require special attention

_{Last reviewed commit: 6d46a70}

@bmendonca3

…nks @bmendonca3)

aisle-research-bot · 2026-03-03T01:13:20Z

🤖 We're reviewing this PR with Aisle

We're running a security check on the changes in this PR now. This usually takes a few minutes. ⌛
We'll post the results here as soon as they're ready.

Progress:

Analysis
Triage
Finalization

Latest run failed. Keeping previous successful results. Trace ID: 019cb141a43d931d0b85df2e1c7762c9.

_{Last updated on: 2026-03-03T01:13:27Z}

steipete · 2026-03-03T01:13:27Z

Landed via temp rebase onto main.

Gate:
RUN v4.0.18 /Users/steipete/Projects/clawdbot2

✓ extensions/feishu/src/accounts.test.ts (7 tests) 10ms

Test Files 1 passed (1)
Tests 7 passed (7)
Start at 01:13:26
Duration 294ms (transform 143ms, setup 156ms, import 22ms, tests 10ms, environment 0ms)

Land commit: 050d903
Merge commit: 1187464

Thanks @bmendonca3!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 050d903cf8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-03T01:17:56Z

extensions/feishu/src/accounts.ts

+  if (preferred) {
    return preferred;


Keep fallback when default account key is missing

Returning preferred unconditionally means a stale or misspelled channels.feishu.defaultAccount now resolves to an account ID that may not exist in accounts, so resolveFeishuAccount({ accountId: undefined }) can become unconfigured when credentials are only stored under accounts[...] and outbound sends fail with missing credentials instead of falling back to a valid account. Fresh evidence: extensions/feishu/src/channel.ts only validates defaultAccount as a plain string (no membership check), and deleteAccount does not clear defaultAccount, so this bad state is reachable through normal config edits.

Useful? React with 👍 / 👎.

@bmendonca3

…nks @bmendonca3)

@bmendonca3

…nks @bmendonca3)

@bmendonca3

…nks @bmendonca3)

@bmendonca3

…nks @bmendonca3)

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: XS experienced-contributor labels Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

bmendonca3 and others added 2 commits March 3, 2026 01:12

Feishu: honor configured default account

9f31d81

fix: feishu default account outbound resolution (openclaw#32253) (tha…

050d903

…nks @bmendonca3)

steipete force-pushed the bm/feishu-default-account-outbound-r3 branch from 6d46a70 to 050d903 Compare March 3, 2026 01:13

steipete merged commit 1187464 into openclaw:main Mar 3, 2026
9 checks passed

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 3, 2026

📡 Upstream Digest — 2026-03-03 01:23 UTC curtismercier/openclaw-mods#168

Open

dawi369 pushed a commit to dawi369/davis that referenced this pull request Mar 3, 2026

fix: feishu default account outbound resolution (openclaw#32253) (tha…

0495386

…nks @bmendonca3)

OWALabuy pushed a commit to kcinzgg/openclaw that referenced this pull request Mar 4, 2026

fix: feishu default account outbound resolution (openclaw#32253) (tha…

3fb3d44

…nks @bmendonca3)

AytuncYildizli pushed a commit to AytuncYildizli/openclaw that referenced this pull request Mar 4, 2026

fix: feishu default account outbound resolution (openclaw#32253) (tha…

3534b2f

…nks @bmendonca3)

zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

fix: feishu default account outbound resolution (openclaw#32253) (tha…

da7413d

…nks @bmendonca3)

github-actions bot mentioned this pull request Mar 6, 2026

上游更新: v2026.3.2, v2026.3.1, v2026.2.26, v2026.2.25, v2026.2.24 — 139 P0 + 235 P1 待合并 jiulingyun/openclaw-cn#479

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feishu: honor configured default account in outbound resolution#32253

feishu: honor configured default account in outbound resolution#32253
steipete merged 2 commits intoopenclaw:mainfrom
bmendonca3:bm/feishu-default-account-outbound-r3

bmendonca3 commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Uh oh!

greptile-apps bot commented Mar 2, 2026

Uh oh!

Uh oh!

aisle-research-bot bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

steipete commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

bmendonca3 commented Mar 2, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Steps

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

aisle-research-bot bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aisle-research-bot bot commented Mar 3, 2026 •

edited

Loading